[Bug 1547864] Re: libinput doesn't handle EV_KEY event with a value of 255 (BUTTON_CANCLED), to support Android home buttons

2016-03-14 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: libinput (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1547864 Title:

[Bug 1547864] Re: libinput doesn't handle EV_KEY event with a value of 255 (BUTTON_CANCLED), to support Android home buttons

2016-02-28 Thread Chris Halse Rogers
I guess what I'm arguing for is adding a key-is-cancellable quirk to libinput and only emitting a KEY_DOWN/KEY_UP pair once the device has emitted KEY_UP :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1547864] Re: libinput doesn't handle EV_KEY event with a value of 255 (BUTTON_CANCLED), to support Android home buttons

2016-02-28 Thread Chris Halse Rogers
>> My concern with adding cancellation behaviour is that there'll be no existing client or toolkit that expects it, and we can't make it opt-in (like the opt-in touch cancellation support). >That's a good point but extra events are kind of opt-in already with zero code change for most clients. If

[Bug 1547864] Re: libinput doesn't handle EV_KEY event with a value of 255 (BUTTON_CANCLED), to support Android home buttons

2016-02-24 Thread Daniel van Vugt
Another handy trick used in GUI toolkits is to introduce a "clicked" event created by the toolkit. So simple apps don't need to track button states, only listen for the 'clicked' event and ignore all other events. So a button might receive any of these sequences of events: press -> appearance

[Bug 1547864] Re: libinput doesn't handle EV_KEY event with a value of 255 (BUTTON_CANCLED), to support Android home buttons

2016-02-24 Thread Daniel van Vugt
Analogously in the case of GUI toolkits, one would usually act on a button release, but only if it was preceded by a button press. The app however could encounter a press without a release (mouse dragged off the button) or a release without a press (mouse dragged onto the button). In the former

[Bug 1547864] Re: libinput doesn't handle EV_KEY event with a value of 255 (BUTTON_CANCLED), to support Android home buttons

2016-02-24 Thread Andreas Pokorny
We might not need to emit 'cancel' for keys being pressed while switching away - it might be enough to treat vt switching as focus gaining state change.. during which we have to inform the client about all currently pressed keys and buttons.. -- You received this bug notification because you are

[Bug 1547864] Re: libinput doesn't handle EV_KEY event with a value of 255 (BUTTON_CANCLED), to support Android home buttons

2016-02-24 Thread Daniel van Vugt
> My concern with adding cancellation behaviour is that there'll be no existing client or toolkit that expects it, and we can't make it opt-in (like the opt-in touch cancellation support). That's a good point but extra events are kind of opt-in already with zero code change for most clients. If

[Bug 1547864] Re: libinput doesn't handle EV_KEY event with a value of 255 (BUTTON_CANCLED), to support Android home buttons

2016-02-24 Thread Chris Halse Rogers
Either way, should probably be raised with upstream libinput. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1547864 Title: libinput doesn't handle EV_KEY event with a value of 255

[Bug 1547864] Re: libinput doesn't handle EV_KEY event with a value of 255 (BUTTON_CANCLED), to support Android home buttons

2016-02-24 Thread Chris Halse Rogers
Urgh. My immediate reaction is “that touchscreen shouldn't be emulating a keyboard, damnit”. My concern with adding cancellation behaviour is that there'll be no existing client or toolkit that expects it, and we can't make it opt-in (like the opt-in touch cancellation support). Could we quirk

[Bug 1547864] Re: libinput doesn't handle EV_KEY event with a value of 255 (BUTTON_CANCLED), to support Android home buttons

2016-02-23 Thread Alan Griffiths
"Cancelled" would appear to be a behaviour that is "out there" - so adding it to libinput & Mir is a natural solution. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1547864 Title: libinput doesn't