[Bug 1651704] Related fix merged to tripleo-common (master)

[OpenStack Infra]

Reviewed:  https://review.openstack.org/425047
Committed: 
https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5435d9d8235349c986de6fef07d347431ca243ba
Submitter: Jenkins
Branch:master

commit 5435d9d8235349c986de6fef07d347431ca243ba
Author: Dougal Matthews 
Date:   Wed Jan 25 08:06:27 2017 +

Use the builtin Mistral engine command 'fail' when failing workflows

In changes 12f7345, c2fb9b0, 6051a74, c7b01eb and ab946c4 Mistral
Workflows were marked as failed if they sent a Zaqar message with the
status "FAILED". This is correct, but it turns out there is an easier
way to do it.

Mistral has a engine command designed for this purpose, using it removes
some of the duplication we have incurred.

We use on-success rather than on-complete to surface the best error on
the workflow. If the Zaqar queue post fails, then the workflow will fail
with this error. If, on-complete we then manually mark the workflow as
failed it will ovrwrite the Zaqar error with a generic one.

Closes-Bug: #1664918
Related-Bug: #1651704
Change-Id: I9ef9cfef1b8740a535e005769ec0c3ad67ecb103

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1651704

Title:
  Errors when starting introspection are silently ignored

To manage notifications about this bug go to:
https://bugs.launchpad.net/ironic-inspector/+bug/1651704/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1651704] Related fix merged to tripleo-common (master)

[OpenStack Infra]

Reviewed:  https://review.openstack.org/418966
Committed: 
https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=c2fb9b025d727fdbfae27d1f25f58efae1cb7679
Submitter: Jenkins
Branch:master

commit c2fb9b025d727fdbfae27d1f25f58efae1cb7679
Author: Dougal Matthews 
Date:   Wed Jan 11 14:21:06 2017 +

Fail the scale workflows when sending a "FAILED" message

When Mistral workflows execute a second workflow (a sub-workflow
execution), the parent workflow can't easily determine if sub-workflow
failed.  This is because the failure is communicated via a Zaqar message
only and when a workflow ends with a successful Zaqar message it appears
have been successful. This problem surfaces because parent workflows
should have an "on-error" attribute but it is never called, as the
workflow doesn't error.

This change marks the workflow as failed if the message has the status
"FAILED". Now when a sub-workflow fails, the task that called it should
have the on-error triggered. Previously it would always go to
on-success.

Change-Id: I73c5965627e45b8151f67aaf8025369bf6c870bb
Related-Bug: #1651704

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1651704

Title:
  Errors when starting introspection are silently ignored

To manage notifications about this bug go to:
https://bugs.launchpad.net/ironic-inspector/+bug/1651704/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1651704] Related fix merged to tripleo-common (master)

[OpenStack Infra]

Reviewed:  https://review.openstack.org/418961
Committed: 
https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=12f734562c5925c9260a3f038d570a7910c51cfb
Submitter: Jenkins
Branch:master

commit 12f734562c5925c9260a3f038d570a7910c51cfb
Author: Dougal Matthews 
Date:   Wed Jan 11 14:12:44 2017 +

Fail the deployment workflows when sending a "FAILED" message

When Mistral workflows execute a second workflow (a sub-workflow
execution), the parent workflow can't easily determine if sub-workflow
failed.  This is because the failure is communicated via a Zaqar message
only and when a workflow ends with a successful Zaqar message it appears
have been successful. This problem surfaces because parent workflows
should have an "on-error" attribute but it is never called, as the
workflow doesn't error.

This change marks the workflow as failed if the message has the status
"FAILED". Now when a sub-workflow fails, the task that called it should
have the on-error triggered. Previously it would always go to
on-success.

Change-Id: Ic1781bcf3922da61d42970cf2b42c951f83f7a74
Related-Bug: #1651704

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1651704

Title:
  Errors when starting introspection are silently ignored

To manage notifications about this bug go to:
https://bugs.launchpad.net/ironic-inspector/+bug/1651704/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1651704] Related fix merged to tripleo-common (master)

[OpenStack Infra]

Reviewed:  https://review.openstack.org/418968
Committed: 
https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=6051a7446bdf415e18ddc5f25697759ca488be17
Submitter: Jenkins
Branch:master

commit 6051a7446bdf415e18ddc5f25697759ca488be17
Author: Dougal Matthews 
Date:   Wed Jan 11 14:23:25 2017 +

Fail the validation workflows when sending a "FAILED" message

When Mistral workflows execute a second workflow (a sub-workflow
execution), the parent workflow can't easily determine if sub-workflow
failed.  This is because the failure is communicated via a Zaqar message
only and when a workflow ends with a successful Zaqar message it appears
have been successful. This problem surfaces because parent workflows
should have an "on-error" attribute but it is never called, as the
workflow doesn't error.

This change marks the workflow as failed if the message has the status
"FAILED". Now when a sub-workflow fails, the task that called it should
have the on-error triggered. Previously it would always go to
on-success.

Change-Id: I2170afac89e8261c1e2289da8e9220694fadbad0
Related-Bug: #1651704

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1651704

Title:
  Errors when starting introspection are silently ignored

To manage notifications about this bug go to:
https://bugs.launchpad.net/ironic-inspector/+bug/1651704/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1651704] Related fix merged to tripleo-common (master)

[OpenStack Infra]

Reviewed:  https://review.openstack.org/418964
Committed: 
https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=ab946c4a0e6b0bf5bc0b31e93af455af5b1887dc
Submitter: Jenkins
Branch:master

commit ab946c4a0e6b0bf5bc0b31e93af455af5b1887dc
Author: Dougal Matthews 
Date:   Wed Jan 11 14:16:50 2017 +

Fail the plan_management workflows when sending a "FAILED" message

When Mistral workflows execute a second workflow (a sub-workflow
execution), the parent workflow can't easily determine if sub-workflow
failed.  This is because the failure is communicated via a Zaqar message
only and when a workflow ends with a successful Zaqar message it appears
have been successful. This problem surfaces because parent workflows
should have an "on-error" attribute but it is never called, as the
workflow doesn't error.

This change marks the workflow as failed if the message has the status
"FAILED". Now when a sub-workflow fails, the task that called it should
have the on-error triggered. Previously it would always go to
on-success.

Change-Id: Ie0f1d4e57505e9346ae3f0b25d755f55d73a255a
Related-Bug: #1651704

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1651704

Title:
  Errors when starting introspection are silently ignored

To manage notifications about this bug go to:
https://bugs.launchpad.net/ironic-inspector/+bug/1651704/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs