Hi Eric, all,
| The only thing missing that I can think of right now are to release the
| upstream fixes for which I think has been merged upstream in 4.0.0 version
Just a heads up that the pcp-4.0.0 release happened a few weeks back, and
included all of Eric's fixes as well as several others
** Tags added: id-5a04ca62ac08e7d73d51f1cd
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1700827
Title:
[MIR] pcp package
To manage notifications about this bug go to:
things which should be addressed:
- Debian #805955, this is not fixed.
You should not call dh_* in the binary-arch target without -a,
working on the Arch: all packages as well. That should be done
in the binary-indep target with dh_* -i calls.
- python-six, python-json-pointer as
3.12.2-1 from Debian got auto-synced in Ubuntu bionic
* Default to building with Qt5 (closes: #875093)
* Add missing Qt5 svg dependency (closes: #881649)
* Switch from native to quilt form (closes: #881650)
* Changing compatibility level from 5 to 9
That should cover what I have
Re systemd.
Commit a59111b in my upstream tree turns on use of systemd in PCP for
all Debian-based platforms that configure thinks they're running a real
systemd. This code has been heavily exercised on the non-Debian
platforms for a long time, and my testing on Ubuntu 17.04 and 17.10
suggests
** Patch removed: "pcp_3.12.2-0ubuntu1-bionic-V2.debdiff"
https://bugs.launchpad.net/ubuntu/+source/pcp/+bug/1700827/+attachment/5012435/+files/pcp_3.12.2-0ubuntu1-bionic-V2.debdiff
** Patch removed: "pcp_3.12.2-0ubuntu1-bionic.debdiff"
About the pmatop segfault in 3.12.2
I just have tested 4.0.0 on Bionic and pmatop no longer segfault.
$ pmatop
pmatop: no per-disk values available
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Additionally, PCP upstream change the debhelper compatibility level
(debian/compat) first introduced in commit : eb1ea37[1]
Hopefully this will also land in Debian soon, in order to make the
change in Ubuntu pcp pkg as well.
[1] - https://github.com/performancecopilot/pcp/commit/eb1ea37 (Thu Nov
Additionally, PCP upstream change the debhelper compatibility level
(debian/compat) first introduced in commit : eb1ea37[1] from "5" to "9".
Hopefully this will also land in Debian soon, in order to make the
change in Ubuntu pcp pkg as well.
[1] -
With the upstream changes mentioned above and a couple of tweaks
(everything up to and including commit f09cac4), I've been able to
complete a build, package, install and start PCP operation on all the
machines in my PCP QA Farm.
This means:
amd64 FreeBSD 10.2-RELEASE, amd64 OpenBSD 5.8
i386
Nathan have committed upstream the two changes I have submitted :
* [894c007] build: switch deb builds to using the quilt-based format
- LP: #1733646
- debbug: #881650
* [e165a12] build: add in a missing a Qt5-specific svg library dependency
- LP: #1733619
- Debbug: #881649
Once the 2 above
** Patch added: "pcp_3.12.2-0ubuntu1-bionic-V2.debdiff"
https://bugs.launchpad.net/ubuntu/+source/pcp/+bug/1700827/+attachment/5012435/+files/pcp_3.12.2-0ubuntu1-bionic-V2.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
I have created a new debdiff [pcp_3.12.2-0ubuntu1-bionic-V2.debdiff]
including: (LP: #1733646) & (LP: #1733619) in the changelog for the bug
I have reported today.
+ * d/source/format: Switch to dpkg-source 3.0 (quilt) format. (LP: #1733646)
+ * d/control: Add libqt5svg5-dev as a Build-Depends
# pcp - convert dpkg-source format to 3.0 (quilt)
https://bugs.launchpad.net/bugs/1733646
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1700827
Title:
[MIR] pcp package
To manage notifications
# Missing build dependency for Ubuntu :
https://bugs.launchpad.net/bugs/1733619 (related to debbug #881649)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1700827
Title:
[MIR] pcp package
To manage
I have reported another debian bug for pmatop (as discovered by
Christian)
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881822
Will have a look when I have more available time.
** Bug watch added: Debian Bug tracker #881822
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881822
--
Debian bugs related to my above comment ^
# Missing dependency
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881649
# Convert from 3.0 (native) to 3.0 (quilt)
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881650
- Eric
** Bug watch added: Debian Bug tracker #881649
debdiff for bionic --> pcp_3.12.2-0ubuntu1-bionic.debdiff
* d/source/format: Switch to dpkg-source 3.0 (quilt) format.
* d/control: Add libqt5svg5-dev as a Build-Depends package.
- Eric
** Patch added: "pcp_3.12.2-0ubuntu1-bionic.debdiff"
Additionally,
Looking at the update_excuses page[1], I noticed pcp (3.12.2) is stuck
in bionic-proposed[2] for 11 days now and was set as "Not considered"
At first glance, it seems the pkg failed to build because of a missing
Build-Depends "libqt5svg5-dev"
[1] update excuses page
Hi Natha,
I'll take care of the dpkg-source format change from "3.0 (native)" to
"3.0 (quilt)".
- Eric
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1700827
Title:
[MIR] pcp package
To manage
| Using a proper 3.0 (quilt) package would make it easier to [...]
This sounds like a good way to go. I'll assume Eric (or someone else from
Canonical/Ubuntu) is going to follow up with us on this ... chatting to Ken
earlier, this is a bit beyond our knowledge and it'll be best all round if
the
+1 on converting the package to a 3.0 quilt format, plus using debhelper
9 and fixing the plethora of lintian warnings.
Bonus points to accept the hardening flags in the build, using parallel
builds, and fixing the Multi-Arch hints.
--
You received this bug notification because you are a member
Eric,
Please make sure there is a team subscriber for pcp bugs, this is a
requirement for inclusion in main. This may be the Server Team, but they
should know about it and agree to sign up for the extra work (however
small it may be).
** Changed in: pcp (Ubuntu)
Assignee: Mathieu
Using compat 5 isn't wrong per se, but I did notice the need to
modernize the packaging, and discussed this with Eric already. Using
newer packaging makes it easier to maintain the package in the long run,
as new developers may not know of or understand older tricks. A promise
to keep improving
> - Why is this set as a native package?
This is for convenience of PCP developers - in particular,
both Ken and I regularly build and use the .deb packages in
our testing processes. The PCP project also release binary
debs with each release using the local (native) packaging -
> Why is this set as a native package? It's rather obviously not one, as
it also ships and works on other distributions.
I don't know why, maybe Nathan Scott will have more context, but yeah
this should be set to non-native as it is clearly also useful outside
Debian context.
--
I'm doing this review (I'm not done though).
As a preliminary comment as to my view of the state of the package (as
notes to self so I don't forget):
- Why is this set as a native package? It's rather obviously not one, as it
also ships and works on other distributions.
- pcp is still using
I believe it's really useful to also include papi [1] in main as it is a
dependency of pcp and offers support for the performance counter hardware in
many processor types providing a low-level source of metrics.
This ofc seems like an important feature in a performance monitoring suite.
[1]
** Changed in: pcp (Ubuntu)
Importance: Undecided => Medium
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1700827
Title:
[MIR] pcp package
To manage notifications about this bug go to:
** Changed in: pcp (Ubuntu)
Status: Confirmed => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1700827
Title:
[MIR] pcp package
To manage notifications about this bug go to:
** Changed in: pcp (Ubuntu)
Assignee: Dariusz Gadomski (dgadomski) => (unassigned)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1700827
Title:
[MIR] pcp package
To manage notifications about
Hello Frank, Ken, and Nathan,
Very nice work.
I'm impressed with the changes I see in the PCP repository. The changes
to address my feedback are thorough and thoughtful, and unrelated
changes were of universal high-quality. (I especially enjoyed the hanoi
and chains test loads!)
Eric, security
Update #2.
All unchecked calls to the [v]s[n]printf family of string manipulation
routines have been fixed in the github pcp master branch now as well.
That area, and the __pmProcess* APIs Ken has added (and associated, on
going conversion of system/popen/... call sites) covers most, if not
all,
Update.
We've written replacements for system() and popen() that use execvp()
and do not call /bin/sh -c "some command". These are __pmProcessExec()
and __pmProcessPipe() in libpcp.
All uses of system() and popen() in the core libpcp library have been
converted to the new routines.
There are
Hi all,
I was only just made aware of this bug today, apologies for not being
involved earlier.
I'm involved with PCP upstream and Debian packaging, and I'm in the
same $TZ as Ken - I'd be quite interested in chatting about the PCP
packages in Ubuntu.
| "I'd be happy to expand my notes for an
Hi Ken/Frank,
Timezone is always challenging ;)
Can you guys provide some availabilities (2-3) for let's say next week ?
and I'll see what I can do to respect everyone's agenda.
If the timezone is too much of a challenge, do you mind if we do the
meeting with Frank ? and then we can give
On 29/08/17 10:44, Eric Desrochers wrote:
> @Dariusz, Seth, Ken, Frank and anyone else involved in this discussion.
>
> What would you guys think if we schedule a hangout call between
> Canonical & PCP upstream folks to discuss about all this ?
Sounds good to me ... we may be a little timezone
@Dariusz, Seth, Ken, Frank and anyone else involved in this discussion.
What would you guys think if we schedule a hangout call between
Canonical & PCP upstream folks to discuss about all this ?
Regards,
Eric
--
You received this bug notification because you are a member of Ubuntu
Bugs, which
Status changed to 'Confirmed' because the bug affects multiple users.
** Changed in: pcp (Ubuntu)
Status: New => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1700827
Title:
[MIR]
Hi Frank, Ken;
I'd be happy to expand my notes for an email or file bug reports for
specific items if you'd feel it would be more useful than generic
platitudes like "check all snprintf() calls for error returns", "check
sprintf() string inputs for proper lengths", "fix most of the cppcheck
** Changed in: pcp (Debian)
Status: New => Fix Released
** Changed in: pcp
Status: New => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1700827
Title:
[MIR] pcp package
Apropos the CVE's all of these have been completely addressed in past PCP
releases.
CVE-2012-5530 - fixed in PCP 3.6.10 (released 19 Nov 2012)
CVE-2012-3421, CVE-2012-3420, CVE-2012-3419 and CVE-2012-3418 - all fixed in
PCP 3.6.5 (released 16 Aug 2012)
CVE-2001-0823 - fixed in PCP 2.2.1
I reviewed pcp version 3.12.0build2 as checked into artful. This should
not be considered a full security audit but rather a quick gauge of
maintainability.
PCP has a long history of being the go-to-package for performance
monitoring, especially across a network.
There's five CVEs in our
** Changed in: pcp (Debian)
Status: Unknown => New
** Changed in: pcp
Status: Unknown => New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1700827
Title:
[MIR] pcp package
To manage
** Also affects: pcp (Debian) via
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871254
Importance: Unknown
Status: Unknown
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1700827
I have reported a Debian bug with request to include the autopkgtests.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871254
** Bug watch added: Debian Bug tracker #871254
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871254
** Also affects: pcp via
** Bug watch added: Debian Bug tracker #771793
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771793
** Bug watch added: Debian Bug tracker #805955
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=805955
** CVE added: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2001-0823
** CVE
Thanks Eric!
Brooks Warner
Sustaining Engineering Manager | Canonical
Dir: +1 480-494-9618
IRC: brookswarner
www.canonical.com | www.ubuntu.com
On Fri, Aug 4, 2017 at 6:22 AM, Eric Desrochers <
eric.desroch...@canonical.com> wrote:
> Dariusz has created some autopkgtest scripts doing
Dariusz has created some autopkgtest scripts doing invocation of some of
the cli pcp tools, ...
After a few run from Dariusz and I, both test scripts successfully
passed.
..
adt-run [09:10:04]: summary
check_daemons.py PASS
check_cli_tools.py PASS
..
Next step is to
Reported main inclusion request for the dependency (papi): bug #1704130.
** Summary changed:
- MIR -- pcp package
+ [MIR] pcp package
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1700827
Title:
Other discussions
# systemd or sysv ??
Dariusz:
Do we need to port it to systemd or are sysv script is fine?
Christian:
In general sysv is fine, but there are a few issues due using the "old" calls
e.g. if you have PCP running in a container it will collide on the Host (no
service start,
The following, must first be addressed before this package would be accepted
into main :
- tracking down upstream maintenance
- fix segfaulting binaries
- evaluating all dependencies
- base dep8 tests included
--
You received this bug notification because you are a member of Ubuntu
Bugs,
** Description changed:
[Availability]
Available:
pcp | 3.11.10 | artful/universe | source, amd64, arm64, armhf, i386,
ppc64el, s390x
[Rationale]
This is a valuable source of metrics for large deployments. There are
numerous users with large installations interested in
** Description changed:
[Availability]
Available:
pcp | 3.11.10 | artful/universe | source, amd64, arm64, armhf, i386,
ppc64el, s390x
+
[Rationale]
This is a valuable source of metrics for large deployments. There are
numerous users with large installations interested in
Action items :
- tracking down upstream maintenance
- fix segfaulting binaries
- evaluating all dependencies
- base dep8 tests included
** Tags added: sts
** Changed in: pcp (Ubuntu)
Assignee: (unassigned) => Dariusz Gadomski (dgadomski)
--
You received this bug notification because you
55 matches
Mail list logo
