[Bug 1721272] Re: [FFe] Main script should be called 'advantage'
** Tags added: sts -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1721272 Title: [FFe] Main script should be called 'advantage' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1721272/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1721272] Re: [FFe] Main script should be called 'advantage'
Ok, so I will: - revert this change we have here in the bug - make /usr/bin/ua -> /usr/bin/ubuntu-advantage - make /usr/share/man/man1/ua.1 -> /usr/share/man/man1/ubuntu-advantage.1 - change contents of ubuntu-advantage.1 to also refer to the short name "ua" - change README.md to also refer to the script as "ua" - let unit tests keep using the name ubuntu-advantage - maybe change ubuntu-advantage (the script) to use $0 instead of its name in the help output -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ubuntu-advantage-tools in Ubuntu. https://bugs.launchpad.net/bugs/1721272 Title: [FFe] Main script should be called 'advantage' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1721272/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1721272] Re: [FFe] Main script should be called 'advantage'
I also believe the window for a FFe is over and this will become a normal SRU for Artful now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1721272 Title: [FFe] Main script should be called 'advantage' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1721272/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1721272] Re: [FFe] Main script should be called 'advantage'
I also believe the window for a FFe is over and this will become a normal SRU for Artful now. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to ubuntu-advantage-tools in Ubuntu. https://bugs.launchpad.net/bugs/1721272 Title: [FFe] Main script should be called 'advantage' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1721272/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1721272] Re: [FFe] Main script should be called 'advantage'
Ok, so I will: - revert this change we have here in the bug - make /usr/bin/ua -> /usr/bin/ubuntu-advantage - make /usr/share/man/man1/ua.1 -> /usr/share/man/man1/ubuntu-advantage.1 - change contents of ubuntu-advantage.1 to also refer to the short name "ua" - change README.md to also refer to the script as "ua" - let unit tests keep using the name ubuntu-advantage - maybe change ubuntu-advantage (the script) to use $0 instead of its name in the help output -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1721272 Title: [FFe] Main script should be called 'advantage' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1721272/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1721272] Re: [FFe] Main script should be called 'advantage'
I had discussed this with Andreas on IRC, and have followed up with Dustin and Mark it person. We have an agreement to name this 'ua' instead of 'advantage' - very short names also carry some risk of collision, but arguably less so than the risk from using a common English word, and 'ua' is also the name we use generally. I believe this should be made a symlink to ubuntu-advantage, not an outright rename, and that the package name should remain unchanged. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1721272 Title: [FFe] Main script should be called 'advantage' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1721272/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1721272] Re: [FFe] Main script should be called 'advantage'
The product this refers to ( https://www.ubuntu.com/support/plans-and- pricing ) is called "Ubuntu Advantage", I'm not sure grabbing generic namespace for the tool makes sense in that context. "Run the ubuntu- advantage tool" maps nicely in brainspace with "we pay for Ubuntu Advantage", whereas "run the advantage tool" doesn't quite as well. This isn't so much me bikeshedding names and paths as it is about plain English word namespace grabs (which have bitten us repeatedly in the past) where they don't seem particularly useful (and, in this case, I'd say matching the tool to the product name sort of makes some sense). Did Mark request this in a sabdfl override capacity, or in a "pass it through the process and see how it fares" sort of way? If the latter, let's debate what's best. If the former, a comment from him to that effect will render mine moot. :P -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1721272 Title: [FFe] Main script should be called 'advantage' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1721272/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1721272] Re: [FFe] Main script should be called 'advantage'
** Summary changed:
- [FFe] Rename 'ubuntu-advantage' script to 'advantage'
+ [FFe] Main script should be called 'advantage'
** Description changed:
High level changes
==
- Mark S. requested that the main script in the package be renamed from
'ubuntu-advantage' to just 'advantage'.
+ Mark S. requested that the main script in the package be called 'advantage'.
Symlinks for the binary and its manpage are provided so that the old
- names still work.
+ 'ubuntu-advantage' name still works.
Documentation and tests were updated.
Diff
There was also a small text change in the FIPS output:
https://github.com/CanonicalLtd/ubuntu-advantage-script/commit/0e62b45c93fde61cbf6f7cdaa4c62638dac425bf
There is no i18n for this package.
Full diff of all changes on github:
https://github.com/CanonicalLtd/ubuntu-advantage-script/compare/v10...v11
The above is a more sensible view of all changes as it takes into account the
rename in a smart way, but a debdiff is also attached to this bug.
CI/Testing
==
Upstream has Travis CI in place. Link to the last run on this code:
https://travis-ci.org/CanonicalLtd/ubuntu-advantage-script/builds/283297628
To run the tests manually on artful:
- sudo apt install tox
- tar xJf ubuntu-advantage-tools_11.tar.xz
- cd ubuntu-advantage-tools-11
- sed -i 's/py35/py36/' tox.ini
- tox
Here is a run: http://pastebin.ubuntu.com/25681058/
Builds
==
Daily PPA:
https://launchpad.net/~ahasenack/+archive/ubuntu/ubuntu-advantage-tools-devel
Source build on artful with proposed enabled:
http://pastebin.ubuntu.com/25680205/
Binary build on artful with proposed enabled:
http://pastebin.ubuntu.com/25680210/
Upgrading
=
http://pastebin.ubuntu.com/25681014/ shows the upgrade from 10 to 11 and that
both names ("ubuntu-advantage" and the new "advantage") can be used.
Misc
Note that ubuntu-advantage-tools is meant for LTS releases only, but we need
it in all of them for upcoming SRU processes.
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to ubuntu-advantage-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1721272
Title:
[FFe] Main script should be called 'advantage'
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1721272/+subscriptions
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1721272] Re: [FFe] Main script should be called 'advantage'
** Summary changed:
- [FFe] Rename 'ubuntu-advantage' script to 'advantage'
+ [FFe] Main script should be called 'advantage'
** Description changed:
High level changes
==
- Mark S. requested that the main script in the package be renamed from
'ubuntu-advantage' to just 'advantage'.
+ Mark S. requested that the main script in the package be called 'advantage'.
Symlinks for the binary and its manpage are provided so that the old
- names still work.
+ 'ubuntu-advantage' name still works.
Documentation and tests were updated.
Diff
There was also a small text change in the FIPS output:
https://github.com/CanonicalLtd/ubuntu-advantage-script/commit/0e62b45c93fde61cbf6f7cdaa4c62638dac425bf
There is no i18n for this package.
Full diff of all changes on github:
https://github.com/CanonicalLtd/ubuntu-advantage-script/compare/v10...v11
The above is a more sensible view of all changes as it takes into account the
rename in a smart way, but a debdiff is also attached to this bug.
CI/Testing
==
Upstream has Travis CI in place. Link to the last run on this code:
https://travis-ci.org/CanonicalLtd/ubuntu-advantage-script/builds/283297628
To run the tests manually on artful:
- sudo apt install tox
- tar xJf ubuntu-advantage-tools_11.tar.xz
- cd ubuntu-advantage-tools-11
- sed -i 's/py35/py36/' tox.ini
- tox
Here is a run: http://pastebin.ubuntu.com/25681058/
Builds
==
Daily PPA:
https://launchpad.net/~ahasenack/+archive/ubuntu/ubuntu-advantage-tools-devel
Source build on artful with proposed enabled:
http://pastebin.ubuntu.com/25680205/
Binary build on artful with proposed enabled:
http://pastebin.ubuntu.com/25680210/
Upgrading
=
http://pastebin.ubuntu.com/25681014/ shows the upgrade from 10 to 11 and that
both names ("ubuntu-advantage" and the new "advantage") can be used.
Misc
Note that ubuntu-advantage-tools is meant for LTS releases only, but we need
it in all of them for upcoming SRU processes.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1721272
Title:
[FFe] Main script should be called 'advantage'
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1721272/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
