[Bug 1829264] Re: incorrect separator for multiple ARP IP targets
** Changed in: netplan Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829264 Title: incorrect separator for multiple ARP IP targets To manage notifications about this bug go to: https://bugs.launchpad.net/netplan/+bug/1829264/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829264] Re: incorrect separator for multiple ARP IP targets
This bug was fixed in the package netplan.io - 0.98-0ubuntu1~18.04.1 --- netplan.io (0.98-0ubuntu1~18.04.1) bionic; urgency=medium * Backport netplan.io 0.98 to 18.04. (LP: #1840832) * Keep patches specific to 18.04 support: - disable-networkd-tunnels-ipip-gre.patch: disable tests for unsupported tunnel types (ipip and gre) in the 18.04 version of systemd-networkd. * Drop debian/patches/glib_changes.patch: No longer necessary, changes were made upstream to better account for the changes in HashTable. * debian/netplan.io.install: add /usr/share/dbus-1 netplan.io (0.98-0ubuntu1) eoan; urgency=medium * New upstream release: 0.98 (LP: #1840832) - Added new "feature flags" to identify new features - Added support for "use-domains" for DHCP overrides - Added support for setting IPv6 MTU Bytes (LP: #1671951) - Added a DBus interface to query and run 'netplan apply' via other apps - Various build system fixes - Improved validation for bonding modes - Added support for "hash:" for hashed 802.1x passwords (LP: #1819831) - Tolerate devices without a /sys path (LP: #1810043) - Fix incorrect separator for networkd with ARP IP targets (LP: #1829264) * debian/control: Add Build-Depends on libsystemd-dev for DBus feature, and on dbus-x11 for dbus-launch used in tests. -- Mathieu Trudel-Lapierre Mon, 26 Aug 2019 16:36:03 -0400 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829264 Title: incorrect separator for multiple ARP IP targets To manage notifications about this bug go to: https://bugs.launchpad.net/netplan/+bug/1829264/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829264] Re: incorrect separator for multiple ARP IP targets
This bug was fixed in the package netplan.io - 0.98-0ubuntu1~19.04.1 --- netplan.io (0.98-0ubuntu1~19.04.1) disco; urgency=medium * Backport netplan.io 0.98 to 19.04. (LP: #1840832) -- Mathieu Trudel-Lapierre Mon, 26 Aug 2019 16:41:36 -0400 ** Changed in: netplan.io (Ubuntu Disco) Status: Fix Committed => Fix Released ** Changed in: netplan.io (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829264 Title: incorrect separator for multiple ARP IP targets To manage notifications about this bug go to: https://bugs.launchpad.net/netplan/+bug/1829264/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829264] Re: incorrect separator for multiple ARP IP targets
** Also affects: netplan.io (Ubuntu Disco) Importance: Undecided Status: New ** Changed in: netplan.io (Ubuntu Disco) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829264 Title: incorrect separator for multiple ARP IP targets To manage notifications about this bug go to: https://bugs.launchpad.net/netplan/+bug/1829264/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829264] Re: incorrect separator for multiple ARP IP targets
Verification-done on bionic: ubuntu@ubuntu-XPS-15-9570:~$ lsb_release -cs bionic ubuntu@ubuntu-XPS-15-9570:/sys/class/net/bond0/bonding$ dpkg -l netplan.io | grep ii ii netplan.io 0.98-0ubuntu1~18.04.1 amd64YAML network configuration abstraction for various backend ubuntu@ubuntu-XPS-15-9570:~$ cat /etc/netplan/01-network-manager-all.yaml # Let NetworkManager manage all devices on this system network: version: 2 renderer: networkd wifis: wlp59s0: access-points: cyphermox-secure: auth: [REDACTED] #dhcp4: yes bonds: bond0: interfaces: [ wlp59s0 ] dhcp4: yes parameters: arp-ip-targets: [ 10.3.0.1, 10.3.1.155 ] arp-interval: 2s mode: active-backup ubuntu@ubuntu-XPS-15-9570:~$ ip addr 1: lo: mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host valid_lft forever preferred_lft forever 2: wlp59s0: mtu 1500 qdisc noqueue master bond0 state UP group default qlen 1000 link/ether d2:52:7d:ad:79:49 brd ff:ff:ff:ff:ff:ff 4: bond0: mtu 1500 qdisc noqueue state UP group default qlen 1000 link/ether d2:52:7d:ad:79:49 brd ff:ff:ff:ff:ff:ff inet 10.3.1.244/22 brd 10.3.3.255 scope global dynamic bond0 valid_lft 14346sec preferred_lft 14346sec inet6 fe80::d052:7dff:fead:7949/64 scope link valid_lft forever preferred_lft forever ubuntu@ubuntu-XPS-15-9570:~$ cd /sys/class/net/bond0/bonding/ ubuntu@ubuntu-XPS-15-9570:/sys/class/net/bond0/bonding$ cat mode active-backup 1 ubuntu@ubuntu-XPS-15-9570:/sys/class/net/bond0/bonding$ cat arp_interval 2000 ubuntu@ubuntu-XPS-15-9570:/sys/class/net/bond0/bonding$ cat arp_ip_target 10.3.1.155 10.3.0.1 ** Tags removed: verification-needed-bionic ** Tags added: verification-done-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829264 Title: incorrect separator for multiple ARP IP targets To manage notifications about this bug go to: https://bugs.launchpad.net/netplan/+bug/1829264/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829264] Re: incorrect separator for multiple ARP IP targets
Verification-done for disco: ubuntu@oddish:~$ lsb_release -cs disco ubuntu@oddish:~$ dpkg -l netplan.io | grep ii ii netplan.io 0.98-0ubuntu1~19.04.1 amd64YAML network configuration abstraction for various backends ubuntu@oddish:~$ cat /etc/netplan/01-network-manager-all.yaml network: version: 2 renderer: networkd wifis: wlp58s0: access-points: cyphermox-secure: auth: [REDACTED\] #dhcp4: yes bonds: bond0: interfaces: [ wlp58s0 ] dhcp4: yes parameters: arp-ip-targets: [ 10.3.0.1, 10.3.1.155 ] arp-interval: 2s mode: active-backup ubuntu@oddish:~$ ip addr 1: lo: mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host valid_lft forever preferred_lft forever 2: wlp58s0: mtu 1500 qdisc mq master bond0 state UP group default qlen 1000 link/ether fa:a1:43:45:b8:0f brd ff:ff:ff:ff:ff:ff 3: bond0: mtu 1500 qdisc noqueue state UP group default qlen 1000 link/ether fa:a1:43:45:b8:0f brd ff:ff:ff:ff:ff:ff inet 10.3.1.245/22 brd 10.3.3.255 scope global dynamic bond0 valid_lft 14355sec preferred_lft 14355sec inet6 fe80::f8a1:43ff:fe45:b80f/64 scope link valid_lft forever preferred_lft forever ubuntu@oddish:~$ cd /sys/class/net/bond0/bonding/ ubuntu@oddish:/sys/class/net/bond0/bonding$ cat mode active-backup 1 ubuntu@oddish:/sys/class/net/bond0/bonding$ cat arp_interval 2000 ubuntu@oddish:/sys/class/net/bond0/bonding$ cat arp_ip_target 10.3.1.155 10.3.0.1 ** Tags removed: verification-needed ** Tags added: verification-done-disco -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829264 Title: incorrect separator for multiple ARP IP targets To manage notifications about this bug go to: https://bugs.launchpad.net/netplan/+bug/1829264/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829264] Re: incorrect separator for multiple ARP IP targets
Hello Mathieu, or anyone else affected, Accepted netplan.io into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/netplan.io/0.98-0ubuntu1~18.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: netplan.io (Ubuntu Bionic) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829264 Title: incorrect separator for multiple ARP IP targets To manage notifications about this bug go to: https://bugs.launchpad.net/netplan/+bug/1829264/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829264] Re: incorrect separator for multiple ARP IP targets
** Description changed:
+ [Impact]
+ Users of netplan who need to configure multiple values for ARP IP targets.
+
+ [Test case]
+ Write a valid configuration for a bond with multiple ARP IP targets:
+
+ network:
+ version: 2
+ renderer: networkd
+ bond:
+ bd0:
+ [...]
+ parameters:
+ arp-ip-targets: [ 192.168.3.56, 192.168.3.59 ]
+
+ Verify that the configuration is sucessfully applied, and shows up in
+ the /sys filesystem for the affected device:
+
+ /sys/class/net/bd0/bonding/arp_ip_targets
+
+ [Regression potential]
+ This affects only this particular value and generating a valid configuration
file for the networkd renderer. The existing configuration file generation is
/invalid/, but working as the bad value is ignored by systemd-networkd. This
changes the generation of the configuration file only, to write the proper
sequence of values for ARPIPTargets=.
+
+ ---
+
https://github.com/CanonicalLtd/netplan/blob/ea47bd4e1c5319b1a624ea61c843ee96e7c128da/src/networkd.c#L208
The separator used to add multiple ARP IP targets for the networkd
renderer is ",".
Unfortunately, networkd doesn't allow that, but rather expects
whitespace:
(in config_parse_arp_ip_target_address():)
[...]
- for (;;) {
- [...]
- r = extract_first_word(, , NULL, 0);
+ for (;;) {
+ [...]
+ r = extract_first_word(, , NULL, 0);
extract_first_word's third parameter is const char *separators; where
NULL is handled like so (src/basic/extract-word.c:37):
- if (!separators)
- separators = WHITESPACE;
+ if (!separators)
+ separators = WHITESPACE;
Finally:
src/basic/string-util.h:#define WHITESPACE" \t\n\r"
So; it doesn't handle commas for the list, just whitespace; so let's
give it whitespace please :)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1829264
Title:
incorrect separator for multiple ARP IP targets
To manage notifications about this bug go to:
https://bugs.launchpad.net/netplan/+bug/1829264/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829264] Re: incorrect separator for multiple ARP IP targets
This bug was fixed in the package netplan.io - 0.98-0ubuntu1 --- netplan.io (0.98-0ubuntu1) eoan; urgency=medium * New upstream release: 0.98 (LP: #1840832) - Added new "feature flags" to identify new features - Added support for "use-domains" for DHCP overrides - Added support for setting IPv6 MTU Bytes (LP: #1671951) - Added a DBus interface to query and run 'netplan apply' via other apps - Various build system fixes - Improved validation for bonding modes - Added support for "hash:" for hashed 802.1x passwords (LP: #1819831) - Tolerate devices without a /sys path (LP: #1810043) - Fix incorrect separator for networkd with ARP IP targets (LP: #1829264) * debian/control: Add Build-Depends on libsystemd-dev for DBus feature, and on dbus-x11 for dbus-launch used in tests. -- Mathieu Trudel-Lapierre Wed, 21 Aug 2019 14:49:16 -0400 ** Changed in: netplan.io (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829264 Title: incorrect separator for multiple ARP IP targets To manage notifications about this bug go to: https://bugs.launchpad.net/netplan/+bug/1829264/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829264] Re: incorrect separator for multiple ARP IP targets
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: netplan.io (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829264 Title: incorrect separator for multiple ARP IP targets To manage notifications about this bug go to: https://bugs.launchpad.net/netplan/+bug/1829264/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829264] Re: incorrect separator for multiple ARP IP targets
Looks to have a fix committed now. https://github.com/CanonicalLtd/netplan/commit/ee94ec118a8aabef8d79e78e7b2f028615a28ce8 ** Changed in: netplan Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829264 Title: incorrect separator for multiple ARP IP targets To manage notifications about this bug go to: https://bugs.launchpad.net/netplan/+bug/1829264/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
