[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-10-21 Thread Erich Eickmeyer
** Changed in: dpf-plugins Status: Fix Committed => Fix Released ** Changed in: ubuntustudio Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829562

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-07-18 Thread Łukasz Zemczak
** Changed in: ubuntu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829562 Title: [Needs Packaging] DPF-Plugins for Eoan To manage notifications about

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-07-17 Thread Erich Eickmeyer
There's really no point in building for s390x, arm64, or powerpc. These plugins are simply not created for those architectures. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829562 Title: [Needs

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-07-17 Thread Łukasz Zemczak
Thanks for all the fixes! Looking good packaging-wise I must say, but sadly the package is FTBFS on all architectures besides amd64 and i386. I suppose those two architectures make the most sense, right? In this case, should we restrict the number of build architectures to amd64 and i386 for now?

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-07-03 Thread Erich Eickmeyer
** Changed in: ubuntu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829562 Title: [Needs Packaging] DPF-Plugins for Eoan To manage notifications about

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-07-03 Thread Erich Eickmeyer
** Changed in: ubuntu Assignee: Erich Eickmeyer (eeickmeyer) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829562 Title: [Needs Packaging] DPF-Plugins for Eoan To manage

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-07-03 Thread Erich Eickmeyer
1) Looks like I missed those before, added now. 2) Fixed. 3) Thomas made a nice watch file. Forgive my ignorance, but I didn't know how (or even if) to add that. Thomas has since shown me where to find that information. ** Changed in: ubuntu Status: Incomplete => In Progress ** Changed

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-07-03 Thread Thomas Ward
Erich indicated to me they did not know how to structure the debian/watch file. I assisted them in that regard, using https://wiki.debian.org/debian/watch#GitHub as a 'starting source' as the 'source' they were pulling from is at https://github.com/DISTRHO /DPF-Plugins/ The source code in the

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-07-03 Thread Thomas Ward
I can answer the source tarball question. Tagged releases on GH are where the tar ball version numbers originate from. Source tarballs are derived from GH's automatic source code tarballing for the repo on new version tags. Horrid, I know, but... that's what I discerned when asking that

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-07-03 Thread Łukasz Zemczak
Hello Erich! Thank you for preparing the new package and thank you Thomas for sponsoring it. The package looks good, but there are still a few things I'd like to have addressed before we can accept it. 1) Copyright needs a bit more work, I suppose? So the worst thing about packages that batch up

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-26 Thread Erich Eickmeyer
** Changed in: ubuntustudio Status: In Progress => Fix Committed ** Changed in: dpf-plugins Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829562

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-26 Thread Thomas Ward
NOTE: This was fixed by Eickmeyer in the code as well as the invalid changelog target. https://git.launchpad.net/dpf- plugins/commit/?id=db45f68223a5461d2de4ebe1efdde418d76ee4fd fixes the description concerns. >From my perspective this package *looks* clean, so I'll sponsor it into NEW. It will

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-26 Thread Erich Eickmeyer
Fix for control file pushed. ** Changed in: ubuntu Status: Incomplete => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829562 Title: [Needs Packaging] DPF-Plugins for Eoan To

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-26 Thread Thomas Ward
Looks like some lines got blended togehter, the individual formats are defined in the first lines, and that ended up being missed. I blame myself for that. Digging further, I've made revisions to my assessment. dpf-plugins-common says: " Collection of DPF-based plugins in LADSPA, DSSI, LV2 and

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-26 Thread Thomas Ward
FOR THE RECORD: I've been taking my time working on this review for about a week now, so as not to overwork vs. the other work I do outside Ubuntu. Static Code Analysis Tools Results (CodeWarrior) Static code analysis of the C/C++ driven files present shows some TOCTOU risk and potential command

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-25 Thread Thomas Ward
For the record of other sponsors, I'm in the process of reviewing this (slowly) both from a general code perspective as well as a packaging perspective. This is currently assigned to me as such, during my review. ** Changed in: ubuntu Assignee: (unassigned) => Thomas Ward (teward) -- You

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-25 Thread Erich Eickmeyer
Links added to description. ** Description changed: From the project:  Collection of DPF-based audio plugins in LADSPA, DSSI, LV2 and VST2 formats.  .  The list of plugins/packs are:   - glBars   - Kars   - Mini-Series (3BandEQ, 3BandSplitter, PingPongPan)   - ndc-Plugs

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-25 Thread Simon Quigley
Please link where we can find the package and resubscribe sponsors. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829562 Title: [Needs Packaging] DPF-Plugins for Eoan To manage notifications

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-06-24 Thread Erich Eickmeyer
** Description changed: From the project: - Collection of DPF-based plugins in LADSPA, DSSI, LV2 and VST2 formats. - . - The list of plugins/packs are: - - glBars - - Kars - - Mini-Series (3BandEQ, 3BandSplitter, PingPongPan) - - ndc-Plugs (Amplitude Imposer, Cycle Shifter, Soul

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-05-30 Thread Brian Murray
*** This is an automated message *** This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs- packaging bug reports

[Bug 1829562] Re: [Needs Packaging] DPF-Plugins for Eoan

2019-05-30 Thread Erich Eickmeyer
** Also affects: ubuntu Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829562 Title: [Needs Packaging] DPF-Plugins for Eoan To manage notifications