[Bug 1005565] Re: poppler 0.20 breaks build
Launchpad has imported 8 comments from the remote bug at https://bugzilla.redhat.com/show_bug.cgi?id=822413. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2012-05-17T09:53:49+00:00 Marek wrote: Description of problem: inkscape fails when built with new poppler-0.20.0. Version-Release number of selected component (if applicable): inkscape-0.48.2-5 Additional info: This patch should fix the problem: https://projects.archlinux.org/svntogit/packages.git/tree/trunk/poppler20.patch?h=packages/inkscape Reply at: https://bugs.launchpad.net/inkscape/+bug/1005565/comments/0 On 2012-05-27T00:44:42+00:00 Sandro wrote: Created attachment 587053 Patch Patch modified to apply cleanly on top of existing fedora package patches. Reply at: https://bugs.launchpad.net/inkscape/+bug/1005565/comments/1 On 2012-06-08T10:51:29+00:00 Alex wrote: See upstream Inkscape bug: https://launchpad.net/bugs/1005565 Reply at: https://bugs.launchpad.net/inkscape/+bug/1005565/comments/4 On 2012-06-23T15:41:00+00:00 Rex wrote: 0.48.2-8 - fix icon/desktop-file scriptlets (#739375) - drop .desktop vendor (f18+) - inkscape doesn't build with poppler-0.20.0 (#822413) http://koji.fedoraproject.org/koji/taskinfo?taskID=4190484 Reply at: https://bugs.launchpad.net/inkscape/+bug/1005565/comments/11 On 2012-06-23T15:59:48+00:00 Rex wrote: boo, patch doesn't seem to work as advertised, looking closer now. Reply at: https://bugs.launchpad.net/inkscape/+bug/1005565/comments/12 On 2012-06-23T16:39:36+00:00 Rex wrote: Hrm, seems to build ok locally on my f17 x86_64 box with poppler-0.20.0-1 installed. Something odd going on. (f18 gcc/glibc differences?, missing builddep?) Reply at: https://bugs.launchpad.net/inkscape/+bug/1005565/comments/13 On 2012-06-23T18:03:11+00:00 Kevin wrote: >From the build failure, it looks like the first argument to the function "error" is being eaten somewhere, maybe something defining "error" as a macro? Reply at: https://bugs.launchpad.net/inkscape/+bug/1005565/comments/14 On 2012-06-23T19:37:29+00:00 Rex wrote: OK, the version of the patch from https://launchpad.net/bugs/1005565 works, build succeeds now. Reply at: https://bugs.launchpad.net/inkscape/+bug/1005565/comments/15 ** Changed in: inkscape (Fedora) Status: Unknown => Fix Released ** Changed in: inkscape (Fedora) Importance: Unknown => Undecided -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
** Branch linked: lp:~ubuntu-desktop/inkscape/ubuntu -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
** Changed in: inkscape (Debian) Status: Confirmed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
** Changed in: inkscape Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
** Bug watch added: Debian Bug tracker #679890 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=679890 ** Also affects: inkscape (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=679890 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
** Changed in: inkscape (Debian) Status: Unknown = Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
Trunk Build breaks with poppler-0.20.5-1 and before that on 0.20.4-1. Not confirmed: current trunk builds ok with poppler 0.20.3, 0.20.4 and 0.20.5, tested on - OS X 10.7.4 (poppler 0.20.3, 0.20.5 via MacPorts) - Ubuntu 12.10 (poppler 0.20.4) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
Marc J. Driftmeyer wrote on 2012-11-15: mdriftmeyer@horus:~/DeveloperProjects/GTKProjects/Inkscape/cmake-trunk$ If you are trying to build with 'cmake', please file a separate report (and mention 'cmake'): the official build system for Inkscape is based on Autotools (autogen.sh; configure make). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
Trunk Build breaks with poppler-0.20.5-1 and before that on 0.20.4-1. Given: poppler-0.20.5-1, poppler-data-0.4.6-1, Debian Linux In file included from /usr/include/poppler/Object.h:41:0, from /usr/include/poppler/GfxState.h:40, from /usr/include/poppler/Gfx.h:40, from /home/mdriftmeyer/DeveloperProjects/GTKProjects/Inkscape/bazaar-fork/inkscape/src/extension/internal/pdfinput/pdf-parser.cpp:35: /usr/include/poppler/Error.h:54:19: note: declared here /home/mdriftmeyer/DeveloperProjects/GTKProjects/Inkscape/bazaar-fork/inkscape/src/extension/internal/pdfinput/pdf-parser.cpp: In member function ‘void PdfParser::opImageData(Object*, int)’: /home/mdriftmeyer/DeveloperProjects/GTKProjects/Inkscape/bazaar-fork/inkscape/src/extension/internal/pdfinput/pdf-parser.cpp:3312:67: error: invalid conversion from ‘int’ to ‘ErrorCategory’ [-fpermissive] /home/mdriftmeyer/DeveloperProjects/GTKProjects/Inkscape/bazaar-fork/inkscape/src/extension/internal/pdfinput/pdf-parser.cpp:3312:67: error: invalid conversion from ‘char*’ to ‘int’ [-fpermissive] /home/mdriftmeyer/DeveloperProjects/GTKProjects/Inkscape/bazaar-fork/inkscape/src/extension/internal/pdfinput/pdf-parser.cpp:3312:67: error: too few arguments to function ‘void error(ErrorCategory, int, const char*, ...)’ In file included from /usr/include/poppler/Object.h:41:0, from /usr/include/poppler/GfxState.h:40, from /usr/include/poppler/Gfx.h:40, from /home/mdriftmeyer/DeveloperProjects/GTKProjects/Inkscape/bazaar-fork/inkscape/src/extension/internal/pdfinput/pdf-parser.cpp:35: /usr/include/poppler/Error.h:54:19: note: declared here /home/mdriftmeyer/DeveloperProjects/GTKProjects/Inkscape/bazaar-fork/inkscape/src/extension/internal/pdfinput/pdf-parser.cpp: In member function ‘void PdfParser::opEndImage(Object*, int)’: /home/mdriftmeyer/DeveloperProjects/GTKProjects/Inkscape/bazaar-fork/inkscape/src/extension/internal/pdfinput/pdf-parser.cpp:3321:67: error: invalid conversion from ‘int’ to ‘ErrorCategory’ [-fpermissive] /home/mdriftmeyer/DeveloperProjects/GTKProjects/Inkscape/bazaar-fork/inkscape/src/extension/internal/pdfinput/pdf-parser.cpp:3321:67: error: invalid conversion from ‘char*’ to ‘int’ [-fpermissive] /home/mdriftmeyer/DeveloperProjects/GTKProjects/Inkscape/bazaar-fork/inkscape/src/extension/internal/pdfinput/pdf-parser.cpp:3321:67: error: too few arguments to function ‘void error(ErrorCategory, int, const char*, ...)’ In file included from /usr/include/poppler/Object.h:41:0, from /usr/include/poppler/GfxState.h:40, from /usr/include/poppler/Gfx.h:40, from /home/mdriftmeyer/DeveloperProjects/GTKProjects/Inkscape/bazaar-fork/inkscape/src/extension/internal/pdfinput/pdf-parser.cpp:35: /usr/include/poppler/Error.h:54:19: note: declared here make[2]: *** [src/CMakeFiles/inkscape_LIB.dir/extension/internal/pdfinput/pdf-parser.cpp.o] Error 1 make[1]: *** [src/CMakeFiles/inkscape_LIB.dir/all] Error 2 make: *** [all] Error 2 mdriftmeyer@horus:~/DeveloperProjects/GTKProjects/Inkscape/cmake-trunk$ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
Apparently the changes were introduced in Poppler 0.18 (at least it doesn't compile on Crunchbang 11, based on Debian Wheezy, Poppler 0.18.4-3). Current trunk compiles fine for me both with poppler 0.18.4 and with poppler 2.20.3 (no poppler-specific local changes to configure.ac) on OS X 10.7.4 (dependencies installed in separate MacPorts trees). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
Apparently the changes were introduced in Poppler 0.18 (at least it doesn't compile on Crunchbang 11, based on Debian Wheezy, Poppler 0.18.4-3). I'm going to try with a modified configure.ac with a test on 0.18.0 instead of 0.20.0. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
Backported to 0.48.x branch, commit 9905. ** Changed in: inkscape Milestone: 0.49 = 0.48.4 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
** Tags removed: backport-proposed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
Fixed in bzr revision 11518. ** Changed in: inkscape Status: Triaged = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
Since another bug-fix release (0.48.4) is planned, this needs to be backported to the 0.48.x branch AFAIU. ** Changed in: inkscape Status: Fix Released = Fix Committed ** Changed in: inkscape Milestone: None = 0.49 ** Tags added: backport-proposed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
@declara91 I still hate having 3 build mechanisms, but I'm patching cmake and btool too right now, for the sake of completeness @suv-lp looking at http://cgit.freedesktop.org/poppler/poppler/commit/?id=c0affb1845c339f89ca67608cb9fd9134ff902f5 and speaking with poppler devs, those two should have been redundant with different visibility. It's working for me, but we can re-enable if any regression is seen. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
As we're using older poppler libs on various architecture (prominently 0.12 in windows devlibs), I'd suggest going for conditional building instead. The attached patch works both with newer and older poppler version, and it's up for review. If no objections received, I'm going to commit this to trunk in a couple of days. ** Changed in: inkscape Assignee: (unassigned) = Luca Bruno (lucab) ** Patch added: Conditional patch for poppler 0.20 https://bugs.launchpad.net/inkscape/+bug/1005565/+attachment/3189216/+files/poppler-0.20.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
Luca, Patch works on Quantal. I was working on very similar patch and you beat me to adding the or for the color space stuff (my build was still failing at that point). :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
Luca, as far as I understand your patch targets only autotools. What about CMake? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
Luca Bruno wrote: As we're using older poppler libs on various architecture (prominently 0.12 in windows devlibs), I'd suggest going for conditional building instead. The attached patch works both with newer and older poppler version, and it's up for review. If no objections received, I'm going to commit this to trunk in a couple of days. The changes to 'src/extension/internal/pdfinput/svg-builder.cpp' are not conditional - are there any test cases around to confirm that switching from 'getOrigName()' to 'getName()' has no adverse side-effects with older poppler versions? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
This bug was fixed in the package inkscape - 0.48.3.1-1ubuntu2 --- inkscape (0.48.3.1-1ubuntu2) quantal; urgency=low * Follow ABI changes for libpoppler25 (poppler 0.20.0-0ubuntu1). (LP: #1005565) -- Andy Whitcroft a...@canonical.com Mon, 11 Jun 2012 19:22:46 +0100 ** Changed in: inkscape (Ubuntu) Status: In Progress = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
** Branch linked: lp:ubuntu/inkscape -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1005565] Re: poppler 0.20 breaks build
** Also affects: inkscape (Ubuntu) Importance: Undecided Status: New ** Changed in: inkscape (Ubuntu) Status: New = In Progress ** Changed in: inkscape (Ubuntu) Importance: Undecided = High ** Changed in: inkscape (Ubuntu) Assignee: (unassigned) = Andy Whitcroft (apw) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1005565 Title: poppler 0.20 breaks build To manage notifications about this bug go to: https://bugs.launchpad.net/inkscape/+bug/1005565/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
