[Bug 1084403] Re: no support for gpgsig tags

** Project changed: brz-git => brz ** Changed in: brz Milestone: integration => None ** Changed in: brz Milestone: None => 3.0.0 ** Summary changed: - no support for gpgsig tags + git: no support for gpgsig tags -- You received this bug notification because you are a member of Ubuntu

[Bug 1084403] Re: no support for gpgsig tags

** Changed in: brz-git Milestone: None => integration -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about this bug go to:

[Bug 1084403] Re: no support for gpgsig tags

brz-git can now import and preserve signatures (but won't create them on git commits you create from within breezy). ** Changed in: brz-git Status: Triaged => Fix Released ** Changed in: brz-git Assignee: (unassigned) => Jelmer Vernooij (jelmer) -- You received this bug

[Bug 1084403] Re: no support for gpgsig tags

Same error while trying to import GitHub repo -- https://github.com/voria/samsung-tools The latest commit is marked as "Verified" by GitHub and import fails. https://code.launchpad.net/~voria/samsung-tools/master http://launchpadlibrarian.net/351369453/voria-samsung-tools-master.log -- You

[Bug 1084403] Re: no support for gpgsig tags

** Branch unlinked: lp:~linuxgndu/sqlitebrowser-recipe/master -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about this bug go to:

[Bug 1084403] Re: no support for gpgsig tags

** Branch linked: lp:~linuxgndu/sqlitebrowser-recipe/master -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about this bug go to:

[Bug 1084403] Re: no support for gpgsig tags

** Also affects: brz-git Importance: Undecided Status: New ** Changed in: brz-git Status: New => Triaged ** Changed in: brz-git Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1084403] Re: no support for gpgsig tags

Awesome! Many thanks, Colin! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about this bug go to:

[Bug 1084403] Re: no support for gpgsig tags

Thomas: I implemented that a while back (bug 1537579), but just forgot to update the documentation. I've done the latter as well now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title:

[Bug 1084403] Re: no support for gpgsig tags

Great news! Is there also a issue report here on Launchpad for the nest- part implementation for git recipes? Would like to get notified when it's there. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1084403] Re: no support for gpgsig tags

Launchpad git-to-git imports are available now: http://blog.launchpad.net/code/git-to-git-imports -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage

[Bug 1084403] Re: no support for gpgsig tags

lp:emacs is bit by this bug since April 2016. I'm eagerly awaiting those git-to-git imports ;-) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage

[Bug 1084403] Re: no support for gpgsig tags

John, it has nothing to do with whether you're importing from GitHub; it depends on whether the repository's history contains commits with gpgsig tags. Our plan for this remains as I outlined in comment 24, although some other urgent bits of work have jumped the queue and delayed us implementing

[Bug 1084403] Re: no support for gpgsig tags

Adding a note to mention that this bug makes is quite difficult to use the PPA with Github repositories. I wanted to try to build my own .deb for Jabref, so I started by trying to import the code from the Jabref github pages. Here is where I got to:

Re: [Bug 1084403] Re: no support for gpgsig tags

On Tue, Jul 19, 2016 at 05:56:28PM -, Rob Loach wrote: > Thanks for taking a look, Jelmer. Do you have an idea of a way forward > with it? William mentioned he was unsure of how to do it properly. They are the equivalent of testaments, so ideally they should be converted to those. I don't

[Bug 1084403] Re: no support for gpgsig tags

Thanks for taking a look, Jelmer. Do you have an idea of a way forward with it? William mentioned he was unsure of how to do it properly. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title:

Re: [Bug 1084403] Re: no support for gpgsig tags

Ignoring it will cause confusing import errors in incremental pulls for Launchpad imports as well. Incremental pulls rely on deltas against full texts recreated from bzr data including PGP signatures. If even one byte in the full text is incorrect, that causes incremental pulls to fail. On 19

[Bug 1084403] Re: no support for gpgsig tags

The attachment "bzr-git--gpg.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by

[Bug 1084403] Re: no support for gpgsig tags

** Patch added: "bzr-git--gpg.diff" https://bugs.launchpad.net/ubuntu/+source/bzr-git/+bug/1084403/+attachment/4703129/+files/bzr-git--gpg.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1084403] Re: no support for gpgsig tags

Built ontop of wgrant's feedback, a new patch: http://files.robloach.net/bzr-git--gpg.diff While I understand the best way around this would be to implement the GPG signatures in bzr, but this is affecting many projects brought into Launchpad through bzr-git. Ignoring it may be the best option

[Bug 1084403] Re: no support for gpgsig tags

This also has affected libretro-snes9x: http://launchpadlibrarian.net/272633750/libretro-libretro-snes9x-libretro.log bzrlib.plugins.git.errors.UnknownCommitExtra: Unknown extra fields in : ['gpgsig']. https://github.com/libretro/snes9x/issues/22 ** Bug watch added:

[Bug 1084403] Re: no support for gpgsig tags

This is not a "trivial bug", which papercuts seems to be about. ** Changed in: hundredpapercuts Status: Confirmed => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no

[Bug 1084403] Re: no support for gpgsig tags

** Also affects: hundredpapercuts Importance: Undecided Status: New ** Changed in: hundredpapercuts Status: New => Confirmed ** Changed in: pymor Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1084403] Re: no support for gpgsig tags

That patch won't do anything because you included the new check inside the "if commit is not None" block, which is an assertion that is meant to never fail. Even if it was in the right place, however, it would try to raise None as an exception and crash. If you fixed that, it would do as Jelmer

[Bug 1084403] Re: no support for gpgsig tags

I deleted the whole repo before re-import, so that should not be the problem. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about

Re: [Bug 1084403] Re: no support for gpgsig tags

The cache could also be under the bzr repository somewhere. On 16 June 2016 19:06:43 BST, Qwerty Chouskie wrote: >I checked ~/.cache, but there was nothing bzr-related there. I also >checked ~/.bazzar/, but there was nothing cache-related there. -- Sent from my

[Bug 1084403] Re: no support for gpgsig tags

I checked ~/.cache, but there was nothing bzr-related there. I also checked ~/.bazzar/, but there was nothing cache-related there. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no

Re: [Bug 1084403] Re: no support for gpgsig tags

It depends on your system. Usually $XDG_CACHE_HOME/bazaar/git I think. On 16 June 2016 17:50:44 BST, Qwerty Chouskie wrote: >Where is the cache? -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- You received this bug notification because

[Bug 1084403] Re: no support for gpgsig tags

Where is the cache? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about this bug go to:

Re: [Bug 1084403] Re: no support for gpgsig tags

Are you fetching into a new repository and have you removed the bzr-git cache? On 15 June 2016 01:24:10 BST, Qwerty Chouskie wrote: >I made this patch: >http://jacobspctuneup.tk/bzr-git%20patches/patchtry1.txt >It looks good, but nothing actually appears in the

[Bug 1084403] Re: no support for gpgsig tags

I made this patch: http://jacobspctuneup.tk/bzr-git%20patches/patchtry1.txt It looks good, but nothing actually appears in the terminal or "~/.bzr.log". Maybe it only shows up if there is an error? -- You received this bug notification because you are a member of Ubuntu Bugs, which is

Re: [Bug 1084403] Re: no support for gpgsig tags

It will break deltas, as bzr-git won't be able to create the original git object anymore from the bzr data. The object it creates will lack the gpgsig tag and thus result in a checksum mismatch. On 13 June 2016 21:29:38 BST, Qwerty Chouskie wrote: >I saw comment #8,

[Bug 1084403] Re: no support for gpgsig tags

I tried: === modified file 'mapping.py' --- mapping.py 2013-09-02 00:54:58 + +++ mapping.py 2016-06-13 04:07:10 + @@ -333,7 +333,11 @@ if commit is None: raise AssertionError("Commit object can't be None") if commit.extra: -raise

Re: [Bug 1084403] Re: no support for gpgsig tags

It will make things worse. People will get confusing errors (sha1 checksum or delta invalid exceptions), and bzr-git loses the ability to properly support the gpgsig tag. On 13 June 2016 22:16:19 BST, Qwerty Chouskie wrote: >Also, the code change will defiantly not

[Bug 1084403] Re: no support for gpgsig tags

Our direction for this in Launchpad is to get git-to-git imports working (hopefully soonish), and then you can just use git-based recipes instead. This will be much simpler and more robust against all kinds of strangenesses in git repositories; for example, a fix for gpgsig is no help for the

[Bug 1084403] Re: no support for gpgsig tags

Also, the code change will defiantly not make anything worse, and might make things better, so it would make sense to merge it as a temporary fix... And, I tested the first section of the diff

[Bug 1084403] Re: no support for gpgsig tags

I saw comment #8, but it does not seem like ignoring gpgsig tags should break deltas, as the code changes in the commits are the same... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title:

Re: [Bug 1084403] Re: no support for gpgsig tags

That fix is incomplete and possibly corrupts future pulls. See the bug report for an explanation. On 13 June 2016 03:45:52 BST, Qwerty Chouskie wrote: >Just found this patched version: >https://code.launchpad.net/~simon-marchi/bzr-git/devel >Could this get merged

[Bug 1084403] Re: no support for gpgsig tags

Just found this patched version: https://code.launchpad.net/~simon-marchi/bzr-git/devel Could this get merged please? This bug breaks SuperTuxKart daily builds, see https://github.com/supertuxkart/stk-code/issues/1415 towards end. -- You received this bug notification because you are a member

[Bug 1084403] Re: no support for gpgsig tags

** Also affects: pymor Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about this bug go

[Bug 1084403] Re: no support for gpgsig tags

Major git hosting service GitHub has just announced support for verifying signed git commits and tags [1]. Just noting, as this will most probably increase the usage of signed git commits. [1] : https://github.com/blog/2144-gpg-signature-verification -- You received this bug notification

[Bug 1084403] Re: no support for gpgsig tags

I do not want to add another example, because there are already too many. Just FYI, Debian is discussing right now the defaulting of gpg signed commits, so I guess this bug will be more and more important from now. -- You received this bug notification because you are a member of Ubuntu Bugs,

Re: [Bug 1084403] Re: no support for gpgsig tags

Thanks for the replies. At this point the issue is well documented; please don't add more examples of broken repositories. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support

[Bug 1084403] Re: no support for gpgsig tags

I'm unable to import openstack/tempest because of this -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about this bug go to:

[Bug 1084403] Re: no support for gpgsig tags

This is now preventing me from importing the matplotlib codebase to do nightly builds: https://code.launchpad.net/~takluyver/matplotlib/trunk -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403

[Bug 1084403] Re: no support for gpgsig tags

Just ran into this issue a few days ago when a project I contribute to failed to sync because of a gpg signed commit: You can find the log from launchpad in the attachment as well as in the following pastebin: http://paste.ubuntu.com/6788623/ ** Attachment added: log_from_launchpad.log

[Bug 1084403] Re: no support for gpgsig tags

** Changed in: dulwich Status: New = Triaged ** Changed in: dulwich Importance: Undecided = High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags

[Bug 1084403] Re: no support for gpgsig tags

See bug 1251682 for the relevant dulwich bug. ** No longer affects: dulwich -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about

[Bug 1084403] Re: no support for gpgsig tags

** Also affects: dulwich Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about this bug

[Bug 1084403] Re: no support for gpgsig tags

** Branch linked: lp:~hloeung/ubuntu/precise/dulwich/gpgsig -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about this bug go to:

[Bug 1084403] Re: no support for gpgsig tags

** Branch unlinked: lp:~hloeung/ubuntu/precise/dulwich/gpgsig -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about this bug go to:

[Bug 1084403] Re: no support for gpgsig tags

same problem here: https://code.launchpad.net/~thopiekar/emgd/x11proto- core -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about

[Bug 1084403] Re: no support for gpgsig tags

Is there a way that can work around this bug and set up auto-import for a git repository that has some historical commits contain gpgsig? It seems that I'm not able to push to the branch set up by vcs-import, so fast-export/fast-import does not work for this use case. -- You received this bug

Re: [Bug 1084403] Re: no support for gpgsig tags

On Tue, Nov 12, 2013 at 06:55:17PM -, Aron Xu wrote: Is there a way that can work around this bug and set up auto-import for a git repository that has some historical commits contain gpgsig? It seems that I'm not able to push to the branch set up by vcs-import, so fast-export/fast-import

[Bug 1084403] Re: no support for gpgsig tags

Making this non-fatal (on launchpad) would be rather helpful since as of a couple of days ago this is blocking KDE Frameworks 5 building [1]. Upstream is less than thrilled. [1] https://code.launchpad.net/~neon/kde-workspace/master ** Attachment added: raw commit data of affected commit in

Re: [Bug 1084403] Re: no support for gpgsig tags

On Sun, Nov 03, 2013 at 10:07:36AM -, Harald Sitter wrote: Making this non-fatal (on launchpad) would be rather helpful since as of a couple of days ago this is blocking KDE Frameworks 5 building [1]. Upstream is less than thrilled. [1]

[Bug 1084403] Re: no support for gpgsig tags

More practically speaking, I think the most achievable solution is probably to run a manual fast-export/fast-import import. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support

[Bug 1084403] Re: no support for gpgsig tags

** Changed in: bzr-git Status: Triaged = In Progress ** Changed in: launchpad Status: Triaged = Fix Committed ** Changed in: bzr-git (Ubuntu) Status: Triaged = Fix Released ** Changed in: bzr-git Status: In Progress = Fix Committed -- You received this bug

[Bug 1084403] Re: no support for gpgsig tags

Hi Artur, Please stop marking these bugs as fixed - they're not. (I reverted the Launchpad bug state to New, since I can't set it to Triaged anymore) Jelmer ** Changed in: bzr-git (Ubuntu) Status: Fix Released = Triaged ** Changed in: launchpad Status: Fix Committed = In

[Bug 1084403] Re: no support for gpgsig tags

** Changed in: launchpad Status: New = Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig tags To manage notifications about this bug go to:

[Bug 1084403] Re: no support for gpgsig tags

** Also affects: launchpad Importance: Undecided Status: New ** Changed in: launchpad Status: New = Triaged ** Changed in: launchpad Importance: Undecided = High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1084403] Re: no support for gpgsig tags

** Changed in: bzr-git Status: Triaged = Fix Committed ** Changed in: bzr-git (Ubuntu) Status: Triaged = Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no

[Bug 1084403] Re: no support for gpgsig tags

** Changed in: bzr-git (Ubuntu) Status: Fix Committed = Triaged ** Changed in: bzr-git Status: Fix Committed = Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no

[Bug 1084403] Re: no support for gpgsig tags

Don't let me block you from working on it ☺. FWIW I don't think bzr-git is actively maintained at the moment. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1084403 Title: no support for gpgsig

[Bug 1084403] Re: no support for gpgsig tags

** Summary changed: - bzr-git fails to check out xorg server: mishandles gpg-signed tags + no support for gpgsig tags ** Also affects: bzr-git Importance: Undecided Status: New ** Changed in: bzr-git Status: New = Triaged ** Changed in: bzr-git Importance: Undecided = High

[Bug 1084403] Re: no support for gpgsig tags

Do you have an estimate of the complexity of fixing this? It's semi- blocking something that I need to work on, so if it's likely to be doable by someone with no prior bzr-git experience I'd be able to hack on it. -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1084403] Re: no support for gpgsig tags

Basically what needs to happen is: * in dulwich, extend Commit to serialize and deserialize gpgsig data (in dulwich/objects.py) * in bzr-git: - have all old mappings raise an exception if a gpgsigs are encountered (mapping.py) - have new mapping convert gpg data into a bzr revision

Re: [Bug 1084403] Re: no support for gpgsig tags

Hm. Given I'm familiar with neither the bzr nor the git internals, that might be a bit longer for me then. Don't let me block you from working on it ☺. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.