[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-08-01 Thread Martin Pitt
Fixed in bzr head.

** Changed in: restricted-manager (Ubuntu)
   Status: Confirmed = Fix Committed

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-08-01 Thread Martin Pitt
restricted-manager (0.24) gutsy; urgency=low

  [ Matteo Zandi ]
  * RestrictedManager/lrm_driver.py: load_lrmc_disabled() and
save_lrmc_disabled() now handle trailing spaces in
/etc/default/linux-restricted-modules-common. (LP: #122359)
  * RestrictedManager/bcm43xx.py: remove fake firmware file when
disabling bcm43xx.
  * restricted-manager: Added new class DefaultHandlerMessageDialog that can be
used to give messages from handlers.

  [ Martin Pitt ]
  * debian/restricted-manager.postinst: Do not call addgroup if the admin
group already exists. In some corner cases, addgroup fails at this
condidion. (LP: #122892)
  * Add man/restricted-manager.8: man page for r-m, thanks to Cesare
Tirabassi! (LP: #128697)
  * restricted-manager: Check for l-r-m-generic package instead of the kernel
ABI specific one. (LP: #107705)
  * debian/control: Add dependency to l-r-m-{generic,i386} on i386/amd64, since
r-m does not work without it anyway and it just creates confusion.
  * RestrictedManager/bcm43xx.py: Check if bcm43xx-fwcutter could actually get
installed before proceeding.
  * RestrictedManager/core.py, install_package(): Check that package is
actually available; if not, point out that the software source for this
needs to be enabled. Based on original patch of Matteo, but simplified and
robustified. (LP: #123061, LP: #124304)

 -- Martin Pitt [EMAIL PROTECTED]   Wed, 01 Aug 2007 12:20:55
+0200

** Changed in: restricted-manager (Ubuntu)
   Status: Fix Committed = Fix Released

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-07-26 Thread Roland Arendes
The manager works instantly if you add

DISABLED_MODULES=

directly under the last comment (in case you have a /etc/default/linux-
restricted-modules-common without that line activated).

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-07-25 Thread Roland Arendes
My /etc/default/linux-restricted-modules-common consists only of
comments (read: NO line which does not start with a #) and the
restricted-manager crashes anyway.

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-07-15 Thread Matthew Koyle
I had this same problem... used envy a few weeks ago and just updated to
gutsy.

Deleting the four spaces before DISABLED_MODULES= fixed it for me,
too.

[EMAIL PROTECTED]:~$ sudo restricted-manager 
Traceback (most recent call last):
  File /usr/bin/restricted-manager, line 646, in module
sys.exit(main(args, opts))
  File /usr/bin/restricted-manager, line 602, in main
handlers = get_handlers()
  File /usr/lib/python2.5/site-packages/RestrictedManager/core.py, line 452, 
in get_handlers
specials = get_specials()
  File /usr/lib/python2.5/site-packages/RestrictedManager/core.py, line 411, 
in get_specials
rm = __import__(RestrictedManager.%s % name)
  File /usr/lib/python2.5/site-packages/RestrictedManager/lrm_driver.py, line 
140, in module
LRMDriverHandler.load_lrmc_disabled()
  File /usr/lib/python2.5/site-packages/RestrictedManager/lrm_driver.py, line 
86, in load_lrmc_disabled
if len(modules):
UnboundLocalError: local variable 'modules' referenced before assignment

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-06-30 Thread kavs
my /etc/default/linux-restricted-modules-common

** Attachment added: linux-restricted-modules-common
   http://launchpadlibrarian.net/8266486/linux-restricted-modules-common

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-06-28 Thread joe
This patch should solve the Problem

Ok the source should be checked for situations where variables are first 
assigned in a try: / except: block and the ether that variable is assigned in 
the except block also or initialized before the try: statement
to prevent more of such errors.

** Attachment added: Patch whiche solves the unbound variable Problem
   http://launchpadlibrarian.net/8220959/lrm_unbound_variable.patch

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-06-28 Thread Matteo Zandi
It seems that you have a non-standard /etc/default/linux-restricted-
modules-common

Can you post it?

** Changed in: restricted-manager (Ubuntu)
 Assignee: (unassigned) = Matteo Zandi

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-06-28 Thread joe
Here it is, but none the less this errer could be fixed for others which
also have a possibly non standard file. Version is 2.6.22.2-7.2

# This file is sourced from the linux-restricted-modules-common init
# script and is used to disable the link-on-boot feature, one module
# at a time.  This can be useful if you want to use hand-compiled
# versions of one or more modules, but keep linux-restricted-modules
# installed on your system, or just to disable modules you don't use
# and speed up your boot process by a second or two.
#
# Use a space-separated list of modules you wish to not have linked
# on boot.  The following example shows a (condensed) list of all
# modules shipped in the linux-restricted-modules packages:
#
# DISABLED_MODULES=ath_hal fc fglrx ltm nv
#
# Note that disabling fc disables all fcdsl drivers, ltm disables
# ltmodem and ltserial, and nv disables both the nvidia drivers.
# You can also name each module individually, if you prefer a subset.

DISABLED_MODULES=

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-06-28 Thread Matteo Zandi
 but none the less this errer could be fixed for others which also have
a possibly non standard file

yes, that's what we want :)

I just wanted to see if there were some particular unhandled cases, do
you have 4 spaces before 'DISABLED_MODULES='?

load_lrmc_disabled() should behave live sh, since /etc/default/linux-
restricted-modules-common is sourced by a sh script. If we use your
patch, we won't behave like sh and, in fact, r-m will be confused by
those spaces.

If you have something like 'DISABLED_MODULES=fglrx (4 spaces
before DIS..), Restricted-manager will think that no modules are
disabled altough fglrx is.

We should clear spaces at the beginning of the DIS.. line.

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-06-28 Thread joe
hmmm exactly 4 spaces. the question is:
 if it is due to some error in lrm or if it is caused by   envy which I used 
before  

so did someone use envy before lrm crashed??

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-06-27 Thread joe
Patch is to add the variable modules=[] just before the block where
modules is figured out

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-06-27 Thread joe
** Changed in: restricted-manager (Ubuntu)
   Status: New = Confirmed

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-06-27 Thread Zenigata
same thing here, since I updated to gutsy restricted-manager do not
load.

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-06-26 Thread Kaarel

** Attachment added: Dependencies.txt
   http://launchpadlibrarian.net/8210474/Dependencies.txt

** Attachment added: Devices.txt
   http://launchpadlibrarian.net/8210475/Devices.txt

** Attachment added: ProcMaps.txt
   http://launchpadlibrarian.net/8210476/ProcMaps.txt

** Attachment added: ProcStatus.txt
   http://launchpadlibrarian.net/8210477/ProcStatus.txt

** Attachment added: Traceback.txt
   http://launchpadlibrarian.net/8210478/Traceback.txt

** Attachment added: XorgConf.txt
   http://launchpadlibrarian.net/8210479/XorgConf.txt

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 122359] Re: restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()

2007-06-26 Thread Apport retracing service
** Tags removed: need-duplicate-check

-- 
restricted-manager crashed with UnboundLocalError in load_lrmc_disabled()
https://bugs.launchpad.net/bugs/122359
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs