** Changed in: unzip (Debian)
Status: Confirmed = Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/135086
Title:
zipgrep: exit code always 0
To manage notifications about this bug
Fixed in Hardy.
** Changed in: unzip (Ubuntu)
Status: Fix Committed = Fix Released
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.
--
ubuntu-bugs
Sorry, but this is not appropriate for an SRU. It's neither a critical
bug nor a regression from a previous release (feisty's zipgrep behaved
the same).
Admittedly it is a bug, but we should not change the behaviour of tools
which are likely used in custom scripts within a stable release. People
I can upload it to gutsy-proposed but that seems to be more reserved for
bugs with large impact.
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.
--
ubuntu-bugs
** Attachment added: unzip_5.52-10ubuntu1.1.debdiff
http://launchpadlibrarian.net/10769731/unzip_5.52-10ubuntu1.1.debdiff
** Description changed:
Binary package hint: unzip
For example, the -q option becomes worthless when the found status is
not reflected in the exit code from
Chris, Brandon? What do we do about Gutsy? I'm not sure it's as super-
ultra-urgent as StableReleaseUpdates demands.
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for
** Changed in: unzip (Ubuntu)
Assignee: (unassigned) = Brandon Holtsclaw (imbrandon)
Status: Triaged = In Progress
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug
Fix uploaded to Hardy with one small change , Bash is Priority:Required
( user accounts default to a bash shell ) so it was removed from the
depends
will look at the viability for a gutsy SRU now
** Changed in: unzip (Ubuntu)
Status: In Progress = Fix Committed
--
zipgrep: exit code
I changed zipgrep to use /usr/bin/bash as era pointed out to me. I
didn't change the Depends field because bash has priority required, as
far as i understand, that means it will be installed on every system? If
this is ok, could you resubscribe ubuntu-main-sponsors era?
** Attachment added:
Me? I guess that would be Daniel's task; I have no idea what the
criteria for resubscribing should be (but this would seem okay to me).
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is the
ubuntu-minimal Depends on it. I think bash can be safely removed. I
think a Depends is in order, although I'm not 100% sure.
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact
Ok this patch version add bash to the depends field
** Attachment added: unzip_5.52-10ubuntu2.debdiff
http://launchpadlibrarian.net/9892706/unzip_5.52-10ubuntu2.debdiff
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a
... So to reiterate, for the PIPESTATUS thing to fly you'd have to do
--- debian/control
-Depends: whatever
+Depends: whatever, bash
and
--- zipgrep
-#!/bin/sh
+#!/usr/bin/bash
Like I wrote before, not sure about the Depends: change, as Bash may
still be Priority: essential or whatever it is
Unsubscribing ubuntu-main-sponsors until patch is ready.
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.
--
ubuntu-bugs mailing list
Just a quick note that I'm still working on it. However, my conclusion
is that the overall design is flawed, and that the PIPESTATUS hack is
probably the way to go for Ubuntu. I'll see about convincing upstream
to take my full reimplementation ... If anybody can shed light on how to
get the
** Changed in: unzip (Ubuntu)
Assignee: Chris Cheney (ccheney) = (unassigned)
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.
--
ubuntu-bugs mailing list
era, you are right, i have tested with dash, and it is a bashism :-(
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.
--
ubuntu-bugs mailing list
Duh, my gifted refactored script doesn't understand the -q option any
better than the original! I'm working on the option processing after
all, I'll just write some test cases for myself. Poke me if I don't
remember to submit it here within a week or so.
--
zipgrep: exit code always 0
Cringe, that script could definitely use some heavy refactoring.
Attached please find an attempt to rewrite the main loop. Somebody
should probably take the time to fix the option processing too. There is
some heavy refactoring in there, in order to make the main loop small
and neat. It's not
Have you tested this with /bin/dash? I believe PIPESTATUS is a Bashism
so you would have to update the shebang line to read #!/usr/bin/bash if
I'm not mistaken (and declare a dependency on Bash? Not sure, just a
quick shot from the hip really ...)
--
zipgrep: exit code always 0
** Changed in: unzip (Debian)
Status: New = Confirmed
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.
--
ubuntu-bugs mailing list
** Changed in: unzip (Debian)
Status: Unknown = New
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.
--
ubuntu-bugs mailing list
Chris, can you take a look at this one?
Niklas: do you think you can forward the patch upstream?
** Changed in: unzip (Ubuntu)
Assignee: (unassigned) = Chris Cheney
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a
I have forwarded the bug to debian http://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=441997 and send a bugreport to info-zip.org
** Bug watch added: Debian Bug tracker #441997
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=441997
** Also affects: unzip (Debian) via
One other minor thing is that lines in debian/changelog should not go
over 80 characters. Please update the debdiff again. Thanks for
working on this. These details get easier with practice. Also, althogh
your debian/changelog reference to the bug would work, the preferred
form is (LP:
Thanks for your advise Scott. I changed this in the changelog.
** Attachment added: unzip_5.52-10ubuntu2.debdiff
http://launchpadlibrarian.net/9202484/unzip_5.52-10ubuntu2.debdiff
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because
** Changed in: unzip (Ubuntu)
Assignee: Niklas Klein = Scott Kitterman
Status: Triaged = In Progress
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for Ubuntu.
unzip is in Main, not Universe. Subscribing Ubuntu Main Sponsors.
** Changed in: unzip (Ubuntu)
Assignee: Scott Kitterman = (unassigned)
Status: In Progress = Triaged
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because
Sorry this is the first time i am patching a package. I just learned how
to refer to bugs in lunchpad from the changelog. Therefor i updated my
debdiff to a hopefully better formulation in the changelog.
** Attachment added: unzip_5.52-10ubuntu2.debdiff
Hello Ian: could you please review the change and upload if it's ok?
** Changed in: unzip (Ubuntu)
Assignee: (unassigned) = Ian Jackson
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is
** Attachment added: unzip_5.52-9ubuntu4.debdiff
http://launchpadlibrarian.net/9096845/unzip_5.52-9ubuntu4.debdiff
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this bug notification because you are a member of Ubuntu
Bugs, which is the bug contact for
sorry the other/older debdiff was for feisty. this one is for the latest
gutsy source
** Attachment added: unzip_5.52-10ubuntu2.debdiff
http://launchpadlibrarian.net/9097155/unzip_5.52-10ubuntu2.debdiff
--
zipgrep: exit code always 0
https://bugs.launchpad.net/bugs/135086
You received this
The problem is, that the zipgrep script uses a pipe: unzip -p-L $zipfile
$i | egrep $opt $pat | sed s|^|${i}:|
and than save the exit code with r=$?, which is the exit code of sed not of
egrep. I have d patch to replace r=$? with r=${PIPESTATUS[1]}. It works for me
** Attachment added: fix for
33 matches
Mail list logo
