[Bug 1446499] Re: Updating scope from store removes it from favorites
This bug was fixed in the package unity-scopes-shell - 0.5.4+15.10.20150707-0ubuntu1 --- unity-scopes-shell (0.5.4+15.10.20150707-0ubuntu1) wily; urgency=medium [ CI Train Bot ] * Resync trunk. [ Marcus Tomlinson ] * Clean out redundant pkg_check_modules calls in multiple CMakeLists.txt files [ Pawel Stolowski ] * Cherry-picked the workaround for delayed processing of scoperegistry changes from RTM. (LP: #1446499) * Fix for test failure caused by changes in jsoncpp formatting of floats. Use regular expressions to matched error strings when testing for expected failures. -- CI Train Bot ci-train-...@canonical.com Tue, 07 Jul 2015 04:20:10 + ** Changed in: unity-scopes-shell (Ubuntu) Status: Invalid = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
This bug was fixed in the package unity-scopes-api 0.6.18+15.04.20150609.1-0ubuntu1 in https://launchpad.net/~ci-train-ppa- service/+archive/ubuntu/stable-phone-overlay --- unity-scopes-api (0.6.18+15.04.20150609.1-0ubuntu1) vivid; urgency=medium [ Marcus Tomlinson ] * Allow child_scopes() and set_child_scopes() methods more time to execute as they read from and write to disk. * Added ChildScopes.Timeout configuration parameter to Zmq.ini [ Pawel Stolowski ] * Added API for activation of in-card result actions. [ CI Train Bot ] * debian/libunity-scopes3.symbols: update to released version. * New rebuild forced. unity-scopes-api (0.6.17+15.10.20150526-0ubuntu1) wily; urgency=medium [ CI Train Bot ] * debian/libunity-scopes3.symbols: update to released version. [ Pawel Stolowski ] * Fix for over-zealous loop detection. A loop is now detected only if a query loops back with the exact same details, that is, query string, department, filter state, user data, and metadata must all be the same. Fixes: https://bugs.launchpad.net/bugs/1457698 (cherry- picked from devel). (LP: #1457698) unity-scopes-api (0.6.17+15.04.20150423.2-0ubuntu1) vivid; urgency=medium [ Marcus Tomlinson ] * Added is_account_login_result() method to Result class. [ Pawel Stolowski ] * Fix LP: #1446499. [ CI Train Bot ] * debian/libunity-scopes3.symbols: update to released version. * New rebuild forced. -- CI Train Bot ci-train-...@canonical.com Tue, 09 Jun 2015 12:21:21 + ** Changed in: unity-scopes-api (Ubuntu RTM) Status: Invalid = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
This bug was fixed in the package unity-scopes-api - 0.6.17+15.04.20150423.2-0ubuntu1 --- unity-scopes-api (0.6.17+15.04.20150423.2-0ubuntu1) vivid; urgency=medium [ Marcus Tomlinson ] * Added is_account_login_result() method to Result class. [ Pawel Stolowski ] * Fix LP: #1446499. [ CI Train Bot ] * debian/libunity-scopes3.symbols: update to released version. * New rebuild forced. unity-scopes-api (0.6.16+15.04.20150410.3-0ubuntu1) vivid; urgency=medium [ Pawel Stolowski ] * Added support for attaching arbitrary data to CannedQuery. * Added _ENABLE_QT_EXPERIMENTAL_ guard to qt headers until that library is finalized. Further changes in the unity::scopes::qt namespace are expected at this point. * Added DateTimePickerFilter into experimental namespace. [ CI Train Bot ] * debian/libunity-scopes-qt.symbols: update to released version. * debian/libunity-scopes3.symbols: update to released version. * New rebuild forced. unity-scopes-api (0.6.15+15.04.20150407-0ubuntu1) vivid; urgency=medium [ Marcus Tomlinson ] * Renamed child_scopes() to find_child_scopes() * Renamed child_scopes_ordered() to child_scopes() * Added is_aggregated() and aggregated_keywords() to SearchMetaData [ CI Train Bot ] * debian/libunity-scopes3.symbols: update to released version. * New rebuild forced. unity-scopes-api (0.6.14+15.04.20150223-0ubuntu1) vivid; urgency=medium [ Pawel Stolowski ] * Set CrashDB attribute to point at savilerow project for click scopes which has 'Canonical' as the maintainer. [ Michi Henning ] * Fixed compilation problems when compiling with boost 1.56 and 1.57. * Fixed a bunch of copyright headers. unity-scopes-api (0.6.14+15.04.20150213-0ubuntu1) vivid; urgency=medium [ Michi Henning ] * Added push_surfacing_results_from_cache() to Reply proxy. This allows a scope to reply the results of the last succesful surfacing query from an on-disk cache. This is useful to prevent the user being presented with an empty screen when swiping to the scope while the device has no network access, or the scope's data source is off-line. Note: This is change is ABI compatible with gcc and clang despite the addition a new virtual function. * Fixed sporadic failure in JsonAsyncReader test caused by slow DNS. Improved tests to report exception details if an exception other than the expected one is thrown. [ CI Train Bot ] * debian/libunity-scopes3.symbols: auto-update to released version unity-scopes-api (0.6.13+15.04.20150211-0ubuntu1) vivid; urgency=medium [ Ubuntu daily release ] * debian/libunity-scopes3.symbols: auto-update to released version [ Michi Henning ] * Fixed a bunch of warnings caused by QVariant headers. Restored spelling of Thomas Voß's surname. Fixed test failure in RuntimeConfig caused by a change in the glib .ini parser from Utopic to Vidid. This allows the test to pass on both Utopic and Vivid. Fixed a few clang warnings. * Reduced log history to 2 MB per scope. * Fixed core dump in the run time when a scope threw an exception from PreviewQueryBase::run(). * Added tests for exceptions thrown from client-side callbacks. * Suppressed warning for arm build and updated comment regarding alignment. * Added valgrind suppression for leak in net-cpp. Added work-around for valgrind complaint about invalid envp being passed when calling execl(). unity-scopes-api (0.6.13+15.04.20150205.1-0ubuntu1) vivid; urgency=medium [ Ubuntu daily release ] * debian/libunity-scopes-qt.symbols: auto-update to released version * New rebuild forced [ Pawel Stolowski ] * Provide script for apport package hooks to handle scoperunner crashes. This script alters 'Package' and 'SourcePackage' fields of the crash report to distribute error reports to correct scopes. [ Xavi Garcia ] * Added library using Qt. The library is packed in a separated debian package. unity-scopes-api (0.6.13+15.04.20150130-0ubuntu1) vivid; urgency=medium [ Marcus Tomlinson ] * Return keywords as a set rather than a vector. [ Ubuntu daily release ] * debian/libunity-scopes3.symbols: auto-update to released version [ Michi Henning ] * Removed a bunch of noise that was logged by the registry if the scope installation dirs contained unexpected files or files without permission. Simplified FindFiles.cpp by using boost::filesystem instead of dirent. unity-scopes-api (0.6.12+15.04.20150127.2-0ubuntu1) vivid; urgency=medium [ Marcus Tomlinson ] * Introduced child_scopes() methods for aggregators to return their list of child scopes at runtime. * Added missing virtual destructor to AbstractScopeBase. (LP: #1360266) * Removed deprecated Runtime::run_scope() method. * Prevent query from looping indefinitely if a query is forwarded among aggregators and loops back to an earlier aggregator. [ Ubuntu daily
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Changed in: canonical-devices-system-image Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
This bug was fixed in the package unity-scopes-shell - 0.5.4+15.04.20150430.1~rtm-0ubuntu1 --- unity-scopes-shell (0.5.4+15.04.20150430.1~rtm-0ubuntu1) 14.09; urgency=medium [ CI Train Bot ] * New rebuild forced. [ Pawel Stolowski ] * Delay change notifications received from scope registry. (LP: #1446499) -- CI Train Bot ci-train-...@canonical.com Thu, 30 Apr 2015 15:36:00 + ** Changed in: unity-scopes-shell (Ubuntu RTM) Status: In Progress = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Changed in: canonical-devices-system-image Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Changed in: canonical-devices-system-image Milestone: ww18-2015 = ww19-ota -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
Backporting the fix in unity-scopes-api in RTM turned out to be too complicated and risky, therefore I implemented the workaround in scopes shell plugin (just for RTM). ** Branch unlinked: lp:~stolowski/unity-scopes-api/delay-scope-removal- rtm ** Changed in: unity-scopes-shell (Ubuntu RTM) Assignee: (unassigned) = Pawel Stolowski (stolowski) ** Changed in: unity-scopes-api (Ubuntu RTM) Status: New = Invalid ** Changed in: unity-scopes-shell (Ubuntu RTM) Status: New = In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Branch linked: lp:~stolowski/unity-scopes-shell/fix-1446499-rtm -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Branch linked: lp:~stolowski/unity-scopes-api/delay-scope-removal-rtm -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Changed in: unity-scopes-api (Ubuntu) Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Changed in: canonical-devices-system-image Importance: Undecided = High ** Changed in: canonical-devices-system-image Status: New = In Progress ** Changed in: canonical-devices-system-image Milestone: None = ww18-2015 ** Changed in: canonical-devices-system-image Assignee: (unassigned) = Pawel Stolowski (stolowski) ** Tags added: hotfix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Changed in: unity-scopes-api (Ubuntu) Status: New = In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Branch unlinked: lp:~stolowski/unity-scopes-shell/fix-1446499 ** Changed in: unity-scopes-api (Ubuntu) Assignee: (unassigned) = Pawel Stolowski (stolowski) ** Changed in: unity-scopes-shell (Ubuntu) Status: In Progress = Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Changed in: unity-scopes-shell (Ubuntu) Assignee: Pawel Stolowski (stolowski) = (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
@Leo there's no way for unit-test it in the unity-api (which is the fix we chose out of the two I considered). Scopes registry from scopes-api knows nothing about favorites etc. This needs to be some sort of high level integration test as you described. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
Currently considering and testing two fixes for this issue, therefore two branches linked but only one will eventually land. Both based on the idea of delaying the notification about scope registry changes (shell plugin does this on receiver end, scopes api does this on the sender side). I've also implemented the idea of not updating the list of favorited scopes, but it turned out to be most complex and risky, because the implications of this change bubbled up in different areas of the plugin. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Also affects: canonical-devices-system-image Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Branch linked: lp:~stolowski/unity-scopes-api/delay-scope-removal- notification -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/today-scope/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
How can we prevent this from regressing? Would it be enough to write unit tests for the new code with the fix, or should we write a higher level test that installs a scope, favorites it and then updates it? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
@Paweł, as for fixing it... the favourites list could just keep the scope in place even if removed, simply ignoring it. I believe that's what happens in the launcher, for example. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/today-scope/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Summary changed: - Updating scope from store removes running scope, doesn't restart + Updating scope from store removes it from favorites -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/today-scope/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Changed in: unity-scopes-shell (Ubuntu) Assignee: (unassigned) = Pawel Stolowski (stolowski) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/today-scope/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Branch linked: lp:~stolowski/unity-scopes-shell/fix-1446499 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/today-scope/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1446499] Re: Updating scope from store removes it from favorites
** Changed in: unity-scopes-shell (Ubuntu) Status: Confirmed = In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1446499 Title: Updating scope from store removes it from favorites To manage notifications about this bug go to: https://bugs.launchpad.net/today-scope/+bug/1446499/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
