[Bug 1483037] Re: Possible Shell Command Injection in daemon

2018-09-17 Thread Alex Murray
** Changed in: unity-scope-audacious (Ubuntu) Status: New => Confirmed ** Changed in: unity-scope-clementine (Ubuntu) Status: New => Confirmed ** Changed in: unity-scope-gmusicbrowser (Ubuntu) Status: New => Confirmed ** Changed in: unity-scope-gourmet (Ubuntu)

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2016-05-17 Thread Seth Arnold
I haven't tested it but the patch looks like a vast improvement. Thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1483037 Title: Possible Shell Command Injection in daemon To manage

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2016-05-17 Thread Bernd Dietzel
OK, check this new patch for the audacious scope. - No injections - Multiple Tracks - Database issues ** Attachment added: "new audacious patch - multiple tracks + database"

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2016-05-16 Thread Seth Arnold
Bernd, all those look like different errors. I just meant that the line: "database = open(dbfile, "r")" doesn't have a corresponding line to close the file once it's done. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2016-05-16 Thread Bernd Dietzel
@Seth , you Comment 17 : I had a look on audacious the db-file access : for collection in os.listdir(AUDACIOUS_DBFILE): dbfile = '%s/%s' % (AUDACIOUS_DBFILE, collection) database = open(dbfile, "r") database = database.read() if not

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2016-05-15 Thread Bernd Dietzel
New patch for unity_audacious_daemon.py with better handling of multiple tracks ** Attachment added: "audacious patch - multiple tracks"

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2016-02-10 Thread Tyler Hicks
Hi David - Can you take a look at Seth's feedback in comment 17 and then update your patches accordingly? Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1483037 Title: Possible Shell Command

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2016-01-01 Thread Bernd Dietzel
For a Shotwell Scope SQL injection Demo , i attached a screenshot. Code can be injected with a file name in the function getPhotoForUri. Demonstration: a) rename some picture like this xx " UNION SELECT

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-12-20 Thread Bernd Dietzel
@David shotwell , firefoxbookmarks, chromiumbookmarks and zotero scope may be checked for sql injections, too. Example : Some code of the shotwell scope : sql='select * from PhotoTable where filename = \"'+filename+'\"' -- You received this bug notification because you are a member of Ubuntu

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-12-19 Thread Bernd Dietzel
My new Clementine Patch. I had a look on the other patches to fix the SQL injections. Fixed utf8 decoding to crash with try and except. Hope it works. Please test. ** Attachment added: "clementine patch , Shell Injections + SQL Injections + UTF8 Crash"

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-11-25 Thread Seth Arnold
The clementine patch appears to address the shell injection but does not address UTF-8 crashes nor SQL injections. The gourmet patch appears to address the SQL injection but does not address the predictable /tmp/ filenames, potential cross-site scripting issues due to use of unquoted HTML, and

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-11-16 Thread David Callé
** Patch added: "Patch for Guayadeque scope" https://bugs.launchpad.net/ubuntu/+source/unity-scope-audacious/+bug/1483037/+attachment/4520006/+files/unity-scope-guayadeque.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-11-15 Thread David Callé
** Patch added: "Patch for Audacious scope" https://bugs.launchpad.net/ubuntu/+source/unity-scope-audacious/+bug/1483037/+attachment/4519724/+files/unity-scope-audacious.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-11-15 Thread David Callé
** Patch added: "Patch for gMusicBrowser" https://bugs.launchpad.net/ubuntu/+source/unity-scope-audacious/+bug/1483037/+attachment/4519728/+files/unity-scope-gmusicbrowser.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-11-15 Thread Bernd Dietzel
@David Did you noticed that the albumtracks are a list and not a simple string ? Have a look on my "Better patch for unity_clementine_daemon.py" on comment #10 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-11-15 Thread David Callé
** Patch added: "Patch for Musique scope" https://bugs.launchpad.net/ubuntu/+source/unity-scope-audacious/+bug/1483037/+attachment/4519752/+files/unity-scope-musique.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-10-29 Thread David Callé
** Patch added: "Patch for Gourmet SQL injection" https://bugs.launchpad.net/ubuntu/+source/unity-scope-gmusicbrowser/+bug/1483037/+attachment/4508319/+files/unity-scope-gourmet.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-10-23 Thread Bernd Dietzel
Better patch attached for the clementine unity scope Python script. 1) I use subprocess.Popen() this time instead of the simple subprocess.call() before. 2) Should now handle albumtracks in a better way because its a list of strings. 3) Clementime gives you now a error message on playing a

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-10-22 Thread Bernd Dietzel
I attached a patch for unity_clementine_daemon.py wich should solve the problem using subprocess ** Patch added: "unity_clementine_daemon_patch.diff" https://bugs.launchpad.net/ubuntu/+source/unity-scope-clementine/+bug/1483037/+attachment/4502656/+files/unity_clementine_daemon_patch.diff --

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-10-22 Thread Ubuntu Foundations Team Bug Bot
The attachment "unity_clementine_daemon_patch.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-08-31 Thread Seth Arnold
All these tools used unsafe APIs and need drastic re-working regardless of specific database mitigations. Thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1483037 Title: Possible Shell Command

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-08-30 Thread Bernd Dietzel
If the shell command can be injected seems only depend on how the Musikplayers store their data. The Gmusicbrowser Unity Scope seems to be lucky because the gmusicbrowser player changes special chars in the name before it stores it in his database. The Audacious Scope and Clementine Scope are

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-08-18 Thread David Callé
** Also affects: unity-scope-audacious (Ubuntu) Importance: Undecided Status: New ** Also affects: unity-scope-clementine (Ubuntu) Importance: Undecided Status: New ** Also affects: unity-scope-guayadeque (Ubuntu) Importance: Undecided Status: New ** Also affects:

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-08-14 Thread Bernd Dietzel
Exploid Demo Video (german) https://www.youtube.com/watch?v=JrP7B6CIOMQ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1483037 Title: Possible Shell Command Injection in daemon To manage

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-08-14 Thread Seth Arnold
Bernd, thank you for this report and excellent demonstrations. More to come later. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1483037 Title: Possible Shell Command Injection in daemon To manage

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-08-10 Thread Bernd Dietzel
I attached a Clementine Scope Exploid Screenshot Demo ** Attachment added: exploid scope clementine https://bugs.launchpad.net/ubuntu/+source/unity-scope-gmusicbrowser/+bug/1483037/+attachment/4442436/+files/Clementine%20Scope%20Exploid%20Screenshot.png -- You received this bug

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-08-09 Thread Bernd Dietzel
** Summary changed: - Possible Shell Comand Injection in deamon + Possible Shell Command Injection in daemon -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1483037 Title: Possible Shell Command

[Bug 1483037] Re: Possible Shell Command Injection in daemon

2015-08-09 Thread Phillip Sz
** Information type changed from Public to Public Security -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1483037 Title: Possible Shell Command Injection in daemon To manage notifications about