[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-08-17 Thread Launchpad Bug Tracker
This bug was fixed in the package zfs-linux - 0.6.5.6-0ubuntu12 --- zfs-linux (0.6.5.6-0ubuntu12) xenial; urgency=medium * Change to include some important tools in zfsutils-linux build. - Add tools : arcstat.py, arc_summary.py & dbufstat.py in /usr/sbin. - Change utilities path

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-08-14 Thread Richard Laager
This works for me "in the wild" (i.e. waiting until today, which was the second Sunday of the month). I had two servers, one with 0.6.5.6-0ubuntu11 and one with 0.6.5.6-0ubuntu12. ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, whic

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-08-01 Thread Richard Laager
This works for me, using the first test case. If this feels good enough, feel free to change the tag yourself. Otherwise, I'll do so after verifying the unmodified cron configuration works on the 14th. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscri

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-29 Thread Richard Laager
Also note that this is the exact PATH from /etc/crontab, which is thus also the PATH under which /etc/cron.{hourly,daily,weekly,monthly} run. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Titl

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-28 Thread Mathew Hodson
** Changed in: zfs-linux (Ubuntu Xenial) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Title: ZFS pools should be automatically scrubbed To manage notific

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-28 Thread Tim Bishop
Could /usr/lib/zfs-linux/scrub not just give the full path to zpool instead? Then PATH wouldn't need modifying at all. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Title: ZFS pools should b

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-28 Thread Andy Whitcroft
Hello Richard, or anyone else affected, Accepted zfs-linux into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/zfs- linux/0.6.5.6-0ubuntu11 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-28 Thread Andy Whitcroft
Ok, comparing this to other users of /etc/cron.d it does seem to be a common idiom used there. To update the path to exactly the above form. So this is not making things any worse. I am inclined to let this go on that basis given it is already in yakkety. /etc/cron.d/anacron:PATH=/usr/local/sbin

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-28 Thread Mark Wilkinson
Would it not make more sense to have /usr/lib/zfs-linux/scrub set the PATH that it requires in order to find the zpool command? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Title: ZFS pools

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-28 Thread Michael Terry
I get not wanting unnecessary PATHs... But is /usr/local really considered a security issue? It's in /usr... It's part of the standard PATH for the root user. And if an admin has installed tools in /usr/local, wouldn't they expect them to be used? -- You received this bug notification because

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-28 Thread Colin Ian King
/usr/local/bin and /usr/local/sbin are not required for anything zfs specific, so given that they are redundant they should not be added to the PATH. Plus the security issue as mentioned above. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to U

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-28 Thread Colin Ian King
This should be rejected for Xenial and reverted for Yakkety and a more minimal path used. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Title: ZFS pools should be automatically scrubbed To

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-28 Thread Andy Whitcroft
This patch adds /usr/local/bin and /usr/local/sbin to the path. Given the utilities in use are all official binaries this seems unexpected and a potential security risk. ** Changed in: zfs-linux (Ubuntu Xenial) Status: New => Incomplete -- You received this bug notification because you a

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-28 Thread Michael Terry
I've uploaded the patch to xenial-proposed too. Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Title: ZFS pools should be automatically scrubbed To manage notifications about this b

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-28 Thread C de-Avillez
** Also affects: zfs-linux (Ubuntu Xenial) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Title: ZFS pools should be automatically scrubbed To man

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-27 Thread Richard Laager
** Description changed: + [Impact] + + Xenial shipped with a cron job to automatically scrub ZFS pools, as + desired by many users and as implemented by mdadm for traditional Linux + software RAID. Unfortunately, this cron job does not work, because it needs a PATH line for /sbin, where the zpo

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-27 Thread Launchpad Bug Tracker
This bug was fixed in the package zfs-linux - 0.6.5.7-0ubuntu4 --- zfs-linux (0.6.5.7-0ubuntu4) yakkety; urgency=medium * Set PATH in cron.d job to fix monthly scrubs. (LP: #1548009) -- Richard Laager Wed, 06 Jul 2016 22:37:47 -0500 ** Changed in: zfs-linux (Ubuntu) Stat

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-27 Thread Michael Terry
Thanks for the patch! I've uploaded to yakkety, this bug should autoclose. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Title: ZFS pools should be automatically scrubbed To manage notific

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-26 Thread Colin Ian King
** Changed in: zfs-linux (Ubuntu) Importance: Wishlist => Medium ** Changed in: zfs-linux (Ubuntu) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Tit

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-10 Thread Richard Laager
I can confirm that the .debdiff I attached in comment #11 fixes the problem. My system ran the scrub today. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Title: ZFS pools should be automatic

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-07-07 Thread Mathew Hodson
** Summary changed: - [FFe] ZFS pools should be automatically scrubbed + ZFS pools should be automatically scrubbed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Title: ZFS pools should be

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-03-14 Thread Richard Laager
** Description changed: mdadm automatically checks MD arrays. ZFS should automatically scrub - pools too, to detect and (when possible) correct on-disk corruption. + pools too. Scrubbing a pool allows ZFS to detect and (when the pool has + redundancy) correct on-disk corruption. I've attach

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-03-14 Thread Seth Arnold
BTW, the parameters that are necessary to tun the relative priority of scrubs and resilvers against normal IO is described in detail in the zfs-module-parameters(5) manpage, especially the "ZFS I/O SCHEDULER" section: https://github.com/zfsonlinux/zfs/blob/master/man/man5/zfs-module- parameters.5#

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-03-14 Thread Richard Laager
** Description changed: mdadm automatically checks MD arrays. ZFS should automatically scrub - pools. + pools too, to detect and (when possible) correct on-disk corruption. - I've attached a debdiff which accomplishes this. + I've attached a debdiff which accomplishes this. It builds and inst

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-03-14 Thread Richard Laager
Is this going to make the Xenial release? What needs to be done still? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Title: ZFS pools should be automatically scrubbed To manage notification

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-03-06 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: zfs-linux (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Title:

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-02-22 Thread Richard Laager
A false negative, where an objectively corrupt block is treated as valid, is not ideal, but not harmful. The scrub would fail to correct the error, but it wouldn't make it worse. It would be detected as bad on the next read (scrub or otherwise). There's also a case of a bad block being overwritten

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-02-22 Thread Colin Ian King
What about the issue of scrubbing on systems that don't have memory correction (non-ECC). Is there a possibility that a scrub with silently corrupted memory could actually introduce more harm than good? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscr

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-02-22 Thread Richard Laager
The disk load added by scrubbing is almost entirely reading. There is a tiny amount of metadata writes to track of the scrub's progress (so it can resume after a reboot). The only time a scrub would write significant data is if it found a bad block (checksum error) and needed to rewrite a good copy

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-02-22 Thread Colin Ian King
Thanks Richard, Just a few things: "The meat of it is the scrub script I've been using (and recommending in my HOWTO) for years, which scrubs all *healthy* pools. If a pool is not healthy, scrubbing it is bad for two reasons: 1) It adds a lot of disk load which could lead to another failure. We

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-02-21 Thread Colin Ian King
** Changed in: zfs-linux (Ubuntu) Assignee: (unassigned) => Colin Ian King (colin-king) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Title: ZFS pools should be automatically scrubbed

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-02-21 Thread Mathew Hodson
** Changed in: zfs-linux (Ubuntu) Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1548009 Title: ZFS pools should be automatically scrubbed To manage notification

[Bug 1548009] Re: ZFS pools should be automatically scrubbed

2016-02-21 Thread Ubuntu Foundations Team Bug Bot
The attachment "zfs-linux.scrub.debdiff.2" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag,