[Bug 1550706] Re: Thumbnails not working with qrc

2016-03-08 Thread Michael Zanetti
** Changed in: thumbnailer (Ubuntu) Status: New => Opinion -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1550706 Title: Thumbnails not working with qrc To manage notifications about this

[Bug 1550706] Re: Thumbnails not working with qrc

2016-03-08 Thread Michi Henning
> Still a bit wondering why it does implement the scaling of local images use case then at all and does not just media artwork matching/fetching alone then. >From the application perspective, it wants to say "give me an image in such and such a size for this thing", where the thing could be just

[Bug 1550706] Re: Thumbnails not working with qrc

2016-03-04 Thread Michael Zanetti
* Sure it is possible to not ship artwork in a qrc. However, that requires the developer to fiddle with the apparmor confined paths and afaict, there's no QML-only way to do so. Besides, as I said before, the default in our sdk templates is to put things in a qrc to ease up development. * I agree

[Bug 1550706] Re: Thumbnails not working with qrc

2016-03-04 Thread Michi Henning
Still not trying to rain on the part here... :-) I'd like to make it work. But having images buried inside an executable is not a good idea when it comes to interoperating with tools such as the thumbnailer. Personally, I don't think the thumbnailer is a good fit for this. Is it possible to

[Bug 1550706] Re: Thumbnails not working with qrc

2016-03-04 Thread Michael Zanetti
The use case is for scaling the images. Especially in games you often want to ship larger artwork so that the game looks good on a tablet. However, running that game on a phone then will be slow because of the big amount of artwork that needs to be scaled down all the time. That's when I thought

[Bug 1550706] Re: Thumbnails not working with qrc

2016-03-04 Thread Michael Zanetti
If you guys think this is out of scope for the thumbnailer, please let me know. I need some more flexible image cache in many places. If the thumbnailer is not the right place to do this, I will try to come up with something else for those cases. The reason why I thought this would fit for the

[Bug 1550706] Re: Thumbnails not working with qrc

2016-03-04 Thread James Henstridge
** Changed in: thumbnailer (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1550706 Title: Thumbnails not working with qrc To manage notifications about this

[Bug 1550706] Re: Thumbnails not working with qrc

2016-03-01 Thread James Henstridge
Rather than looking at what is necessary to make files compiled into an executable visible to an external process, could we step back a bit to find out what we're trying to accomplish? What do you think will be done differently by having "qrc:///images /menu-background.jpg" passed through the

[Bug 1550706] Re: Thumbnails not working with qrc

2016-03-01 Thread Michi Henning
** Changed in: thumbnailer (Ubuntu) Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1550706 Title: Thumbnails not working with qrc To manage notifications about

[Bug 1550706] Re: Thumbnails not working with qrc

2016-03-01 Thread Michi Henning
This looks doable, at least in principle, but raises a few questions. How does the thumbnailer decide *where* in the file system to write the file? Note that, if the file gets written somewhere where other applications can read it, this will potentially allow application B to see a thumbnail

[Bug 1550706] Re: Thumbnails not working with qrc

2016-03-01 Thread Michael Zanetti
The thumbnailer itself would not really need to know about th qrc stuff. Just the QQmlImageProvider part of the thumbnailer package. That could extract the image data from the qrc and pass it on to the thumbnailer. Here's some code snipped that should give directions on how to do that:

[Bug 1550706] Re: Thumbnails not working with qrc

2016-03-01 Thread Michi Henning
Sorry, "The thumbnailer should not know about..." -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1550706 Title: Thumbnails not working with qrc To manage notifications about this bug go to:

[Bug 1550706] Re: Thumbnails not working with qrc

2016-03-01 Thread Michi Henning
I really don't think this is a thumbnailer problem. The thumbnailer should know about things such as qrc virtual filesystems. It simply maps a path name to a thumbnail. That's it, and it should stay that way. -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1550706] Re: Thumbnails not working with qrc

2016-02-29 Thread Michael Zanetti
As written in comment #3 "As the thumbnailer is remote process and thus won't have access to the in-binary resources files, the QQmlImageProvider could perhaps extract them from the binary, provide them to the thumbnailer and delete the temporarily extracted original file again." -- You

[Bug 1550706] Re: Thumbnails not working with qrc

2016-02-29 Thread Albert Astals Cid
The thumbnailer is an external process, it can't see the qrc resource -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1550706 Title: Thumbnails not working with qrc To manage notifications about

[Bug 1550706] Re: Thumbnails not working with qrc

2016-02-29 Thread Michi Henning
Well, there was definitely a bug in the thumbnailer that relates to relative pathnames, and I just picked up on the error message you copied. If there is a virtual filesystem somewhere, the thumbnailer has no idea that it exists. In a nutshell, the thumbnailer can produce a thumbnailer for a path

[Bug 1550706] Re: Thumbnails not working with qrc

2016-02-29 Thread Michael Zanetti
I don't think this has to do with relative path names. The way .qrc files work is that the image files are compiled into the application binary and it sets up a virtual file system inside the binary that contains stuff from the resource file. The path "qrc:///image.png" is actually an absolute

[Bug 1550706] Re: Thumbnails not working with qrc

2016-02-28 Thread Michi Henning
> If path() expands it to a relative path with respect to the directory containing the qrc file, it won't. Unless the working dir of the app is the dir containing the qrc file. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1550706] Re: Thumbnails not working with qrc

2016-02-28 Thread Michi Henning
A fix for the incorrect processing of relative path names is sitting in silo 75 at the moment. It's waiting for testing sign-off. The thumbnailer qml plug-in just does this: QQuickImageResponse* ThumbnailGenerator::requestImageResponse(const QString& id, const QSize& requestedSize) {

[Bug 1550706] Re: Thumbnails not working with qrc

2016-02-28 Thread Michael Zanetti
I just confirmed this with a snippet of code: Works: Image { width: 100 height: 100 sourceSize: Qt.size(width, height) source: "/image.png" } Works: Image { width: 100 height: 100 sourceSize: Qt.size(width, height) source: "image://thumbnailer/file:///image.png" } Works:

[Bug 1550706] Re: Thumbnails not working with qrc

2016-02-28 Thread Michael Zanetti
Michi, I don't think this case should be dismissed so quickly. If one creates a new default app template with out SDK, putting images into qrc files is the default way to go. In order to create games that look good on big screens like tablet, but still perform well on small screens and weak

[Bug 1550706] Re: Thumbnails not working with qrc

2016-02-27 Thread Michi Henning
If you want a thumbnail for an image, you have to give an image: url to qml. See https://developer.ubuntu.com/en/apps/qml/tutorials/use-ubuntu- thumbnailer/ ** Changed in: thumbnailer (Ubuntu) Status: New => Invalid -- You received this bug notification because you are a member of