[Bug 1561007] Re: Upstream Bug #3769: client_netmask not evaluated since Comm redesign
(Standard support has ended for 14.04.) ** Changed in: squid3 (Ubuntu Trusty) Status: New => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1561007 Title: Upstream Bug #3769: client_netmask not evaluated since Comm redesign To manage notifications about this bug go to: https://bugs.launchpad.net/squid/+bug/1561007/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1561007] Re: Upstream Bug #3769: client_netmask not evaluated since Comm redesign
One more remark - there is another open bug that has a simple, tested fix and is already marked pending for release: https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1405351 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1561007 Title: Upstream Bug #3769: client_netmask not evaluated since Comm redesign To manage notifications about this bug go to: https://bugs.launchpad.net/squid/+bug/1561007/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1561007] Re: Upstream Bug #3769: client_netmask not evaluated since Comm redesign
One more remark - there is another open bug that has a simple, tested fix and is already marked pending for release: https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1405351 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1561007 Title: Upstream Bug #3769: client_netmask not evaluated since Comm redesign To manage notifications about this bug go to: https://bugs.launchpad.net/squid/+bug/1561007/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1561007] Re: Upstream Bug #3769: client_netmask not evaluated since Comm redesign
Tested, works! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1561007 Title: Upstream Bug #3769: client_netmask not evaluated since Comm redesign To manage notifications about this bug go to: https://bugs.launchpad.net/squid/+bug/1561007/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1561007] Re: Upstream Bug #3769: client_netmask not evaluated since Comm redesign
Tested, works! -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1561007 Title: Upstream Bug #3769: client_netmask not evaluated since Comm redesign To manage notifications about this bug go to: https://bugs.launchpad.net/squid/+bug/1561007/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1561007] Re: Upstream Bug #3769: client_netmask not evaluated since Comm redesign
> I took the patch from the upstream 3.3 branch rather than your patches -- although I think the net effect is the same. You mean there was a patch in upstream 3.3 that applies cleanly? That's much better than my hacked together fix. I will install squid from your PPA and test it. ** Description changed: [Impact] http://www.squid-cache.org/mail-archive/squid-users/201403/0065.html: > This bug caused the client_netmask directive in Squid-3.2 and Squid-3.3 releases to have no effect. The designed behaviour of masking client IPs in logs is now restored. Upstream issue tracker: http://bugs.squid-cache.org/show_bug.cgi?id=3769 In all versions of squid3 between 3.2 and 3.4.4 a pretty severe bug exists that disables the scrubbing of client IPs. Scrubbing of client IPs is extremely important for any privacy-aware and risk-aware provider. [Test Case] - TBD + + 1. Install squid3: apt-get install squid3 + 2. Observe that full client IP is logged to /var/log/squid/access.log + 2. Add "client_netmask 255.255.0.0" to config + 3. Observe that full client IP is still logged + 4. Apply patch + 5. Observe that only the first two octets of client IP are logged now. [Regression Potential] - TBD + + The fix is minimally invasive and adds only an interaction with the + IP::Address class that was not present. It is also identical to upstream + changes except for cosmetic refactoring done between the trusty version + of squid3 and when the bug was fixed in upstream. ** Description changed: [Impact] http://www.squid-cache.org/mail-archive/squid-users/201403/0065.html: > This bug caused the client_netmask directive in Squid-3.2 and Squid-3.3 releases to have no effect. The designed behaviour of masking client IPs in logs is now restored. Upstream issue tracker: http://bugs.squid-cache.org/show_bug.cgi?id=3769 In all versions of squid3 between 3.2 and 3.4.4 a pretty severe bug exists that disables the scrubbing of client IPs. Scrubbing of client IPs is extremely important for any privacy-aware and risk-aware provider. [Test Case] 1. Install squid3: apt-get install squid3 2. Observe that full client IP is logged to /var/log/squid/access.log 2. Add "client_netmask 255.255.0.0" to config 3. Observe that full client IP is still logged 4. Apply patch 5. Observe that only the first two octets of client IP are logged now. [Regression Potential] - The fix is minimally invasive and adds only an interaction with the - IP::Address class that was not present. It is also identical to upstream - changes except for cosmetic refactoring done between the trusty version - of squid3 and when the bug was fixed in upstream. + The fix is minimally invasive and adds only an interaction with the IP::Address class that was not present in the current release. It is also identical to upstream changes except for cosmetic refactoring done between the trusty version of squid3 and when the bug was fixed in upstream. + Regression potential is therefore minimal. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1561007 Title: Upstream Bug #3769: client_netmask not evaluated since Comm redesign To manage notifications about this bug go to: https://bugs.launchpad.net/squid/+bug/1561007/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1561007] Re: Upstream Bug #3769: client_netmask not evaluated since Comm redesign
> I took the patch from the upstream 3.3 branch rather than your patches -- although I think the net effect is the same. You mean there was a patch in upstream 3.3 that applies cleanly? That's much better than my hacked together fix. I will install squid from your PPA and test it. ** Description changed: [Impact] http://www.squid-cache.org/mail-archive/squid-users/201403/0065.html: > This bug caused the client_netmask directive in Squid-3.2 and Squid-3.3 releases to have no effect. The designed behaviour of masking client IPs in logs is now restored. Upstream issue tracker: http://bugs.squid-cache.org/show_bug.cgi?id=3769 In all versions of squid3 between 3.2 and 3.4.4 a pretty severe bug exists that disables the scrubbing of client IPs. Scrubbing of client IPs is extremely important for any privacy-aware and risk-aware provider. [Test Case] - TBD + + 1. Install squid3: apt-get install squid3 + 2. Observe that full client IP is logged to /var/log/squid/access.log + 2. Add "client_netmask 255.255.0.0" to config + 3. Observe that full client IP is still logged + 4. Apply patch + 5. Observe that only the first two octets of client IP are logged now. [Regression Potential] - TBD + + The fix is minimally invasive and adds only an interaction with the + IP::Address class that was not present. It is also identical to upstream + changes except for cosmetic refactoring done between the trusty version + of squid3 and when the bug was fixed in upstream. ** Description changed: [Impact] http://www.squid-cache.org/mail-archive/squid-users/201403/0065.html: > This bug caused the client_netmask directive in Squid-3.2 and Squid-3.3 releases to have no effect. The designed behaviour of masking client IPs in logs is now restored. Upstream issue tracker: http://bugs.squid-cache.org/show_bug.cgi?id=3769 In all versions of squid3 between 3.2 and 3.4.4 a pretty severe bug exists that disables the scrubbing of client IPs. Scrubbing of client IPs is extremely important for any privacy-aware and risk-aware provider. [Test Case] 1. Install squid3: apt-get install squid3 2. Observe that full client IP is logged to /var/log/squid/access.log 2. Add "client_netmask 255.255.0.0" to config 3. Observe that full client IP is still logged 4. Apply patch 5. Observe that only the first two octets of client IP are logged now. [Regression Potential] - The fix is minimally invasive and adds only an interaction with the - IP::Address class that was not present. It is also identical to upstream - changes except for cosmetic refactoring done between the trusty version - of squid3 and when the bug was fixed in upstream. + The fix is minimally invasive and adds only an interaction with the IP::Address class that was not present in the current release. It is also identical to upstream changes except for cosmetic refactoring done between the trusty version of squid3 and when the bug was fixed in upstream. + Regression potential is therefore minimal. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1561007 Title: Upstream Bug #3769: client_netmask not evaluated since Comm redesign To manage notifications about this bug go to: https://bugs.launchpad.net/squid/+bug/1561007/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1561007] Re: Upstream Bug #3769: client_netmask not evaluated since Comm redesign
Hi, thanks for the bug report. I've made a patch with (I think :-p) correct dep3 headers, attached, and also in my PPA: https://launchpad.net/~mwhudson/+archive/ubuntu/scratch/+packages. I took the patch from the upstream 3.3 branch rather than your patches -- although I think the net effect is the same. Can you fill out the test case and regression potential sections of the bug summary? Then we can start the progress of getting it reviewed by the SRU team. ** Description changed: - NOTE: This bug is for trusty. + [Impact] http://www.squid-cache.org/mail-archive/squid-users/201403/0065.html: > This bug caused the client_netmask directive in Squid-3.2 and Squid-3.3 releases to have no effect. The designed behaviour of masking client IPs in logs is now restored. Upstream issue tracker: http://bugs.squid-cache.org/show_bug.cgi?id=3769 In all versions of squid3 between 3.2 and 3.4.4 a pretty severe bug exists that disables the scrubbing of client IPs. Scrubbing of client IPs is extremely important for any privacy-aware and risk-aware provider. - Based on the bzr commit fixing the bug - (http://bazaar.launchpad.net/~squid/squid/3.4/revision/squ...@treenet.co.nz-20140212085229-edx2i4es622uo0gm) - I made a patch. The diff of the bzr revision doesn't apply but the - differences are solely due to cosmetic refactoring of method names in - squid 3.4. I'm not familiar with the debian / ubuntu package maintenance - tools so the patch ended up as a two-parter. + [Test Case] + TBD + + [Regression Potential] + TBD ** Patch added: "backoorted fix" https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1561007/+attachment/4609124/+files/squid3_3.3.8-1ubuntu6.6_3.3.8-1ubuntu6.7.diff -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1561007 Title: Upstream Bug #3769: client_netmask not evaluated since Comm redesign To manage notifications about this bug go to: https://bugs.launchpad.net/squid/+bug/1561007/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1561007] Re: Upstream Bug #3769: client_netmask not evaluated since Comm redesign
Hi, thanks for the bug report. I've made a patch with (I think :-p) correct dep3 headers, attached, and also in my PPA: https://launchpad.net/~mwhudson/+archive/ubuntu/scratch/+packages. I took the patch from the upstream 3.3 branch rather than your patches -- although I think the net effect is the same. Can you fill out the test case and regression potential sections of the bug summary? Then we can start the progress of getting it reviewed by the SRU team. ** Description changed: - NOTE: This bug is for trusty. + [Impact] http://www.squid-cache.org/mail-archive/squid-users/201403/0065.html: > This bug caused the client_netmask directive in Squid-3.2 and Squid-3.3 releases to have no effect. The designed behaviour of masking client IPs in logs is now restored. Upstream issue tracker: http://bugs.squid-cache.org/show_bug.cgi?id=3769 In all versions of squid3 between 3.2 and 3.4.4 a pretty severe bug exists that disables the scrubbing of client IPs. Scrubbing of client IPs is extremely important for any privacy-aware and risk-aware provider. - Based on the bzr commit fixing the bug - (http://bazaar.launchpad.net/~squid/squid/3.4/revision/squ...@treenet.co.nz-20140212085229-edx2i4es622uo0gm) - I made a patch. The diff of the bzr revision doesn't apply but the - differences are solely due to cosmetic refactoring of method names in - squid 3.4. I'm not familiar with the debian / ubuntu package maintenance - tools so the patch ended up as a two-parter. + [Test Case] + TBD + + [Regression Potential] + TBD ** Patch added: "backoorted fix" https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1561007/+attachment/4609124/+files/squid3_3.3.8-1ubuntu6.6_3.3.8-1ubuntu6.7.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1561007 Title: Upstream Bug #3769: client_netmask not evaluated since Comm redesign To manage notifications about this bug go to: https://bugs.launchpad.net/squid/+bug/1561007/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1561007] Re: Upstream Bug #3769: client_netmask not evaluated since Comm redesign
** Bug watch added: Squid Bugzilla #3769 http://bugs.squid-cache.org/show_bug.cgi?id=3769 ** Also affects: squid via http://bugs.squid-cache.org/show_bug.cgi?id=3769 Importance: Unknown Status: Unknown ** Also affects: squid3 (Ubuntu Trusty) Importance: Undecided Status: New ** Changed in: squid3 (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to squid3 in Ubuntu. https://bugs.launchpad.net/bugs/1561007 Title: Upstream Bug #3769: client_netmask not evaluated since Comm redesign To manage notifications about this bug go to: https://bugs.launchpad.net/squid/+bug/1561007/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1561007] Re: Upstream Bug #3769: client_netmask not evaluated since Comm redesign
** Bug watch added: Squid Bugzilla #3769 http://bugs.squid-cache.org/show_bug.cgi?id=3769 ** Also affects: squid via http://bugs.squid-cache.org/show_bug.cgi?id=3769 Importance: Unknown Status: Unknown ** Also affects: squid3 (Ubuntu Trusty) Importance: Undecided Status: New ** Changed in: squid3 (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1561007 Title: Upstream Bug #3769: client_netmask not evaluated since Comm redesign To manage notifications about this bug go to: https://bugs.launchpad.net/squid/+bug/1561007/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1561007] Re: Upstream Bug #3769: client_netmask not evaluated since Comm redesign
Second part of patch. ** Patch added: "fix-3769-2.patch" https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1561007/+attachment/4608655/+files/fix-3769-2.patch ** Description changed: + NOTE: This bug is for trusty. + http://www.squid-cache.org/mail-archive/squid-users/201403/0065.html: > This bug caused the client_netmask directive in Squid-3.2 and Squid-3.3 releases to have no effect. The designed behaviour of masking client IPs - in logs is now restored. + in logs is now restored. Upstream issue tracker: http://bugs.squid-cache.org/show_bug.cgi?id=3769 In all versions of squid3 between 3.2 and 3.4.4 a pretty severe bug exists that disables the scrubbing of client IPs. Scrubbing of client IPs is extremely important for any privacy-aware and risk-aware provider. Based on the bzr commit fixing the bug (http://bazaar.launchpad.net/~squid/squid/3.4/revision/squ...@treenet.co.nz-20140212085229-edx2i4es622uo0gm) I made a patch. The diff of the bzr revision doesn't apply but the differences are solely due to cosmetic refactoring of method names in squid 3.4. I'm not familiar with the debian / ubuntu package maintenance tools so the patch ended up as a two-parter. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to squid3 in Ubuntu. https://bugs.launchpad.net/bugs/1561007 Title: Upstream Bug #3769: client_netmask not evaluated since Comm redesign To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1561007/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1561007] Re: Upstream Bug #3769: client_netmask not evaluated since Comm redesign
Second part of patch. ** Patch added: "fix-3769-2.patch" https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1561007/+attachment/4608655/+files/fix-3769-2.patch ** Description changed: + NOTE: This bug is for trusty. + http://www.squid-cache.org/mail-archive/squid-users/201403/0065.html: > This bug caused the client_netmask directive in Squid-3.2 and Squid-3.3 releases to have no effect. The designed behaviour of masking client IPs - in logs is now restored. + in logs is now restored. Upstream issue tracker: http://bugs.squid-cache.org/show_bug.cgi?id=3769 In all versions of squid3 between 3.2 and 3.4.4 a pretty severe bug exists that disables the scrubbing of client IPs. Scrubbing of client IPs is extremely important for any privacy-aware and risk-aware provider. Based on the bzr commit fixing the bug (http://bazaar.launchpad.net/~squid/squid/3.4/revision/squ...@treenet.co.nz-20140212085229-edx2i4es622uo0gm) I made a patch. The diff of the bzr revision doesn't apply but the differences are solely due to cosmetic refactoring of method names in squid 3.4. I'm not familiar with the debian / ubuntu package maintenance tools so the patch ended up as a two-parter. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1561007 Title: Upstream Bug #3769: client_netmask not evaluated since Comm redesign To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/squid3/+bug/1561007/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
