[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Launchpad Bug Tracker]

This bug was fixed in the package lshw - 02.18-0.1ubuntu4.1

---
lshw (02.18-0.1ubuntu4.1) artful; urgency=medium

  * AArch64: cpuinfo: Remove redundant cpu caps loop (LP: #1582181)
(Merged into EZix upstream commit [20cda772])

 -- Ike Panhc   Wed, 21 Mar 2018 14:37:08 +0800

** Changed in: lshw (Ubuntu Artful)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Launchpad Bug Tracker]

This bug was fixed in the package lshw - 02.17-1.1ubuntu3.5

---
lshw (02.17-1.1ubuntu3.5) xenial; urgency=medium

  * AArch64: cpuinfo: Remove redundant cpu caps loop (LP: #1582181)
(Merged into EZix upstream commit [20cda772])

 -- Ike Panhc   Wed, 21 Mar 2018 13:12:21 +0800

** Changed in: lshw (Ubuntu Xenial)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Ike Panhc]

lshw in artful-proposed fixes this issue.

ubuntu@recht:~$ time lshw > /dev/null ; dpkg --list | grep lshw
WARNING: you should run this program as super-user.
WARNING: output may be incomplete or inaccurate, you should run this program as 
super-user.

real2m10.793s
user2m10.589s
sys 0m0.192s
ii  lshw   02.18-0.1ubuntu4 
arm64information about hardware configuration

ubuntu@recht:~$ time lshw > /dev/null ; dpkg --list | grep lshw
WARNING: you should run this program as super-user.
WARNING: output may be incomplete or inaccurate, you should run this program as 
super-user.

real0m3.210s
user0m2.984s
sys 0m0.221s
ii  lshw   02.18-0.1ubuntu4.1   
arm64information about hardware configuration


** Tags removed: verification-needed verification-needed-artful
** Tags added: verification-done verification-done-artful

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Ike Panhc]

lshw in xenial-proposed fixes this issue.

ubuntu@recht:~$ time lshw > /dev/null;dpkg --list | grep lshw
WARNING: you should run this program as super-user.
WARNING: output may be incomplete or inaccurate, you should run this program as 
super-user.

real1m50.371s
user1m50.240s
sys 0m0.104s
ii  lshw 02.17-1.1ubuntu3.4 
arm64information about hardware configuration

ubuntu@recht:~$ time lshw > /dev/null;dpkg --list | grep lshw
WARNING: you should run this program as super-user.
WARNING: output may be incomplete or inaccurate, you should run this program as 
super-user.

real0m2.548s
user0m2.460s
sys 0m0.084s
ii  lshw 02.17-1.1ubuntu3.5 
arm64information about hardware configuration


** Tags removed: verification-needed-xenial
** Tags added: verification-done-xenial

** Changed in: lshw (Ubuntu Artful)
 Assignee: (unassigned) => Ike Panhc (ikepanhc)

** Changed in: lshw (Ubuntu Xenial)
 Assignee: (unassigned) => Ike Panhc (ikepanhc)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Brian Murray]

Hello Alexandru, or anyone else affected,

Accepted lshw into artful-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/lshw/02.18-0.1ubuntu4.1 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-artful to verification-done-artful. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-artful. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: lshw (Ubuntu Artful)
   Status: New => Fix Committed

** Tags added: verification-needed verification-needed-artful

** Changed in: lshw (Ubuntu Xenial)
   Status: New => Fix Committed

** Tags added: verification-needed-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Ike Panhc]

** Description changed:

  [Impact]
  lshw takes too long time on parsing /proc/cpuinfo on aarch64 system
  It takes minutes on 96cores and almost 10min on 224cores system.
  
  [Test Case]
- `time sudo lshw` and it shall be less then 15sec
+ `time lshw` and it shall be less then 15sec
  
  [Regression Potential]
  This patch only modifies codes for aarch64. Lowest regression rick on other 
arch and has been tested on aarch64
  
  [Other Info]
  Patch has been merged into upstream branch.
  https://github.com/lyonel/lshw/commit/20cda77239e8604e798b87a0441e694edb0214d1

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Launchpad Bug Tracker]

This bug was fixed in the package lshw - 02.18-0.1ubuntu6

---
lshw (02.18-0.1ubuntu6) bionic; urgency=medium

  * AArch64: cpuinfo: Remove redundant cpu caps loop (LP: #1582181)
(Merged into EZix upstream commit [20cda772])

 -- Ike Panhc   Wed, 21 Mar 2018 14:42:13 +0800

** Changed in: lshw (Ubuntu Bionic)
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[dann frazier]

** Also affects: lshw (Ubuntu Artful)
   Importance: Undecided
   Status: New

** Also affects: lshw (Ubuntu Xenial)
   Importance: Undecided
   Status: New

** Also affects: lshw (Ubuntu Bionic)
   Importance: Undecided
 Assignee: Ike Panhc (ikepanhc)
   Status: In Progress

** Description changed:

- lshw on AArch64 hardware is painfully slow.
- This affects both lshw in current Ubuntu releases and vanilla upstream.
- 
- For a 48 core node, cpuinfo parsing added up to 30 seconds (8 lines
- per core in /proc/cpuinfo add up to 384 lines to parse).
- 
- For a 96 core node, parsing took up to 5 minutes (!).
- 
- I think the problem was introduced by [1], and can be summarized as:
- - CPU capabilities should be added only to the current CPU core,
-   and NOT to all previous CPU cores parsed.
- 
- My suggestion is dropping the loop in [1], thus calling the 
- and  only for currentcpu.
- 
- I put together a small patch (basically removing the for loop in question)
- at [2] (or see attachement), which should be applied on top of version
- "02.16-2ubuntu1.3" from Ubuntu Trusty 14.04.
- 
- After applying the patch at [2], parsing for the above system (48 cores)
- takes less than 1 second (instead of 30s), with the exact same results ...
- 
- [1]
- https://github.com/lyonel/lshw/commit/beb89de5a3c10449fe73f1c77b2486d868e5bc9a
- #diff-f4010714738fa4cdd5999499579da2b3R217
- 
- [2] http://paste.ubuntu.com/16456620/
- 
- # lsb_release -rd
- Description:Ubuntu 14.04.4 LTS
- Release:14.04
- 
- BR,
- Alex
- 
  [Impact]
  lshw takes too long time on parsing /proc/cpuinfo on aarch64 system
  It takes minutes on 96cores and almost 10min on 224cores system.
  
  [Test Case]
  `time sudo lshw` and it shall be less then 15sec
  
  [Regression Potential]
  This patch only modifies codes for aarch64. Lowest regression rick on other 
arch and has been tested on aarch64
  
  [Other Info]
  Patch has been merged into upstream branch.
  https://github.com/lyonel/lshw/commit/20cda77239e8604e798b87a0441e694edb0214d1

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Ike Panhc]

** Description changed:

  lshw on AArch64 hardware is painfully slow.
  This affects both lshw in current Ubuntu releases and vanilla upstream.
  
  For a 48 core node, cpuinfo parsing added up to 30 seconds (8 lines
  per core in /proc/cpuinfo add up to 384 lines to parse).
  
  For a 96 core node, parsing took up to 5 minutes (!).
  
  I think the problem was introduced by [1], and can be summarized as:
  - CPU capabilities should be added only to the current CPU core,
-   and NOT to all previous CPU cores parsed.
+   and NOT to all previous CPU cores parsed.
  
  My suggestion is dropping the loop in [1], thus calling the 
  and  only for currentcpu.
  
  I put together a small patch (basically removing the for loop in question)
  at [2] (or see attachement), which should be applied on top of version
  "02.16-2ubuntu1.3" from Ubuntu Trusty 14.04.
  
  After applying the patch at [2], parsing for the above system (48 cores)
  takes less than 1 second (instead of 30s), with the exact same results ...
  
  [1]
  https://github.com/lyonel/lshw/commit/beb89de5a3c10449fe73f1c77b2486d868e5bc9a
  #diff-f4010714738fa4cdd5999499579da2b3R217
  
  [2] http://paste.ubuntu.com/16456620/
  
  # lsb_release -rd
  Description:Ubuntu 14.04.4 LTS
  Release:14.04
  
  BR,
  Alex
+ 
+ [Impact] 
+ lshw takes too long time on parsing /proc/cpuinfo on aarch64 system
+ It takes minutes on 96cores and almost 10min on 224cores system.
+ 
+ [Test Case]
+ `time sudo lshw` and it shall be less then 15sec
+ 
+ [Regression Potential] 
+ This patch only affect code for aarch64. No regression possible on other 
aarch64 and has been tested on aarch64
+ 
+ [Other Info]
+ Patch has been merged into upstream branch.
+ https://github.com/lyonel/lshw/commit/20cda77239e8604e798b87a0441e694edb0214d1

** Description changed:

  lshw on AArch64 hardware is painfully slow.
  This affects both lshw in current Ubuntu releases and vanilla upstream.
  
  For a 48 core node, cpuinfo parsing added up to 30 seconds (8 lines
  per core in /proc/cpuinfo add up to 384 lines to parse).
  
  For a 96 core node, parsing took up to 5 minutes (!).
  
  I think the problem was introduced by [1], and can be summarized as:
  - CPU capabilities should be added only to the current CPU core,
    and NOT to all previous CPU cores parsed.
  
  My suggestion is dropping the loop in [1], thus calling the 
  and  only for currentcpu.
  
  I put together a small patch (basically removing the for loop in question)
  at [2] (or see attachement), which should be applied on top of version
  "02.16-2ubuntu1.3" from Ubuntu Trusty 14.04.
  
  After applying the patch at [2], parsing for the above system (48 cores)
  takes less than 1 second (instead of 30s), with the exact same results ...
  
  [1]
  https://github.com/lyonel/lshw/commit/beb89de5a3c10449fe73f1c77b2486d868e5bc9a
  #diff-f4010714738fa4cdd5999499579da2b3R217
  
  [2] http://paste.ubuntu.com/16456620/
  
  # lsb_release -rd
  Description:Ubuntu 14.04.4 LTS
  Release:14.04
  
  BR,
  Alex
  
- [Impact] 
+ [Impact]
  lshw takes too long time on parsing /proc/cpuinfo on aarch64 system
  It takes minutes on 96cores and almost 10min on 224cores system.
  
  [Test Case]
  `time sudo lshw` and it shall be less then 15sec
  
- [Regression Potential] 
- This patch only affect code for aarch64. No regression possible on other 
aarch64 and has been tested on aarch64
+ [Regression Potential]
+ This patch only affect code for aarch64. Lowest regression rick on other arch 
and has been tested on aarch64
  
  [Other Info]
  Patch has been merged into upstream branch.
  https://github.com/lyonel/lshw/commit/20cda77239e8604e798b87a0441e694edb0214d1

** Description changed:

  lshw on AArch64 hardware is painfully slow.
  This affects both lshw in current Ubuntu releases and vanilla upstream.
  
  For a 48 core node, cpuinfo parsing added up to 30 seconds (8 lines
  per core in /proc/cpuinfo add up to 384 lines to parse).
  
  For a 96 core node, parsing took up to 5 minutes (!).
  
  I think the problem was introduced by [1], and can be summarized as:
  - CPU capabilities should be added only to the current CPU core,
    and NOT to all previous CPU cores parsed.
  
  My suggestion is dropping the loop in [1], thus calling the 
  and  only for currentcpu.
  
  I put together a small patch (basically removing the for loop in question)
  at [2] (or see attachement), which should be applied on top of version
  "02.16-2ubuntu1.3" from Ubuntu Trusty 14.04.
  
  After applying the patch at [2], parsing for the above system (48 cores)
  takes less than 1 second (instead of 30s), with the exact same results ...
  
  [1]
  https://github.com/lyonel/lshw/commit/beb89de5a3c10449fe73f1c77b2486d868e5bc9a
  #diff-f4010714738fa4cdd5999499579da2b3R217
  
  [2] http://paste.ubuntu.com/16456620/
  
  # lsb_release -rd
  Description:Ubuntu 14.04.4 LTS
  Release:14.04
  
  BR,
  Alex
  
  [Impact]
  lshw takes too 

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Ike Panhc]

Thanks. Process to upload.

** Changed in: lshw (Ubuntu)
   Status: Confirmed => In Progress

** Changed in: lshw (Ubuntu)
 Assignee: (unassigned) => Ike Panhc (ikepanhc)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Alexandru Avadanii]

Upstream PR merged.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Ike Panhc]

This issue also affects me. With about 10min for lshw it nearly fails
MAAS commisioning.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Alexandru Avadanii]

I see nobody acted on this, so I sent a PR [1] upstream.
Will update this ticket if it gets pulled.

[1] https://github.com/lyonel/lshw/pull/36

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Alexandru Avadanii]

Hi,
If it helps, we have an old DEB package at [1].
I think it's based on the lshw version that was used by Trusty or Xenial at 
that time.

[1] http://linux.enea.com/mos-repos/ubuntu/10.0/pool/main/l/lshw/

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Matt Dirba]

My 200+ ARM machine fails to commission in MaaS because lshw takes 8
minutes to run.  I will try out this patch and see if it speeds up lshw.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Launchpad Bug Tracker]

Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: lshw (Ubuntu)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1582181] Re: AArch64: slow cpuinfo due to redundant loop

[Ubuntu Foundations Team Bug Bot]

The attachment "AArch64-cpuinfo-Remove-redundant-cpu-caps-loop.patch"
seems to be a patch.  If it isn't, please remove the "patch" flag from
the attachment, remove the "patch" tag, and if you are a member of the
~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by
~brian-murray, for any issues please contact him.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1582181

Title:
  AArch64: slow cpuinfo due to redundant loop

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lshw/+bug/1582181/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs