[Bug 1592786] Re: Feature: adding rte_kni kernel module as dkms

2016-08-25 Thread Launchpad Bug Tracker
This bug was fixed in the package dpdk - 16.07-0ubuntu2 --- dpdk (16.07-0ubuntu2) yakkety; urgency=medium * d/t/test-initscripts fix false positive in adt -- Christian Ehrhardt Fri, 12 Aug 2016 12:56:07 +0200 ** Changed in: dpdk (Ubuntu)

[Bug 1592786] Re: Feature: adding rte_kni kernel module as dkms

2016-06-16 Thread klnikita
It works fine here, thank you Christian! Just another suggestion, in debian/rules you have a 'RTE_MACHINE = "default"', it could be interesting to modify it by a 'RTE_MACHINE ?= "default"' since it permit to override it during a rebuild. In dpdk the default value is core2, and it is disabling

[Bug 1592786] Re: Feature: adding rte_kni kernel module as dkms

2016-06-15 Thread Ubuntu Foundations Team Bug Bot
The attachment "ubuntu-rte-kni-dkms.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by

[Bug 1592786] Re: Feature: adding rte_kni kernel module as dkms

2016-06-15 Thread ChristianEhrhardt
Hi, the following ppa has the dkms for kni built for all architectures https://launchpad.net/~paelzer/+archive/ubuntu/dpdk-merge-16.04 Could you give it a test and let me know? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1592786] Re: Feature: adding rte_kni kernel module as dkms

2016-06-15 Thread klnikita
Ok no problem. It was just a quick win patch. I also tried to do that with some dkms modifications but I didn't find a way to pass more "CFLAGS" without overriding MODULE_CFLAGS, what was not acceptable since the Makefile was already passing options through that. But I quickly switched to

[Bug 1592786] Re: Feature: adding rte_kni kernel module as dkms

2016-06-15 Thread ChristianEhrhardt
Re-assigning from upstream to Ubuntu-dev release ** Project changed: dpdk => dpdk (Ubuntu) ** Changed in: dpdk (Ubuntu) Assignee: (unassigned) => ChristianEhrhardt (paelzer) ** Changed in: dpdk (Ubuntu) Status: New => Triaged ** Changed in: dpdk (Ubuntu) Importance: Undecided =>

[Bug 1592786] Re: Feature: adding rte_kni kernel module as dkms

2016-06-15 Thread ChristianEhrhardt
Thanks for sharing - our code overall is very similar. You had missed a few renames from igb_uio, then the changelog and a few other minor things. I didn't like the quilt patch to fix up the includes - that works much more focused with a small change to the dkms conf. So I didn't need to pick

[Bug 1592786] Re: Feature: adding rte_kni kernel module as dkms

2016-06-15 Thread klnikita
For what is worth, here is the patch I would have used if you have not written yours ** Patch added: "ubuntu-rte-kni-dkms.diff" https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1592786/+attachment/4684235/+files/ubuntu-rte-kni-dkms.diff -- You received this bug notification because you