[Bug 1597598] Re: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display.
It's actually theme related, not a bug to libindicator. LP: #1622686 LP: #1657863 ** Changed in: libindicator (Ubuntu) Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1597598 Title: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libindicator/+bug/1597598/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1597598] Re: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display.
Meant to say "Pass the flag to ...". -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1597598 Title: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libindicator/+bug/1597598/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1597598] Re: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display.
Pass the to either gtk_icon_theme_lookup_by_gicon() or gtk_icon_theme_lookup_by_gicon_for_scale() does not solve the issue. FWIW, when using gtk_icon_theme_lookup_by_gicon_for_scale() with scale factor 2, the indicator-power battery icon blurred a little bit. ** Attachment added: "power.png" https://bugs.launchpad.net/ubuntu/+source/libindicator/+bug/1597598/+attachment/4693257/+files/power.png -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1597598 Title: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libindicator/+bug/1597598/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1597598] Re: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display.
Mmhmh... I don't think this is the proper solution, since it gets the scaling for the default display, not for the current one. IIRC we had a similar issue in unity that was fixed by passing GTK_ICON_LOOKUP_FORCE_SIZE as flag to gtk_icon_theme_lookup_by_gicon. Can you try that? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1597598 Title: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libindicator/+bug/1597598/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1597598] Re: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display.
Use gtk_icon_theme_lookup_by_gicon_for_scale() does not solve the issue, that's why I tried GTK commit 001598a. And I just found out that gtk_icon_theme_load_icon_for_scale() is not a good solution, because it blurs my Shutter and Skype icon. It's really weird, because I think the change didn't touch gtk2 part. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1597598 Title: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libindicator/+bug/1597598/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1597598] Re: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display.
Please resubmit this as a merge proposal against lp:libindicator. I think you should (as well as doing this) fix the earlier calls to gtk_icon_theme_lookup_by_gicon to use gtk_icon_theme_lookup_by_gicon_for_scale. What does gtk_widget_get_scale_factor on the GtkImage give you? If that's right, use that instead. Please fix the indentation to match the surrounding code. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1597598 Title: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libindicator/+bug/1597598/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1597598] Re: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display.
The attachment "hidpi.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1597598 Title: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libindicator/+bug/1597598/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1597598] Re: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display.
When using gtk_icon_theme_load_icon_for_scale() instead of gtk_icon_info_load_icon(), this issue is gone. But I suspect it's not to root cause. There's a commit in newer GTK: "001598a icon theme: Improve loading of unthemed files" which takes desired_scale into account, but cherry-pick the commit into Xenial's gtk does not solve the issue. ** Patch added: "hidpi.patch" https://bugs.launchpad.net/ubuntu/+source/libindicator/+bug/1597598/+attachment/4692577/+files/hidpi.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1597598 Title: a11y-profile-manager-indicator has wrong scale in Ubiquity with HiDPI display. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libindicator/+bug/1597598/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs