[Bug 1662027] Re: cacti vs PHP 7 vs split

[Paul Gevers]

To all those involved. I am not in the position to test Ubuntu packages
as I don't run that myself and my computer doesn't support hardware
virtualization.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Mathew Hodson]

** Changed in: cacti (Ubuntu Xenial)
   Importance: Undecided => Medium

** Changed in: cacti (Ubuntu Zesty)
   Importance: Undecided => Medium

** Changed in: cacti (Ubuntu Yakkety)
   Importance: Undecided => Medium

** Changed in: cacti (Ubuntu Artful)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Launchpad Bug Tracker]

This bug was fixed in the package cacti - 0.8.8h+ds1-8ubuntu0.1

---
cacti (0.8.8h+ds1-8ubuntu0.1) zesty; urgency=medium

  * debian/patches/enable_faster_polling_than_cron.patch: split() is
deprecated in PHP 7, causing the code to fail.  Closes: #860271,
LP: #1662027. Thanks to Paul Gevers .

 -- Nishanth Aravamudan   Fri, 14 Apr
2017 21:26:51 -0700

** Changed in: cacti (Ubuntu Artful)
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Adam Conrad]

Hello Joel, or anyone else affected,

Accepted cacti into yakkety-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/cacti/0.8.8h+ds1-5ubuntu0.1 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: cacti (Ubuntu Yakkety)
   Status: In Progress => Fix Committed

** Changed in: cacti (Ubuntu Xenial)
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1662027] Re: cacti vs PHP 7 vs split

[Nish Aravamudan]

@Paul, because I didn't think of that at the time :) Sorry!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Paul Gevers]

@Nish, why didn't you (fake-) synced cacti in Zesty, there were no other
delta's?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Adam Conrad]

Hello Joel, or anyone else affected,

Accepted cacti into zesty-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/cacti/0.8.8h+ds1-8ubuntu0.1 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: cacti (Ubuntu Zesty)
   Status: In Progress => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Nish Aravamudan]

I'm uploading the fix for x, y and z now. We can sync in aa once it's
open.

** Description changed:

+ [Impact]
+ 
+  * If the administrator configures cacti to poll data at a higher frequency
+ than the cron job that runs the poller, a fatal error is emitted.
+ 
+  * As the highest cron frequency is once per minute, one will have to
+ use this feature if higher resolution is required.
+ 
+ [Test Case]
+ 
+  * On the one hand, this is a syntactical (non-php7.0 compliant) code
+ change, so the test case feels less necessary.
+ 
+  * On the other hand, one can configure cacti to poll at a higher than
+ once-per-minute frequency, and the poller will crash with the "undefined
+ function split()".
+ 
+ [Regression Potential]
+ 
+  * Presuming an administrator does not use a higher than one-minute
+ polling frequency, there is no regression potential, as they are
+ unaffected by this codepath.
+ 
+  * If the administrator does use a higher polling frequency, they may
+ have already hit this bug and manually changed the source on their
+ system. Ideally, they will have changed it in the same way upstream has,
+ which is the backported fix in this bug -- and so when the update is
+ installed, there should be no change.
+ 
+  * If the administrator left cacti in the broken state because of this
+ bug, then it will be fixed by this change and there again, is no
+ regression potential, because the feature was broken before.
+ 
+ ---
+ 
  poller.php calls split in two places, which fails with PHP 7.  This
  seems to only actually cause problems if poller.php is configured to
  poll the snmp data sources more than once per time poller.php is called
  by cron (which typically happens if 10 second or 30 second polling
  intervals are requested), but it appears to me that these error messages
  may appear in the logs even when cacti is configured to only poll once
  per time it is called by cron.
  
  It appears that using explode instead of split is the fix.
  
- 
- 
  PHP Fatal error:  Uncaught Error: Call to undefined function split() in 
/usr/share/cacti/site/poller.php:454
  Stack trace:
  #0 {main}
-   thrown in /usr/share/cacti/site/poller.php on line 454
+   thrown in /usr/share/cacti/site/poller.php on line 454
  PHP Fatal error:  Uncaught Error: Call to undefined function split() in 
/usr/share/cacti/site/poller.php:454
  Stack trace:
  #0 {main}
-   thrown in /usr/share/cacti/site/poller.php on line 454
- 
+   thrown in /usr/share/cacti/site/poller.php on line 454
  
  Description:Ubuntu 16.04.1 LTS
  Release:16.04
  cacti:
-   Installed: 0.8.8f+ds1-4ubuntu4.16.04.1
-   Candidate: 0.8.8f+ds1-4ubuntu4.16.04.1
-   Version table:
-  *** 0.8.8f+ds1-4ubuntu4.16.04.1 500
- 500 http://us.archive.ubuntu.com/ubuntu xenial-updates/universe amd64 
Packages
- 500 http://us.archive.ubuntu.com/ubuntu xenial-updates/universe i386 
Packages
- 100 /var/lib/dpkg/status
-  0.8.8f+ds1-4ubuntu4 500
- 500 http://us.archive.ubuntu.com/ubuntu xenial/universe amd64 Packages
- 500 http://us.archive.ubuntu.com/ubuntu xenial/universe i386 Packages
+   Installed: 0.8.8f+ds1-4ubuntu4.16.04.1
+   Candidate: 0.8.8f+ds1-4ubuntu4.16.04.1
+   Version table:
+  *** 0.8.8f+ds1-4ubuntu4.16.04.1 500
+ 500 http://us.archive.ubuntu.com/ubuntu xenial-updates/universe amd64 
Packages
+ 500 http://us.archive.ubuntu.com/ubuntu xenial-updates/universe i386 
Packages
+ 100 /var/lib/dpkg/status
+  0.8.8f+ds1-4ubuntu4 500
+ 500 http://us.archive.ubuntu.com/ubuntu xenial/universe amd64 Packages
+ 500 http://us.archive.ubuntu.com/ubuntu xenial/universe i386 Packages

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Nish Aravamudan]

Once we are able to sync the package from Debian in AA, Ubuntu will have
the fix and we can SRU.

** Also affects: cacti (Ubuntu Aa-series)
   Importance: Undecided
   Status: New

** Changed in: cacti (Ubuntu Aa-series)
   Status: New => In Progress

** Changed in: cacti (Ubuntu Aa-series)
 Assignee: (unassigned) => Nish Aravamudan (nacc)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Nish Aravamudan]

** Changed in: cacti (Ubuntu Yakkety)
   Status: New => In Progress

** Changed in: cacti (Ubuntu Xenial)
   Status: New => In Progress

** Changed in: cacti (Ubuntu Zesty)
   Status: Confirmed => In Progress

** Changed in: cacti (Ubuntu Xenial)
 Assignee: (unassigned) => Nish Aravamudan (nacc)

** Changed in: cacti (Ubuntu Yakkety)
 Assignee: (unassigned) => Nish Aravamudan (nacc)

** Changed in: cacti (Ubuntu Zesty)
 Assignee: (unassigned) => Nish Aravamudan (nacc)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1662027] Re: cacti vs PHP 7 vs split

[Nish Aravamudan]

I will upload the same fix to Ubuntu tonight or tomorrow. Thanks Paul!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Bug Watch Updater]

** Changed in: cacti (Debian)
   Status: Unknown => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Paul Gevers]

Bug is now fixed in Debian and unblocked for the upcoming Stretch
release.

** Bug watch added: Debian Bug tracker #860271
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860271

** Also affects: cacti (Debian) via
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860271
   Importance: Unknown
   Status: Unknown

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Paul Gevers]

Sleeping on it another night makes sense. I understand what I was doing
wrong yesterday, I forgot to change the rrd file definition when
changing the poller interval.

Indeed, if someone wants to increase the frequency to something higher
than once per minute, cacti fails to support this currently due to this
bug.

I'll file a bug in Debian as well and will try to get a release
exception.

** Changed in: cacti (Ubuntu Zesty)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Paul Gevers]

@Nish, if you want to fix this particular issue, I don't think you need
to fix the other uses of explode. I think you could also use explode
instead of split.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Paul Gevers]

Hmm, I must also admit that I don't fully understand what this feature
is for (it doesn't seem to do what I expected).

Anybody that does now, can you explain why this should be fixed in older
releases?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Nish Aravamudan]

@Paul: I was asking mostly because the upstream changes don't
necessarily apply cleanly (the whole commit) because there seems to have
been a global move to microtime() in the source. Is that something I
should look at SRUing with this change? Or is it sufficient, in your
opinion, to just backport the diff in c#2 as a fix for this particular
issue?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Paul Gevers]

Ouch, I forgot about this issue.

@Nish: It looks like that indeed. Are you asking the last questions for
a specific reason? It is the first time I see somebody ask me such a
question from the Ubuntu side.

I must admit that I underestimated the impact of this bug, please go
ahead.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Nish Aravamudan]

@Paul,

I do see at least 6b5931130770cdfa5baa68c43a913dcabf1c3970 upstream that
fixes the split() calls in question. Is it suitable to just make those
changes in the versions in Ubuntu. Specifically:

--- cacti-0.8.8f+ds1.orig/poller.php
+++ cacti-0.8.8f+ds1/poller.php
@@ -451,11 +451,9 @@ while ($poller_runs_completed < $poller_

/* sleep the appripriate amount of time */
if ($poller_runs_completed < $poller_runs) {
-   list($micro, $seconds) = split(' ', microtime());
-   $plugin_start = $seconds + $micro;
+   $plugin_start = microtime(true);
api_plugin_hook('poller_bottom');
-   list($micro, $seconds) = split(' ', microtime());
-   $plugin_end = $seconds + $micro;
+   $plugin_end = microtime(true);
if (($sleep_time - ($plugin_end - $plugin_start)) > 0) {
usleep(($sleep_time - ($plugin_end - 
$plugin_start)) * 100);
}

Probably adjusted a bit for the various versions in the releases? Or are
more fixes from upstream needed?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Nish Aravamudan]

** Also affects: cacti (Ubuntu Zesty)
   Importance: Undecided
   Status: New

** Also affects: cacti (Ubuntu Xenial)
   Importance: Undecided
   Status: New

** Also affects: cacti (Ubuntu Yakkety)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1662027] Re: cacti vs PHP 7 vs split

[Paul Gevers]

Thanks for reporting this issue.

The code was introduced to fix issue
http://bugs.cacti.net/view.php?id=2446 in 0.8.8c.

Looks like already before that time Debian and Ubuntu replaced split()
by explode(), so that's why this one was missed.

Code is not present in the recently released upstream version 1.0.0, so
this bug will be fixed once 1.0.0 or higher is packaged for Debian and
synced to Ubuntu.

** Bug watch added: bugs.cacti.net/ #2446
   http://bugs.cacti.net/view.php?id=2446

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1662027

Title:
  cacti vs PHP 7 vs split

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cacti/+bug/1662027/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs