[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-04-12 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 1.3.1-1ubuntu10.21 --- libvirt (1.3.1-1ubuntu10.21) xenial; urgency=medium * d/p/ubuntu/lp1688508-fix-variable-scope-in-in-check_guests_shutdown.patch: backport further upstream fixes that were identified on verification. Together

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-04-12 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 3.6.0-1ubuntu6.5 --- libvirt (3.6.0-1ubuntu6.5) artful; urgency=medium * d/p/ubuntu/lp1688508-fix-variable-scope-in-in-check_guests_shutdown.patch: backport further upstream fixes that were identified on verification. Together

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-04-10 Thread ChristianEhrhardt
FYI: I've seen and resolved some autopkgtest regressions, but one will stay cockpit@arm. For that I have opened https://code.launchpad.net/~paelzer/britney/hints-ubuntu-artful-cockpit/+merge/342915 -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-04-06 Thread Dariusz Gadomski
I've just finished verification for the following versions: artful: 3.6.0-1ubuntu6.5 xenial: 1.3.1-1ubuntu10.21 No issues found in the scope of the test case (from the bug description). ** Tags removed: verification-needed-artful verification-needed-xenial ** Tags added: verification-done-artful

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-04-05 Thread Łukasz Zemczak
Hello Christoph, or anyone else affected, Accepted libvirt into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/1.3.1-1ubuntu10.21 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-04-05 Thread Łukasz Zemczak
Hello Christoph, or anyone else affected, Accepted libvirt into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/3.6.0-1ubuntu6.5 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-04-05 Thread Dariusz Gadomski
Christian, works perfectly fine here as well (tested from the ppa). I notice the "Failed to determine..." messages, but nonetheless the guests are correctly shut down in a jiffie. Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-04-05 Thread ChristianEhrhardt
Tested shutting down 40 guests with this through the service - worked fine this time. If shutdown is really really fast (like small guests on a speedy host, you might see "Failed to determine state of guest ..." but that is fine. It only means it is gone fast, we don't have to wait for it and

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-04-04 Thread ChristianEhrhardt
After identifying the former issue there are new uploads for the SRU Team to consider accepting in regard to this bug: - Artful: libvirt_3.6.0-1ubuntu6.5_source.changes - Xenial: libvirt_1.3.1-1ubuntu10.21_source.changes (This also includes a fix for 1753604) Note: test builds in

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-03-21 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 4.0.0-1ubuntu6 --- libvirt (4.0.0-1ubuntu6) bionic; urgency=medium * Backport from recent upstream to stabilize libvirt (LP: #1756915) - d/p/stable/0033-qemu-Fix-comparison-assignment-in-qemuDomainUpdateDe.patch -

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-03-21 Thread ChristianEhrhardt
The further patches I want to upstream need another round of polishing and re-submission until they can be accepted. But this one only has accepted changes, so lets unblock this issue by pushing an interim version through regression tests and upload it once good. -- You received this bug

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-03-19 Thread ChristianEhrhardt
Sorry, correct is https://libvirt.org/git/?p=libvirt.git;a=commit;h=7e476356c28a7fccd40eebbd8dac83e49e782010 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1688508 Title: libvirt-guests.sh fails

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-03-19 Thread ChristianEhrhardt
Follow on fix accepted upstream as [1]. next: need to finish a few more fixes to become one upload in Bionic. [1]: https://libvirt.org/git/?p=libvirt.git;a=commit;h=77cd862fb5e1d61922ab945f52ad94f7753704a5 -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-03-19 Thread ChristianEhrhardt
After some debugging I found why it isn't correctly iterating anymore. Note Local Branch: fix-lp1688508-guestscoping Submitted to upstream as: https://www.redhat.com/archives/libvir- list/2018-March/msg01068.html P.S. It wasn't even our fix that broke it, we just made it get further and then

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-03-19 Thread ChristianEhrhardt
list_guests lists all 6 8b5645c2-12e5-4ec7-9350-08adb3e8cb0f ef55638c-926a-4d43-9790-99aae3010951 119975ea-8d86-4114-84db-02f1f655d279 afe0321b-2deb-44c8-9cd3-727882b140b9 6d0a05d2-b40c-433e-b656-3519626dcbf3 a9224770-a4b7-4044-b4ce-2ceb934c1e4b All xenial-testshutdown-* get printed

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-03-15 Thread ChristianEhrhardt
Repro: $ uvt-simplestreams-libvirt --verbose sync --source http://cloud-images.ubuntu.com/daily arch=amd64 label=daily release=xenial $ for f in $(seq 0 40); do uvt-kvm create --memory 2048 --cpu 4 xenial-testshutdown-$f release=xenial arch=amd64 ; done Be aware of the up to 80G memory

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-03-14 Thread ChristianEhrhardt
Thanks Dariusz, TL;DR we want this to be cancelled from SRU and need to rework upstream. >From there into Bionic (which would be released that way) and from there >reconsidering SRU. Resetting Task status and verification tags. ** Tags added: 4.0.0-1ubuntu6 needs-upstreaming ** Tags removed:

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-03-14 Thread ChristianEhrhardt
TL;DR on the issue, the change upstream fixed the issue, but made some even worse issues visible. It is not yet clear if the errors came in with the change itself if they were just hidden. Needs repro, debug, fix, test, upstreaming, bionic, SRUs (in that order) -- You received this bug

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-03-13 Thread Dariusz Gadomski
log from verification on Xenial. ** Attachment added: "xenial_libvirt-guests.log.gz" https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1688508/+attachment/5078252/+files/libvirt-guests.log.gz -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-03-06 Thread ChristianEhrhardt
Sorry Christoph you are the reporter of course, but @Dariusz I'd still appreciate if you would take over the verification since it is out for some time and there is no community verification yet. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-03-06 Thread ChristianEhrhardt
Dariusz, would you mind as the reporter and Author to do the verification on this one? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1688508 Title: libvirt-guests.sh fails to shutdown guests in

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-02-28 Thread Chris J Arges
Hello Christoph, or anyone else affected, Accepted libvirt into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/1.3.1-1ubuntu10.20 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-02-27 Thread Dan Streetman
** Tags removed: sts-sponsor-ddstreet -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1688508 Title: libvirt-guests.sh fails to shutdown guests in parallel To manage notifications about this bug go

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-02-27 Thread ChristianEhrhardt
The change is in Bionic and Tested, I fixed up a minor issue in the Dep3 header that I made in Bionic. We don't have to carry that to the SRUs. Both checked and sponsored. (I needed to update my git trees for the recent security updates anyway, so I could do both at once) Please help to track

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-02-26 Thread Dan Streetman
** Tags added: sts-sponsor-ddstreet -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1688508 Title: libvirt-guests.sh fails to shutdown guests in parallel To manage notifications about this bug go

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-02-26 Thread Dariusz Gadomski
SRU proposal for Xenial. ** Patch added: "xenial_libvirt_1.3.1-1ubuntu10.20.debdiff" https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1688508/+attachment/5063490/+files/xenial_libvirt_1.3.1-1ubuntu10.20.debdiff -- You received this bug notification because you are a member of Ubuntu

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-02-26 Thread Dariusz Gadomski
SRU proposal for Artful. ** Patch added: "artful_libvirt_3.6.0-1ubuntu6.4.debdiff" https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1688508/+attachment/5063489/+files/artful_libvirt_3.6.0-1ubuntu6.4.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-02-26 Thread Dariusz Gadomski
** Changed in: libvirt (Ubuntu Zesty) Status: In Progress => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1688508 Title: libvirt-guests.sh fails to shutdown guests in parallel To

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-02-25 Thread Bug Watch Updater
** Changed in: libvirt Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1688508 Title: libvirt-guests.sh fails to shutdown guests in parallel To manage

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-02-23 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 4.0.0-1ubuntu4 --- libvirt (4.0.0-1ubuntu4) bionic; urgency=medium * d/p/ubuntu/lp1688508-tools-avoid-text-spilling-into-variables.patch: avoid hanging on shutdown (LP: #1688508) -- Christian Ehrhardt

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-02-23 Thread ChristianEhrhardt
Yep, prepared tested and uploaded to bionic-proposed now. => https://launchpad.net/ubuntu/+source/libvirt/4.0.0-1ubuntu4 ** Changed in: libvirt (Ubuntu) Status: Confirmed => In Progress ** Changed in: libvirt (Ubuntu) Assignee: Jorge Niedbalski (niedbalski) => ChristianEhrhardt

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2018-02-23 Thread Dariusz Gadomski
The patch has been accepted upstream: https://libvirt.org/git/?p=libvirt.git;a=commit;h=ff02d1af4041ea4cf6bea68aac66d93a970e92f1. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1688508 Title:

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-11-02 Thread ChristianEhrhardt
Hi Jorge, on this as I outlined before please get the change upstream. Peter (in the linked Bugzilla) took the work but might be busy with other things. Please help him to get something upstream and then think on the SRU for this. -- You received this bug notification because you are a member

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-10-31 Thread Jorge Niedbalski
For reference, with @paelzer patch applied , the following is the libvirt-guests.sh stop sequence. root@xenial-base:/usr/lib/libvirt# ./libvirt-guests.sh stop Running guests on default URI: guest-11, guest-16, guest-9, guest-19, guest-20, guest-23, guest-15, guest-29, guest-7, guest-39,

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-10-31 Thread Jorge Niedbalski
** Description changed: [Environment] No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 16.04.3 LTS Release: 16.04 Codename: xenial + [Impact] - [Impact] - - There is a bug/race condition on libvirt-guests.service, that prevents the

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-10-31 Thread Jorge Niedbalski
Hello, I've updated the bug description with the reproducer steps and details on the bug itself. I've also prepared a PPA for testing this on top of the current xenial-updates archive (https://launchpad.net/~niedbalski/+archive/ubuntu/lp1688508). I will proceed with the devel fixing and then

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-10-31 Thread Jorge Niedbalski
** Description changed: - On a brand new installation of Ubuntu Server 16.04.2 LTS the libvirt- - guests.sh script fails to shutdown my VMs if run with PARALLEL_SHUTDOWN - > 0, instead running forever thereby preventing me from shutting down my - system. I debugged the script with 'set -x' and

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-10-31 Thread Jorge Niedbalski
** Changed in: libvirt (Ubuntu) Status: Triaged => Confirmed ** Changed in: libvirt (Ubuntu) Assignee: (unassigned) => Jorge Niedbalski (niedbalski) ** Changed in: libvirt (Ubuntu Xenial) Status: New => In Progress ** Changed in: libvirt (Ubuntu Zesty) Status: New =>

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-10-31 Thread Eric Desrochers
** Also affects: libvirt (Ubuntu Artful) Importance: Undecided Status: New ** Also affects: libvirt (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: libvirt (Ubuntu Zesty) Importance: Undecided Status: New -- You received this bug notification

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-10-26 Thread Bug Watch Updater
** Changed in: libvirt Status: Unknown => In Progress ** Changed in: libvirt Importance: Unknown => Undecided -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1688508 Title:

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-06-13 Thread ChristianEhrhardt
No movement on the upstream side yet that we could pick up - or the bug was not updated? I'll stay subscribed but drop server-next now as we can't do anything in the short term. ** Tags removed: server-next -- You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-05-12 Thread ChristianEhrhardt
Thanks for reporting as I asked, I added the tracker in the bug above so this bug will get a notification (to pick something up) once peter wrote an official fix. ** Also affects: libvirt via https://bugzilla.redhat.com/show_bug.cgi?id=1450141 Importance: Unknown Status: Unknown --

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-05-11 Thread Christoph Wolff
Oops that was the wrong link, this one is correct https://bugzilla.redhat.com/show_bug.cgi?id=1450141 ** Bug watch added: Red Hat Bugzilla #1450141 https://bugzilla.redhat.com/show_bug.cgi?id=1450141 -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-05-11 Thread Christoph Wolff
I have reported the bug upstream at the RedHat Bugzilla: https://bugzilla.redhat.com/buglist.cgi?component=libvirt_id=7359452=Virtualization%20Tools -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-05-11 Thread Christoph Wolff
Hello Christian, thank you very much for your detailed response. >The default value for this is PARALLEL_SHUTDOWN=10 so everybody would run into >this issue. >I assume that there needs to be more to this than just "broken in general", so >let us try to find what it is that makes this fail for

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-05-08 Thread Ubuntu Foundations Team Bug Bot
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1688508 Title: libvirt-guests.sh fails to shutdown guests in parallel To manage notifications about this bug go to:

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-05-08 Thread ChristianEhrhardt
I'm not a big fan of the bash variable scoping in there, but sticking to the style used this might be a fix to the issue that was reported. It would be great if you could try this diff on your file and see if it resolves your issues as well. If it does please feel free to forward it as RFC on

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-05-08 Thread ChristianEhrhardt
The script itself is not special to Ubuntu but taken from upstream. And while I can see a not too complex fix adapting it in a style like "guest_is_on" to return the wanted content in a variable to avoid polluting the result with any output it should be fixed there still. As far as I was able to

[Bug 1688508] Re: libvirt-guests.sh fails to shutdown guests in parallel

2017-05-08 Thread ChristianEhrhardt
Hi Christoph and thanks for your report and thereby help to make Ubuntu better! The default value for this is PARALLEL_SHUTDOWN=10 so everybody would run into this issue. I assume that there needs to be more to this than just "broken in general", so let us try to find what it is that makes this