[Bug 1717574] Re: new llvm3.9 breaking freshclam bytecode execution
I also updated the linked clamav bug to make them aware that this is trigggered due to the additional asserts when llvm is built without -DNDEBUG. Thank you all for your help! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1717574 Title: new llvm3.9 breaking freshclam bytecode execution To manage notifications about this bug go to: https://bugs.launchpad.net/clamav/+bug/1717574/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1717574] Re: new llvm3.9 breaking freshclam bytecode execution
Looking at similar output I thought it might be the fix we added for: - https://bugs.launchpad.net/ubuntu/+source/clamav/+bug/1692073 - https://bugzilla.clamav.net/show_bug.cgi?id=11742 - https://bugzilla.clamav.net/show_bug.cgi?id=11898 But according to Marc the patch added is what upstream committed - I can't access all their bugs / changes. This change is [1]. Upstream asked to try 99.3-beta1 as there such an issue would be resolved, but that didn't turn out to help - I'd assume they meant the signal 11 issue fixed by [1] and not this new signal 6 issue. 99.3-beta1: - without [1] and with new OR old llvm build: check_bytecode.c:108:E:arithmetic:test_inflate_int:0: (after this point) Received signal 11 (Segmentation fault) See [2] for more - With [1] and new llvmbuild: check_bytecode.c:93:E:arithmetic:test_lsig_jit:0: (after this point) Received signal 6 (Aborted) See [3] for more So while it seems similar it seems to be a new issue. We have also tried a few more llvm builds (more on that in the referred LP bug). Finally we yesterday also had the theory that the addigion of -g1 had killed the former -DNDEBUG. Which would have eliminated some asserts and that is what is sending the sig 6. That was the 3.9.1-16ubuntu5 build locutus is referring to in c#31. Now this is complete and I can confirm that with this the issue is gone. Since it is already in Artful I'm setting Fix Released. [1]: zlib fix http://paste.ubuntu.com/25587433/ [2]: https://launchpadlibrarian.net/337810323/buildlog_ubuntu-artful-amd64.clamav_0.99.3~beta1+dfsg-2ubuntu1~ppa5_BUILDING.txt.gz [3]: https://launchpadlibrarian.net/337803964/buildlog_ubuntu-artful-amd64.clamav_0.99.3~beta1+dfsg-2ubuntu1~ppa4_BUILDING.txt.gz ** Bug watch added: bugzilla.clamav.net/ #11742 https://bugzilla.clamav.net/show_bug.cgi?id=11742 ** Bug watch added: bugzilla.clamav.net/ #11898 https://bugzilla.clamav.net/show_bug.cgi?id=11898 ** Also affects: llvm-toolchain-3.9 (Ubuntu) Importance: Undecided Status: New ** Changed in: clamav (Ubuntu) Status: Incomplete => Invalid ** Changed in: llvm-toolchain-3.9 (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1717574 Title: new llvm3.9 breaking freshclam bytecode execution To manage notifications about this bug go to: https://bugs.launchpad.net/clamav/+bug/1717574/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1717574] Re: new llvm3.9 breaking freshclam bytecode execution
Can anybody test llvm 3.9.1-16ubuntu5 from artful? ** Changed in: clamav (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1717574 Title: new llvm3.9 breaking freshclam bytecode execution To manage notifications about this bug go to: https://bugs.launchpad.net/clamav/+bug/1717574/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1717574] Re: new llvm3.9 breaking freshclam bytecode execution
FYI 1:3.9.1-16ubuntu4 from the current build in a-p is not working 1:3.9.1-16ubuntu2 from the same place did work So while -DNDEBUG was a nice idea, that wasn't it No reply on the upstream report yet. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1717574 Title: new llvm3.9 breaking freshclam bytecode execution To manage notifications about this bug go to: https://bugs.launchpad.net/clamav/+bug/1717574/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1717574] Re: new llvm3.9 breaking freshclam bytecode execution
>From IRC as documentation of the next steps: TL;DR: rebuild llvm with -g1 but with -DNDEBUG and retry then [09:05] LocutusOfBorg, cpaelzer: what are you trying? we are back with two one gigabyte debug builds on ppc64el and s390x, and of course the failing amd64 build [09:09] doko, -g1 is breaking clamav [09:09] -g works [09:09] I'm doing a -g -NDEBUG to see what happens [09:12] doko: bug 1717574 [09:12] bug 1717574 in clamav (Ubuntu) "new llvm3.9 breaking freshclam bytecode execution" [Medium,Confirmed] https://launchpad.net/bugs/1717574 [09:14] cpaelzer: is this upstreamed to clamav, or are we trying to change things which we don't understand? why is a change for the debug information responsible for that? [09:15] doko: I only rerun the test and found the link of the issue to llvm - there is no clamav change [09:16] doko: so nothing to upstream there that we'd know yet [09:16] doko: it is just that their bytecode worked before a certina llvm upload and fails since then [09:16] cpaelzer: did you try to rebuild clamav with the same flags as llvm? [09:17] cpaelzer: or did you try to rebuild clamav at all? [09:17] we rebuilt clamav with old and new llvm, but not change flags [09:17] none of the rebuilds had any effect [09:17] we also tried a new clamav just to be sure [09:17] but yeah, no changes in flags, except for llvm [09:18] please can you report that upstream? [09:25] cpaelzer: we can't accomodate these builds if they take too much disk space to build, and even if, each of these packages take 1 gb, that makes 4gb for every upload ... [09:28] doko: I did never say "please make them big" I'm only naively debugged a clamav crash and found that it is broken since these llvm uploads [09:28] I beg your pardon if that got to you differently [09:29] I'm reporting to clamav and will link it up [09:30] doko: if you follow the bug I linked maybe you can see what the actual root cause might be the reason for that incompatibility [09:31] cpaelzer: what is the change in compiler and linker flags? [09:32] cpaelzer, https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/costamagnagianfranco-ppa/+packages [09:32] I uploaded a new llvm with -g1 (to make doko and infra happy) and with -DNDEBUG [09:32] what I discovered, is that ppassing RELWITHDEBINFO flags, overrides the cmake default ones [09:32] and that -DNDEBUG is stripped then [09:32] so the change has probably been a side-effect of that -g1, but not directly related [09:34] I'll test that once it is built LocutusOfBorg [09:34] cpaelzer: there's nothing about this -DNDEBUG in the bug report [09:35] and then find out why clamav is relying on that ... [09:35] I discovered it some minutes ago, melding the failed amd64 and the succeeded one [09:36] because in my ppa it was good that build [09:36] you should turn on creation of debug package in your ppa if you want to simulate the builders [09:38] both enabled, build and publish [09:38] thanks for the reminder, I admit I didn't recheck it [09:47] interesting, libclamav is using some NDEBUG stuff [09:48] LocutusOfBorg: doko: I reported to clamav and linked it up in the bug [09:49] LocutusOfBorg: let me know if/once there is a build I shall try for you [09:49] configure: CXXFLAGS from llvm-config: -I/usr/lib/llvm-3.9/include -std=c++0x -gsplit-dwarf -Wl,-fuse-ld=gold -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -Werror=date-time -std=c++11 -ffunction-sections -fdata-sections -O2 -g -DNDEBUG [09:49] -fno-exceptions -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS [09:49] interestingly, clamav is getting the build flags from llvm, so a no change rebuild should change them too [09:50] and in fact this seems to happen [09:50] but you rebuilt a new clamav [09:50] also I did with a local build vs the new library and -dev packages [09:52] but clamav not picking up NDEBUG from llvm flags, means that the code ifdefs are not triggered [09:52] this means less asserts [09:53] but the clamav currently in artful uploaded by mdeslaur still built by picking -DNDEBUG up as it was before the llvm changes [09:53] I think I'll directly upload to Ubuntu this one [09:53] https://launchpadlibrarian.net/79617/buildlog_ubuntu-artful-amd64.clamav_0.99.2+dfsg-6ubuntu2_BUILDING.txt.gz [09:54] LocutusOfBorg: do you mean we have lost the -NDEBUG in llvm and those "extra" asserts might be the reason to break it now? [09:54] somewhat this is a possible reason [09:54] rebuilding makes it assert because the current llvm in artful proposed is built without [09:54] probably rebuilding it with -DNDEBUG makes it pass [09:56] LocutusOfBorg: ok, so since clamav is already built with -DNDEBUG from the old llvm builds that would mean likely no re-upload there.
[Bug 1717574] Re: new llvm3.9 breaking freshclam bytecode execution
Reported Upstream at clamav to also get their POV on it - linked the bug above. ** Bug watch added: bugzilla.clamav.net/ #11914 https://bugzilla.clamav.net/show_bug.cgi?id=11914 ** Also affects: clamav via https://bugzilla.clamav.net/show_bug.cgi?id=11914 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1717574 Title: new llvm3.9 breaking freshclam bytecode execution To manage notifications about this bug go to: https://bugs.launchpad.net/clamav/+bug/1717574/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1717574] Re: new llvm3.9 breaking freshclam bytecode execution
this is doctoring around at the wrong ends. please find out why clamav can't work with the debug information provided by -g1. Note that even that is stripped away in package builds. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1717574 Title: new llvm3.9 breaking freshclam bytecode execution To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/clamav/+bug/1717574/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1717574] Re: new llvm3.9 breaking freshclam bytecode execution
** Summary changed: - freshclam crashed with SIGABRT in __assert_fail_base() + new llvm3.9 breaking freshclam bytecode execution -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1717574 Title: new llvm3.9 breaking freshclam bytecode execution To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/clamav/+bug/1717574/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
