[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
@cjwatson: Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
@rhialto: Ah, that bit is all somewhat manual and it seems I forgot about it after uploading the release to PyPI. I've uploaded the release tarball to the LP project now too. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
Why isn't there an -1.3.3 version available at https://launchpad.net/wadllib/+download ? It is listed above as " Fix Released" in comment #13. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
This bug was fixed in the package python-wadllib - 1.3.2-3ubuntu0.18.04.1 --- python-wadllib (1.3.2-3ubuntu0.18.04.1) bionic; urgency=medium * Fix MIME encoding of binary parts (LP: #1729754). -- Colin Watson Fri, 20 Jul 2018 18:09:05 +0100 ** Changed in: python-wadllib (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
This bug was fixed in the package python-wadllib - 1.3.2-3ubuntu0.16.04.1 --- python-wadllib (1.3.2-3ubuntu0.16.04.1) xenial; urgency=medium * Fix MIME encoding of binary parts (LP: #1729754). -- Colin Watson Fri, 20 Jul 2018 18:09:05 +0100 ** Changed in: python-wadllib (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
Thanks a lot @cjwatson for your patch! :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
I followed the same procedure as in the description, using the same poc.py script. Prereq: - a xenial LXC container with -proposed packages enabled - a bionic LXC container with -proposed packages enabled Steps: 1. Connect to the Xenial container and install the following packages: python-launchpadlib python3-launchpadlib python-wadllib/xenial-proposed python3-wadllib/xenial-proposed 2. Make sure the poc.py is configured to use Python3, then: a. attach a binary file: $ APPORT_STAGING=1 ./poc.py b. attach a text file: $ APPORT_STAGING=1 ./poc.py → In both cases, the file is attached properly. It can then be downloaded and opened without problem. 3. Repeat step 2 using the poc.py in Python2 configuration 4. Repeat steps 1~3 using a Bionic container → In every cases, it worked out well for me. I attached a .tar.xz file, a .jpg file (the one attached to this issue) as well as a .json file, and in every cases I could download and open the file properly. ** Tags removed: verification-needed verification-needed-bionic verification-needed-xenial ** Tags added: verification-done verification-done-bionic verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
Hello Pierre, or anyone else affected, Accepted python-wadllib into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python- wadllib/1.3.2-3ubuntu0.16.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: python-wadllib (Ubuntu Xenial) Status: In Progress => Fix Committed ** Tags added: verification-needed-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
Hello Pierre, or anyone else affected, Accepted python-wadllib into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python- wadllib/1.3.2-3ubuntu0.18.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: python-wadllib (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
This is fixed in cosmic now, so I don't know of anything else blocking this SRU. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
This bug was fixed in the package python-wadllib - 1.3.3-1 --- python-wadllib (1.3.3-1) unstable; urgency=medium * Team upload. [ Ondřej Nový ] * Fixed VCS URL (https) * d/control: Set Vcs-* to salsa.debian.org * d/copyright: Use https protocol in Format field * d/control: Remove ancient X-Python-Version field * d/control: Remove ancient X-Python3-Version field [ Piotr Ożarowski ] * Add dh-python to Build-Depends [ Colin Watson ] * New upstream release: - Fix MIME encoding of binary parts (LP: #1729754). -- Colin Watson Fri, 20 Jul 2018 14:18:49 +0100 ** Changed in: python-wadllib (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
** Patch added: "debdiff for bionic" https://bugs.launchpad.net/ubuntu/+source/python-wadllib/+bug/1729754/+attachment/5165658/+files/python-wadllib_1.3.2-3ubuntu0.18.04.1.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
This fix isn't quite in cosmic yet, but it's in unstable (https://tracker.debian.org/pkg/python-wadllib) and just waiting for auto-sync to do its thing. I'm going to go ahead and upload this now, since I don't expect the SRU team to get round to it last thing on a Friday anyway. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
** Description changed: Tested on 16.04 and 17.10 python-launchpadlib (1.10.5-1 on 17.10) python3-launchpadlib (1.10.5-1 on 17.10) While working on porting a utility using launchpadlib from Python2 to Python3, I noticed the binary attachments were becoming unreadable. - I wrote a little proof of concept that uploads a given binary attachment - to a launchpad issue (see attachment). To use it on staging launchpad: + I've tried uploading .jpg files, .tgz files, .tar.xz files, they all + fail to open properly. + + P.S.: When a fix is available, can it be ported to Xenial? We need this + for our tools running on devices using Xenial. + + [Test Case] + I wrote a little proof of concept that uploads a given binary attachment to a launchpad issue (see attachment). To use it on staging launchpad: APPORT_STAGING=1 ./poc.py When using the exact same script with python2 (basically, replacing `python3` with `python` in the shebang line), the binary file is properly attached. That's why I think it's a bug with python3-launchpadlib. - I've tried uploading .jpg files, .tgz files, .tar.xz files, they all - fail to open properly. + [Regression Potential] + The only sensible way to fix this bug was to rewrite how wadllib does MIME-encoding of its form uploads, so it'll be important to test both text and binary uploads. - P.S.: When a fix is available, can it be ported to Xenial? We need this - for our tools running on devices using Xenial. + Launchpad only defines a few methods that use multipart/form-data, so + the regression potential is confined to those: bug.addAttachment, + distro_arch_series.setChroot, and project_release.add_file. ** Changed in: python-wadllib (Ubuntu) Status: New => Fix Committed ** Changed in: python-wadllib (Ubuntu) Importance: Undecided => High ** Changed in: python-wadllib (Ubuntu) Assignee: (unassigned) => Colin Watson (cjwatson) ** Changed in: python-wadllib (Ubuntu Xenial) Status: New => In Progress ** Changed in: python-wadllib (Ubuntu Xenial) Importance: Undecided => High ** Changed in: python-wadllib (Ubuntu Xenial) Assignee: (unassigned) => Colin Watson (cjwatson) ** Changed in: python-wadllib (Ubuntu Bionic) Status: New => In Progress ** Changed in: python-wadllib (Ubuntu Bionic) Importance: Undecided => High ** Changed in: python-wadllib (Ubuntu Bionic) Assignee: (unassigned) => Colin Watson (cjwatson) ** Patch added: "debdiff for xenial" https://bugs.launchpad.net/ubuntu/+source/python-wadllib/+bug/1729754/+attachment/5165657/+files/python-wadllib_1.3.2-3ubuntu0.16.04.1.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
1.3.3 (2018-07-20) == - Drop support for Python < 2.6. - Add tox testing support. - Implement a subset of MIME multipart/form-data encoding locally rather than using the standard library's email module, which doesn't have good handling of binary parts and corrupts bytes in them that look like line endings in various ways depending on the Python version. [bug=1729754] ** Changed in: wadllib Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1729754] Re: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad
** Also affects: python-wadllib (Ubuntu) Importance: Undecided Status: New ** Changed in: wadllib Status: In Progress => Fix Committed ** Also affects: python-wadllib (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: python-wadllib (Ubuntu Xenial) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1729754 Title: Python3 version of launchpadlib doesn't properly upload binary attachments to Launchpad To manage notifications about this bug go to: https://bugs.launchpad.net/wadllib/+bug/1729754/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
