[Bug 1732962] Re: apport uses sys.argv instead of named arguments
This bug was fixed in the package apport - 2.20.1-0ubuntu2.25 --- apport (2.20.1-0ubuntu2.25) xenial; urgency=medium * data/apport: Introduce support for non-positional arguments so we can easily extend core_pattern in the future (LP: #1732962) -- Matthieu Clemenceau Fri, 21 Aug 2020 10:24:13 -0500 ** Changed in: apport (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
This bug was fixed in the package apport - 2.20.9-0ubuntu7.18 --- apport (2.20.9-0ubuntu7.18) bionic; urgency=medium * data/apport: Introduce support for non-positional arguments so we can easily extend core_pattern in the future (LP: #1732962) -- Matthieu Clemenceau Fri, 21 Aug 2020 10:12:55 -0500 ** Changed in: apport (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
Verification completed on both bionic and xenial using proposed pockets ** Tags removed: verification-needed verification-needed-bionic verification-needed-xenial ** Tags added: verification-done verification-done-bionic verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
Hello Brian, or anyone else affected, Accepted apport into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apport/2.20.9-0ubuntu7.18 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: apport (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-bionic ** Changed in: apport (Ubuntu Xenial) Status: In Progress => Fix Committed ** Tags added: verification-needed-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
** Description changed:
SRU Description
[Impact]
- data/apport which processes core files expects a certain quantity of
arguments in a specific order. This ended up causing an issue with some
security updates where we were trying to support a new version of apport on a
host system and one inside a container.
+ data/apport which processes core files expects a certain quantity of
arguments in a specific order. This ended up causing an issue with some
security updates where we were trying to support a new version of apport on a
host system and one inside a container.
This SRU for xenial and bionic based on the work made in cosmic enabled
proper handling of named argument.
Note that this is disabled for now on ALL series
-
+
[Test Case]
No real test here since apport general behavior should be unchanged Just to
check that the feature is disable, /proc/sys/kernel/core_pattern
content should remain unchanged :
$> cat /proc/sys/kernel/core_pattern
|/usr/share/apport/apport %p %s %c %d %P %E
[Regression Potential]
- The new feature is not enabled so the regression risk is fairly low. this
will take place in a future coordinated SRU across all LTS but in the meanwhile
we can make sure that there's no regression by running apport with various
+ The new feature is not enabled so the regression risk is fairly low. this
will take place in a future coordinated SRU across all LTS but in the meanwhile
we can make sure that there's no regression by making sure apport still behave
properly. starting and killing xeyes should trigger apport normal operation
+ $> xeyes &
+ $> kill -SEGV $!
End SRU Description
data/apport which processes core files expects a certain quantity of
arguments in a specific order. This ended up causing an issue with some
security updates where we were trying to support a new version of apport
on a host system and one inside a container. Here's something of an
example:
347 # Normal startup
348 if len(sys.argv) not in (5, 6):
349 try:
350 print('Usage: %s [global pid]' % sys.argv[0])
351 print('The core dump is read from stdin.')
We could not maintain backwards compatibility because "global pid" is an
optional argument and "dump mode" was a new argument. So if there were
five arguments its possible the last one was "dump mode" (no global pid)
or "global pid" (no support for dump mode).
Its possible to use strings in /proc/sys/kernel/core_pattern so we could
use those and have apport accept named arguments e.g:
$ cat /proc/sys/kernel/core_pattern
|/usr/share/apport/apport --pid=%p --signal=%s --core-size=%c --dump-mode=%d
--global-pid=%P
['/home/bdmurray/source-trees/apport/artful/data/apport', '--pid=5870',
'--signal=11', '--core-size=0', '--dump-mode=1', '--global-pid=5870']
Tyler said "that's probably a nice cleanup to make no matter what
because the magic arg ordering is dangerous".
** Description changed:
SRU Description
[Impact]
data/apport which processes core files expects a certain quantity of
arguments in a specific order. This ended up causing an issue with some
security updates where we were trying to support a new version of apport on a
host system and one inside a container.
This SRU for xenial and bionic based on the work made in cosmic enabled
proper handling of named argument.
Note that this is disabled for now on ALL series
[Test Case]
No real test here since apport general behavior should be unchanged Just to
check that the feature is disable, /proc/sys/kernel/core_pattern
content should remain unchanged :
$> cat /proc/sys/kernel/core_pattern
|/usr/share/apport/apport %p %s %c %d %P %E
[Regression Potential]
- The new feature is not enabled so the regression risk is fairly low. this
will take place in a future coordinated SRU across all LTS but in the meanwhile
we can make sure that there's no regression by making sure apport still behave
properly. starting and killing xeyes should trigger apport normal operation
+ The new feature is not enabled so the regression risk is fairly low. this
will take place in a future coordinated SRU across all LTS but in the meanwhile
we can make sure that there's no regression by making sure apport still behave
properly. starting and killing xeyes should trigger apport normal operation and
start apport.
$> xeyes &
$> kill -SEGV $!
End SRU Description
data/apport which processes core files expects a certain quantity of
arguments in a specific order. This ended up causing an issue with some
security updates where we were trying to support a new version of apport
on a host system and one inside a container. Here's something of an
example:
347 # Normal startup
348 if len(sys.argv) not in (5, 6):
349 try:
350 print('Usage: %s [global pid]' % sys.argv[0])
351 print('The core dump is read from stdin.')
We
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
Also sponsored for xenial. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
Sponsored for bionic. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
** Patch removed: "diff for xenial to support named param. (backport from cosmic)" https://bugs.launchpad.net/apport/+bug/1732962/+attachment/5405275/+files/apport_2.20.1-0ubuntu2.25.debdiff ** Patch removed: "diff for bionic to support named param. (backport from cosmic)" https://bugs.launchpad.net/apport/+bug/1732962/+attachment/5405276/+files/apport_2.20.9-0ubuntu7.18.debdiff ** Patch added: "diff for xenial to support named param. (backport from cosmic)" https://bugs.launchpad.net/apport/+bug/1732962/+attachment/5413348/+files/apport_2.20.1-0ubuntu2.25.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
Updated debdiff and made sure autopkgtest were successful on both xenial and bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
** Patch added: "diff for bionic to support named param. (backport from cosmic)" https://bugs.launchpad.net/apport/+bug/1732962/+attachment/5413349/+files/apport_2.20.9-0ubuntu7.18.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
I'll go ahead and sponsor these today. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
** Description changed:
+ SRU Description
+
+ [Impact]
+ data/apport which processes core files expects a certain quantity of
arguments in a specific order. This ended up causing an issue with some
security updates where we were trying to support a new version of apport on a
host system and one inside a container.
+ This SRU for xenial and bionic based on the work made in cosmic enabled
proper handling of named argument.
+ Note that this is disabled for now on ALL series
+
+ [Test Case]
+ No real test here since apport general behavior should be unchanged Just to
check that the feature is disable, /proc/sys/kernel/core_pattern
+ content should remain unchanged :
+
+ $> cat /proc/sys/kernel/core_pattern
+ |/usr/share/apport/apport %p %s %c %d %P %E
+
+ [Regression Potential]
+ The new feature is not enabled so the regression risk is fairly low. this
will take place in a future coordinated SRU across all LTS but in the meanwhile
we can make sure that there's no regression by running apport with various
+
+ End SRU Description
+
data/apport which processes core files expects a certain quantity of
arguments in a specific order. This ended up causing an issue with some
security updates where we were trying to support a new version of apport
on a host system and one inside a container. Here's something of an
example:
347 # Normal startup
348 if len(sys.argv) not in (5, 6):
349 try:
350 print('Usage: %s [global pid]' % sys.argv[0])
351 print('The core dump is read from stdin.')
We could not maintain backwards compatibility because "global pid" is an
optional argument and "dump mode" was a new argument. So if there were
five arguments its possible the last one was "dump mode" (no global pid)
or "global pid" (no support for dump mode).
Its possible to use strings in /proc/sys/kernel/core_pattern so we could
use those and have apport accept named arguments e.g:
$ cat /proc/sys/kernel/core_pattern
|/usr/share/apport/apport --pid=%p --signal=%s --core-size=%c --dump-mode=%d
--global-pid=%P
['/home/bdmurray/source-trees/apport/artful/data/apport', '--pid=5870',
'--signal=11', '--core-size=0', '--dump-mode=1', '--global-pid=5870']
Tyler said "that's probably a nice cleanup to make no matter what
because the magic arg ordering is dangerous".
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1732962
Title:
apport uses sys.argv instead of named arguments
To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
** Changed in: apport (Ubuntu Xenial) Status: New => In Progress ** Changed in: apport (Ubuntu Bionic) Status: New => In Progress ** Patch added: "diff for xenial to support named param. (backport from cosmic)" https://bugs.launchpad.net/apport/+bug/1732962/+attachment/5405275/+files/apport_2.20.1-0ubuntu2.25.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
** Patch added: "diff for bionic to support named param. (backport from cosmic)" https://bugs.launchpad.net/apport/+bug/1732962/+attachment/5405276/+files/apport_2.20.9-0ubuntu7.18.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
** Changed in: apport (Ubuntu Trusty) Status: New => Fix Committed ** Changed in: apport (Ubuntu Trusty) Status: Fix Committed => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
** Changed in: apport (Ubuntu Cosmic) Status: New => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
This bug was fixed in the package apport - 2.20.10-0ubuntu23 --- apport (2.20.10-0ubuntu23) disco; urgency=medium * Fix python coding style issue introduced in previous upload. -- Julian Andres Klode Tue, 05 Mar 2019 10:35:17 +0100 ** Changed in: apport (Ubuntu Disco) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1732962] Re: apport uses sys.argv instead of named arguments
** Also affects: apport (Ubuntu) Importance: Undecided Status: New ** Changed in: apport (Ubuntu) Status: New => Fix Committed ** Changed in: apport Status: In Progress => Fix Committed ** Also affects: apport (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: apport (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: apport (Ubuntu Disco) Importance: Undecided Status: Fix Committed ** Also affects: apport (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: apport (Ubuntu Cosmic) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1732962 Title: apport uses sys.argv instead of named arguments To manage notifications about this bug go to: https://bugs.launchpad.net/apport/+bug/1732962/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
