[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
** Changed in: maas Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
** Changed in: maas Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
** Merge proposal linked: https://code.launchpad.net/~d0ugal/maas/+git/maas/+merge/393043 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
** Changed in: maas Assignee: (unassigned) => Dougal Matthews (d0ugal) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
** Changed in: maas Milestone: 2.9.0b7 => 2.9.0b8 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
** Changed in: maas Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
@MAAS - let's monkey patch Twisted with the fix from upstream ** Changed in: maas Milestone: 2.4.x => 2.9.0b7 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
With this test package I want to see if the 'traceback' will disapear and if this will also solve the MAAS UI telling "X rack controllers are not yet connected to the region. Visit the rack controllers page for more information" despite that everything else look good (network, firewall rules, nc test, ...) With that test package we will be able to see if it's 2 separate situations or if they have this bug in common as the culprit. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
** Description changed: - When lastest master just moving around the UI caused a wierd stacktrace. - It didn't seem to affect the experience of using MAAS, but needs to be - looked into. + [Impact] + + Web http/wsgi doesn't fail gracefully when the client closes the + connection, causing 'Traceback' in MAAS /var/log/maas/rackd.log as + follows: + + + File "/usr/lib/python3/dist-packages/twisted/python/failure.py", line 385, in raiseException + raise self.value.with_traceback(self.tb) + builtins.AttributeError: 'NoneType' object has no attribute 'writeHeaders' + + File "/usr/lib/python3/dist-packages/twisted/web/http.py", line 1474, in loseConnection + self.channel.loseConnection() + builtins.AttributeError: 'NoneType' object has no attribute 'loseConnection' + + + [Test Case] + + [Regression Potential] + + [Other Information] + + * Upstream bug: + https://twistedmatrix.com/trac/ticket/9410 + + * Upstream fix: + https://github.com/twisted/twisted/commit/169fd1d93b7af06bf0f6893b193ce19970881868 + + # git describe --contains 169fd1d93b + twisted-19.7.0~20^2~13 + + # rmadison + => python3-twisted | 17.9.0-2ubuntu0.1 | bionic-updates | all + => python3-twisted | 18.9.0-11 | focal | all + => python3-twisted | 18.9.0-11 | groovy | all + + [Original Description] + When latest master just moving around the UI caused a wierd stacktrace. It didn't seem to affect the experience of using MAAS, but needs to be looked into. 2018-01-08 15:33:45 -: [critical] WSGI application error - Traceback (most recent call last): - File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 122, in callWithContext - return self.currentContext().callWithContext(ctx, func, *args, **kw) - File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 87, in callWithContext - self.contexts.pop() - File "/usr/lib/python3/dist-packages/provisioningserver/utils/twisted.py", line 875, in callInContext - return func(*args, **kwargs) - File "/usr/lib/python3/dist-packages/twisted/web/wsgi.py", line 522, in run - self.started = True - --- --- - File "/usr/lib/python3/dist-packages/twisted/web/wsgi.py", line 500, in run - self.write(elem) - File "/usr/lib/python3/dist-packages/twisted/web/wsgi.py", line 455, in write - self.reactor, wsgiWrite, self.started) - File "/usr/lib/python3/dist-packages/twisted/internet/threads.py", line 122, in blockingCallFromThread - result.raiseException() - File "/usr/lib/python3/dist-packages/twisted/python/failure.py", line 385, in raiseException - raise self.value.with_traceback(self.tb) - builtins.AttributeError: 'NoneType' object has no attribute 'writeHeaders' - + Traceback (most recent call last): + File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 122, in callWithContext + return self.currentContext().callWithContext(ctx, func, *args, **kw) + File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 87, in callWithContext + self.contexts.pop() + File "/usr/lib/python3/dist-packages/provisioningserver/utils/twisted.py", line 875, in callInContext + return func(*args, **kwargs) + File "/usr/lib/python3/dist-packages/twisted/web/wsgi.py", line 522, in run + self.started = True + --- --- + File "/usr/lib/python3/dist-packages/twisted/web/wsgi.py", line 500, in run + self.write(elem) + File "/usr/lib/python3/dist-packages/twisted/web/wsgi.py", line 455, in write + self.reactor, wsgiWrite, self.started) + File "/usr/lib/python3/dist-packages/twisted/internet/threads.py", line 122, in blockingCallFromThread + result.raiseException() + File "/usr/lib/python3/dist-packages/twisted/python/failure.py", line 385, in raiseException + raise self.value.with_traceback(self.tb) + builtins.AttributeError: 'NoneType' object has no attribute 'writeHeaders' + 2018-01-08 15:33:45 -: [critical] WSGI application error - Traceback (most recent call last): - File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 122, in callWithContext - return self.currentContext().callWithContext(ctx, func, *args, **kw) - File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 87, in callWithContext - self.contexts.pop() - File "/usr/lib/python3/dist-packages/provisioningserver/utils/twisted.py", line 875, in callInContext - return func(*args, **kwargs) - File "/usr/lib/python3/dist-packages/twisted/web/wsgi.py", line 522, in run - self.started = True - --- --- - File "/usr/lib/python3/dist-packages/twisted/web/wsgi.py", line 500, in run - self.write(elem) - File "/usr/lib/python3/dist-packages/twisted/web/wsgi.py", line 455, in write -
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
# Test package available on my PPA: sudo add-apt-repository ppa:slashd/sf294743 sudo apt-get update -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: twisted (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
** Changed in: twisted (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
** Tags added: seg sts -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
https://twistedmatrix.com/trac/ticket/9410 ** Also affects: twisted (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
It also seems like this has the effect for the impacted user I'm currently helping to always have this message in the UI: "X rack controllers are not yet connected to the region. Visit the rack controllers page for more information". -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1741913] Re: [master] Twisted seems to not handle disconnect from client correctly
https://github.com/twisted/twisted/commit/169fd1d93b7af06bf0f6893b193ce19970881868 # git describe --contains 169fd1d93b twisted-19.7.0~20^2~13 # rmadison python3-twisted | 17.9.0-2ubuntu0.1 | bionic-updates | all python3-twisted | 18.9.0-11 | focal | all python3-twisted | 18.9.0-11 | groovy | all -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1741913 Title: [master] Twisted seems to not handle disconnect from client correctly To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1741913/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
