[Bug 1753604] Re: libvirt-bin nwfilter deadlock

2018-04-12 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 1.3.1-1ubuntu10.21 --- libvirt (1.3.1-1ubuntu10.21) xenial; urgency=medium * d/p/ubuntu/lp1688508-fix-variable-scope-in-in-check_guests_shutdown.patch: backport further upstream fixes that were identified on verification. Together

[Bug 1753604] Re: libvirt-bin nwfilter deadlock

2018-04-09 Thread Pooja Ghumre
Thanks Christian and Łukasz for fixing this issue! I will update our tests to use this new package and let you know if the issue persists. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1753604 Title:

[Bug 1753604] Re: libvirt-bin nwfilter deadlock

2018-04-09 Thread ChristianEhrhardt
As I said this is hard to test explicitly. The issue is between instantiating and destroying nwfilters. So to stress the area of the code I created a test: 1. run a guest (bionic in my case, but it doesn't matter) 2. prep hotpluggable interfaces with deep nwfilter rules Clean-traffic reference

[Bug 1753604] Re: libvirt-bin nwfilter deadlock

2018-04-05 Thread Łukasz Zemczak
Hello Pooja, or anyone else affected, Accepted libvirt into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/1.3.1-1ubuntu10.21 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https:

[Bug 1753604] Re: libvirt-bin nwfilter deadlock

2018-04-04 Thread ChristianEhrhardt
Start/Stop-Looped a bunch of guests with extra nwfilters, but as I mentioned in the SRU Template it is inherently racy and so far never triggered for me. So this isn't a full verification, but more a sanity check. Regression tests good as well, moving it to x-unapproved for the SRU Team to consid

[Bug 1753604] Re: libvirt-bin nwfilter deadlock

2018-04-04 Thread ChristianEhrhardt
SRU Template added. Fix checked by regressions tests against ppa, ready for SRU considerarion. - Xenial: libvirt_1.3.1-1ubuntu10.21_source.changes (This also includes a fix for 1688508) Note: test builds in https://launchpad.net/~ci-train-ppa- service/+archive/ubuntu/3224 Regression tests start

[Bug 1753604] Re: libvirt-bin nwfilter deadlock

2018-04-04 Thread ChristianEhrhardt
** Description changed: + [Impact] + + * Fix a potential deadlock + + * The trigger is essentially a race, so it is rare and repro unreliable + + [Test Case] + + * This is the hard part for this issue, essentially changing NWFilters +through libvirt. The reporter hits it on removing a

[Bug 1753604] Re: libvirt-bin nwfilter deadlock

2018-04-04 Thread ChristianEhrhardt
I tried loop-killing VMs also with some extra filters, but there is no reliable "this is how you trigger it" for this case. As initially reported it "intermittently" fails. That will make the SRU template a bit thin on test steps. Never the less the fix is correct and makes sense. So running the

[Bug 1753604] Re: libvirt-bin nwfilter deadlock

2018-03-06 Thread Pooja Ghumre
Thanks Christian! Right, we were building libvirt from upstream 1.3.5 source code for ubuntu14 earlier, however that same build procedure didn't seem to work for ubuntu16. Hence the need for backporting it to xenial/trusty, so that we can use the libvirt packages available from ubuntu repo directl

[Bug 1753604] Re: libvirt-bin nwfilter deadlock

2018-03-06 Thread ChristianEhrhardt
Thanks for the report Pooja, this is fixed in v1.3.5 By that this in anything newer than Xenial via being upstream. I need to take a look at backporting the suggested change to Xenial, but that will probably not happen this week as I'm traveling. ** Also affects: libvirt (Ubuntu Xenial) Impo