[Bug 1802138] Re: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating
Fixed upstream: https://gitlab.xfce.org/xfce/xfce4-session/-/commit/e4312c4983678b8bf8d0ab475700e95528a62ec5 ** Changed in: xfce4-session (Ubuntu) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1802138 Title: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating To manage notifications about this bug go to: https://bugs.launchpad.net/xfce4-session/+bug/1802138/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1802138] Re: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating
** Bug watch added: Xfce Bugzilla #10217 https://bugzilla.xfce.org/show_bug.cgi?id=10217 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1802138 Title: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating To manage notifications about this bug go to: https://bugs.launchpad.net/xfce4-session/+bug/1802138/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1802138]
Maybe some implementations of sleep do not allow non-integer number argument. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1802138 Title: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating To manage notifications about this bug go to: https://bugs.launchpad.net/xfce4-session/+bug/1802138/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1802138]
Created attachment 9348 improved xflock4 Note that even this improved xflock4 script never gets past xfce4 -screensaver-command, because of bug 15945 which should be fixed ASAP. That is, if xfce4-screensaver is installed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1802138 Title: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating To manage notifications about this bug go to: https://bugs.launchpad.net/xfce4-session/+bug/1802138/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1802138]
I do not see a problem in having even longer delay than a second. But, using "sleep 1; xset dpms force off" has still the problem that user may accidentally touch something so that display will become on again. Besides, it effectively disables Presentation mode user may have set using Power manager's panel item. A better solution would be to change DPMS settings for the time such a screen locker is running to enable turning display off after reasonable time of inactivity from user, and restore previous settings, when user unlocks. This is possible by using a wrapper script. I have actually introduced such a version of xflock4 in bug report https://bugzilla.xfce.org/show_bug.cgi?id=10217 attachment https://bugzilla.xfce.org/attachment.cgi?id=7254 in 2017. It uses 15 second delay, but an initial delay of 1 second could be added. That script has other modifications such as added screensavers and lockers and optionally using display power management for the locker user may have set in Xfconf. The script can be simplified notably, if hacking the DPMS settings for general lock command set in Xfconf is left out. I have never got any feedback about the script. Note: proper screensavers (that have a daemon running when lock command is called) should handle DPMS by themselves. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1802138 Title: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating To manage notifications about this bug go to: https://bugs.launchpad.net/xfce4-session/+bug/1802138/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1802138]
@Simon: apologies, if your previous comment is directed at me. I'm currently on Ubuntu 19.04(Gnome 3) without a proper XFCE4 installation to test this on. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1802138 Title: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating To manage notifications about this bug go to: https://bugs.launchpad.net/xfce4-session/+bug/1802138/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1802138]
@Chris: Does a sleep of <1sec also work? I personally side with Steve regarding the excessive nature of adding a full second. Otherwise I'm ok with merging this patch. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1802138 Title: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating To manage notifications about this bug go to: https://bugs.launchpad.net/xfce4-session/+bug/1802138/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1802138] Re: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating
Launchpad has imported 13 comments from the remote bug at https://bugzilla.xfce.org/show_bug.cgi?id=11491. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2015-01-31T13:03:53+00:00 Chris Bainbridge wrote: As noted at http://www.shallowsky.com/linux/x-screen-blanking.html calls to "xset dpms" need to be prefixed with "sleep 1": will blank the screen (or activate the screensaver program, if you're using one) after a delay of one second. You need the delay because X gets a little confused about the order of events; it will blank the screen but immediate un-blank it, thinking the activity of your typing the command happened recently enough to come out of screensaver mode. sleep 1; xset dpms force off will turn the screen OFF after a delay of one second. You can also use standby, suspend, or on instead of off. Downstream bug report: https://bugs.debian.org/cgi- bin/bugreport.cgi?bug=776674 Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-session/+bug/1802138/comments/0 On 2015-02-08T12:50:49+00:00 Chris Bainbridge wrote: Created attachment 5915 xflock4-sleep.patch Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-session/+bug/1802138/comments/1 On 2015-02-08T17:07:02+00:00 Steve Dodier-Lazaro wrote: I can reproduce the issue, but the patch does not work for me (Xfce 4.11, ArchLinux 64 bits, xscreensaver 5.32). @OP, what screensaver do you use, and does the patch work for you? @Other triagers, could you please test the patch? Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-session/+bug/1802138/comments/2 On 2015-02-08T20:27:28+00:00 Chris Bainbridge wrote: @Steve Yes the patch works for me using slock. What exactly fails for you? Does "sleep 1; xset dpms force off" successfully turn off the monitors on your system? Do you have one of {xscreensaver-command,light-locker-command,gnome-screensaver-command} installed? If so, the xset dpms line in xflock4 is never executed. (can't seem to change bug status back from needinfo..) Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-session/+bug/1802138/comments/3 On 2015-02-08T20:36:33+00:00 Steve Dodier-Lazaro wrote: Hi Chris, When I type xset dpms force off in a terminal, my screen is turned off. Xflock4, with or without delay, always fails to turn my screen off. I believe the screensaver is the culprit, it probably talks to the X11 server and causes it to wake up. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-session/+bug/1802138/comments/4 On 2015-02-08T20:38:11+00:00 Steve Dodier-Lazaro wrote: Errata; after uninstalling xscreensaver, the patch still does not work. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-session/+bug/1802138/comments/5 On 2015-02-08T21:15:53+00:00 Chris Bainbridge wrote: Can you try "slock & sleep 1; xset dpms force off" Also try "sh -x /usr/bin/xflock4" and see if the xset line is actually being executed. It won't be if you have xscreensaver, light-locker or gnome-screensaver installed. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-session/+bug/1802138/comments/6 On 2015-02-12T02:20:22+00:00 Steve Dodier-Lazaro wrote: Ok, I've been a bit silly on that one. So, when having slock installed I reach this code path. With the patch: 1 second delay, then a black screen Without the patch: black screen immediately Now, on desktops, when using a mouse, it's quite easy to trigger the mouse after the screen has been forced off. Still, a whole second is a bit excessive. I'd like more developers to weight in before applying the patch. Reply at: https://bugs.launchpad.net/ubuntu/+source/xfce4-session/+bug/1802138/comments/7 On 2015-02-12T02:21:19+00:00 Steve Dodier-Lazaro wrote: Chris, thanks for writing the patch and bearing with me though. Of course if you can link to others complaining about the issue, and to more precise reasons why it is systematically happening for you, it'll increase the odds of people weighing in favour of your pat
[Bug 1802138] Re: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating
The attachment "sleep added." seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1802138 Title: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating To manage notifications about this bug go to: https://bugs.launchpad.net/xfce4-session/+bug/1802138/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1802138] Re: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating
** Bug watch added: Xfce Bugzilla #11491 https://bugzilla.xfce.org/show_bug.cgi?id=11491 ** Also affects: xfce4-session via https://bugzilla.xfce.org/show_bug.cgi?id=11491 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1802138 Title: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating To manage notifications about this bug go to: https://bugs.launchpad.net/xfce4-session/+bug/1802138/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1802138] [NEW] xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating
Public bug reported: Without a 'sleep 1' before +dpms command, slock or xtrlock, etc. will cause a laptop backlight to immediately reactivate. description: Notebook product: 4180AP3 vendor: LENOVO version: ThinkPad T420 *-firmware description: BIOS vendor: LENOVO physical id: d version: 83ET82WW (1.52 ) date: 06/04/2018 size: 128KiB capacity: 8128KiB capabilities: pci pnp upgrade shadowing cdboot bootselect edd int13floppy720 int5printscreen int9keyboard int14serial int17printer int10video acpi usb biosbootspecification *-display description: VGA compatible controller product: 2nd Generation Core Processor Family Integrated Graphics Controller vendor: Intel Corporation physical id: 2 bus info: pci@:00:02.0 version: 09 width: 64 bits clock: 33MHz capabilities: msi pm vga_controller bus_master cap_list rom configuration: driver=i915 latency=0 resources: irq:26 memory:f000-f03f memory:e000-efff ioport:4000(size=64) memory:c-d ProblemType: Bug DistroRelease: Ubuntu 18.10 Package: xfce4-session 4.12.1-3ubuntu4 [modified: usr/bin/xflock4] ProcVersionSignature: Ubuntu 4.18.0-10.11-generic 4.18.12 Uname: Linux 4.18.0-10-generic x86_64 ApportVersion: 2.20.10-0ubuntu13 Architecture: amd64 CurrentDesktop: XFCE Date: Wed Nov 7 10:11:37 2018 InstallationDate: Installed on 2018-11-04 (2 days ago) InstallationMedia: Xubuntu 18.10 "Cosmic Cuttlefish" - Release amd64 (20181017.2) SourcePackage: xfce4-session UpgradeStatus: No upgrade log present (probably fresh install) ** Affects: xfce4-session (Ubuntu) Importance: Undecided Status: New ** Tags: amd64 apport-bug cosmic intel xubuntu ** Patch added: "sleep added." https://bugs.launchpad.net/bugs/1802138/+attachment/5210073/+files/xflock4.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1802138 Title: xflock4 needs a 'sleep 1' before 'xset dpms force off' to prevent backlight from immediately reactivating To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/xfce4-session/+bug/1802138/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs