[Bug 1833586] Re: open-iscsi unconditionally requires ib_iser module which is not built on all Ubuntu kernels

2019-06-28 Thread Steve Langasek
While I do believe the change is PROBABLY safe, I don't think it's particularly justifiable as an SRU. Degraded mode is ugly but aside from masking other bugs, doesn't make a difference at runtime. -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1833586] Re: open-iscsi unconditionally requires ib_iser module which is not built on all Ubuntu kernels

2019-06-28 Thread Łukasz Zemczak
Looking at this from the perspective of the pi images - should we maybe consider SRUing this down to bionic for the upcoming point-release? Currently it's one of the reasons of running in systemd state degraded in pi's, might be nice to finally have a clean situation. The change looks SRUable.

[Bug 1833586] Re: open-iscsi unconditionally requires ib_iser module which is not built on all Ubuntu kernels

2019-06-21 Thread Francis Ginther
** Tags added: id-5c5053cad3efa20de8138de0 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1833586 Title: open-iscsi unconditionally requires ib_iser module which is not built on all Ubuntu kernels

[Bug 1833586] Re: open-iscsi unconditionally requires ib_iser module which is not built on all Ubuntu kernels

2019-06-21 Thread Christian Ehrhardt 
Glad to find this discussed and solved already when waking up - thanks Ryan and Steve! To complete the discussions I'm adding a little reference as on IRC it seemed this question was left open: "[20:40] rharper: right, I also fundamentally question why the open-iscsi package should hard-code

[Bug 1833586] Re: open-iscsi unconditionally requires ib_iser module which is not built on all Ubuntu kernels

2019-06-20 Thread Launchpad Bug Tracker
This bug was fixed in the package open-iscsi - 2.0.874-7.1ubuntu2 --- open-iscsi (2.0.874-7.1ubuntu2) eoan; urgency=medium * debian/open-iscsi.kmod: drop; no static module list is needed if we let iscsid load modules itself. LP: #1833586. * debian/extra/initramfs.hook: add

[Bug 1833586] Re: open-iscsi unconditionally requires ib_iser module which is not built on all Ubuntu kernels

2019-06-20 Thread Steve Langasek
** Changed in: open-iscsi (Ubuntu) Status: New => Fix Committed ** Changed in: open-iscsi (Ubuntu) Assignee: (unassigned) => Steve Langasek (vorlon) ** Changed in: open-iscsi (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member

[Bug 1833586] Re: open-iscsi unconditionally requires ib_iser module which is not built on all Ubuntu kernels

2019-06-20 Thread Steve Langasek
Except the upstream build system doesn't actually do anything reasonable wrt libkmod; so instead let's just fall back to letting iscsid modprobe the modules (which it will also do when it needs to). -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1833586] Re: open-iscsi unconditionally requires ib_iser module which is not built on all Ubuntu kernels

2019-06-20 Thread Steve Langasek
After discussing with Ryan on IRC: - the static loading of the modules is bad, and shouldn't be necessary, as it should be possible to figure out at runtime which transports are actually needed by iscsid - the current implementation doesn't work in the initramfs at all since the file it