[Bug 1838245] Re: dkms script is missing function find_module

2019-11-25 Thread Mathew Hodson
** Tags removed: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838245 Title: dkms script is missing function find_module To manage notifications about this bug go to:

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-21 Thread Launchpad Bug Tracker
This bug was fixed in the package dkms - 2.6.1-4ubuntu2.5 --- dkms (2.6.1-4ubuntu2.5) disco; urgency=medium * cherry-pick from upstream b957799 for LP: #1838245 -- Alex Tu Thu, 07 Nov 2019 15:37:47 +0800 ** Changed in: dkms (Ubuntu Disco) Status: Fix Committed => Fix

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-21 Thread Alex Tu
** Changed in: dkms Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838245 Title: dkms script is missing function find_module To manage notifications about

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-21 Thread Launchpad Bug Tracker
This bug was fixed in the package dkms - 2.7.1-4ubuntu2.1 --- dkms (2.7.1-4ubuntu2.1) eoan; urgency=medium * cherry-pick from upstream b957799 for LP: #1838245 -- Alex Tu Thu, 07 Nov 2019 15:17:48 +0800 ** Changed in: dkms (Ubuntu Eoan) Status: Fix Committed => Fix

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-11 Thread Alex Tu
for disco dkms 2.6.1-4ubuntu2.5: + confirmed the patch is there on proposed package + verified version-override - verbose installation message : http://paste.ubuntu.com/p/PQJXKWSZRC/ + verified obseleted-by - verbose installation message : http://paste.ubuntu.com/p/FrMJFz8KYK/ +

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-11 Thread Alex Tu
for eoan dkms 2.7.1-4ubuntu2.1: + confirmed the patch is there on proposed package + verified version-override - verbose installation message : http://paste.ubuntu.com/p/YyFBZkhQBR/ + verified obseleted-by - verbose installation message : http://paste.ubuntu.com/p/DvFHkRmrCf/ + verified

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-08 Thread Brian Murray
Hello Alex, or anyone else affected, Accepted dkms into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dkms/2.7.1-4ubuntu2.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-07 Thread Alex Tu
This patch is not needed for Focal as it got the existed patch from upstream. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838245 Title: dkms script is missing function find_module To manage

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-07 Thread Alex Tu
Thanks to the sponsor, the patched dkms for eoan is on the queue: https://launchpad.net/ubuntu/eoan/+queue?queue_state=1 version : 2.7.1-4ubuntu2.1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-07 Thread Alex Tu
the patch for eoan is there: https://code.launchpad.net/~alextu/+git/dkms/+ref/eoan-lp1838245 7db3297 for bump version b0921f3 for the patch the patch for disco is there: https://code.launchpad.net/~alextu/+git/dkms/+ref/disco-lp1838245 2af553b for bump

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-06 Thread Brian Murray
** Also affects: dkms (Ubuntu Focal) Importance: Critical Status: Confirmed ** Also affects: dkms (Ubuntu Eoan) Importance: Undecided Status: New ** Changed in: dkms (Ubuntu Eoan) Status: New => Triaged ** Changed in: dkms (Ubuntu Focal) Status: Confirmed =>

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-05 Thread Alex Tu
The new feature landing missed that fix. It impacts eoan and disco. The bionic carried that fix , and Focal is supposed to just land latest code from upstream, so they will not be impacted. Sorry for inconvenient, I'll send a new patch to fix it on eoan and disco today. ** Changed in: dkms

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-05 Thread Brian Murray
This changes seems to have been dropped in Ubuntu 19.10 and Focal. ** Changed in: dkms (Ubuntu) Status: Fix Released => Confirmed ** Tags added: rls-ff-incoming -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-05 Thread Tom Cook
For me, the fix is to change line 812 of /usr/sbin/dkms from: [ -z $kernels_module ] || return 0 to [ -z $kernels_module ] && return 0 This was fixed upstream here: https://github.com/dell/dkms/commit/b95779938805aca8e98d57492b18dee07d35d285 -- You received this bug notification

[Bug 1838245] Re: dkms script is missing function find_module

2019-11-05 Thread Tom Cook
I'm still seeing this on Eoan, which has dkms 2.7.1-4ubuntu2 - the symptom is that virtualbox-dkms does not correctly build and install its kernel modules with the message `modinfo: ERROR: missing module or filename.` -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1838245] Re: dkms script is missing function find_module

2019-09-15 Thread Mathew Hodson
** Changed in: dkms Status: In Progress => Fix Released ** Tags removed: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838245 Title: dkms script is missing function

[Bug 1838245] Re: dkms script is missing function find_module

2019-09-02 Thread Timo Aaltonen
should be fixed in eoan ** Changed in: dkms (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838245 Title: dkms script is missing function

[Bug 1838245] Re: dkms script is missing function find_module

2019-08-04 Thread Alex Tu
this release not include the change of "priority of OBSOLETE_BY should higher than "force". #89 https://github.com/dell/dkms/issues/89; , so I created another ticket for that change: https://bugs.launchpad.net/oem-priority/+bug/1838921 -- You received this bug notification because you are a

[Bug 1838245] Re: dkms script is missing function find_module

2019-08-03 Thread Launchpad Bug Tracker
This bug was fixed in the package dkms - 2.3-3ubuntu9.5 --- dkms (2.3-3ubuntu9.5) bionic; urgency=medium * Fixup previous upload: find_module doesn't exist yet, and there's bad boolean logic in the check if we've already dealt with obsoleted modules. (LP: #1838245) --

[Bug 1838245] Re: dkms script is missing function find_module

2019-08-02 Thread Alex Tu
the proposed version not include the patch of "priority of OBSOLETE_BY should higher than "force". #89 https://github.com/dell/dkms/issues/89; , so I created another ppa [1] to test the regression only my system installed kernel 4.15.0-1030-oem and 4.15.0-1045-oem and new dkms from #10, then

[Bug 1838245] Re: dkms script is missing function find_module

2019-08-02 Thread Alex Tu
** Changed in: dkms Importance: Undecided => Critical -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838245 Title: dkms script is missing function find_module To manage notifications about this

[Bug 1838245] Re: dkms script is missing function find_module

2019-08-02 Thread Timo Aaltonen
Hello Alex, or anyone else affected, Accepted dkms into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dkms/2.3-3ubuntu9.5 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1838245] Re: dkms script is missing function find_module

2019-08-01 Thread Steve Langasek
** Tags added: regression-update -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838245 Title: dkms script is missing function find_module To manage notifications about this bug go to:

[Bug 1838245] Re: dkms script is missing function find_module

2019-08-01 Thread Steve Langasek
** Changed in: dkms (Ubuntu) Importance: Undecided => Critical -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838245 Title: dkms script is missing function find_module To manage notifications

[Bug 1838245] Re: dkms script is missing function find_module

2019-07-31 Thread Alex Tu
the case I tested: install the dkms which already patched (also can be found in my ppa[1]) 1. install a dkms which for a kernel module system already installed. e.g. ath10k of my testing ppa : [1] 1.1. the dkms can be installed well. 2. install a dkms which has OBSOLETE_BY and FORCE e.g.ath10k

[Bug 1838245] Re: dkms script is missing function find_module

2019-07-30 Thread Alex Tu
btw, I plan to land another change in the target SRU, to fix https://github.com/dell/dkms/issues/89 the package on testing ppa already include it. https://code.launchpad.net/~alextu/+recipe/dkms-2.3-lp1838245 https://code.launchpad.net/~alextu/+archive/ubuntu/dkms-2.3-lp1838245 ** Bug watch

[Bug 1838245] Re: dkms script is missing function find_module

2019-07-30 Thread Alex Tu
the patched package is ready for test, I'll continue to process SRU, please interrupt me if any regression be found. https://code.launchpad.net/~alextu/+archive/ubuntu/dkms-2.3-lp1838245 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1838245] Re: dkms script is missing function find_module

2019-07-30 Thread Alex Tu
btw, the fix already be merged by upstream on github: https://github.com/dell/dkms/commit/9976fa6c9665d78d4c8125ce4825507cd0dfb247 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838245 Title: dkms

[Bug 1838245] Re: dkms script is missing function find_module

2019-07-30 Thread Alex G
I tested this patch locally and it (seems to) work: - read -a kernels_module < <(find_module "$lib_tree" "${4}") + read -a kernels_module < <(find $lib_tree -name ${4}$module_suffix) - [ -z $kernels_module ] || return 0 + [ -z $kernels_module ] && return 0 -- You received this bug notification

[Bug 1838245] Re: dkms script is missing function find_module

2019-07-30 Thread Alex Tu
indeed, I was tricked by that misformatted `else`. Thanks for reporting the issue. I agree the correct line should be `[ -z $kernels_module ] && return 0`, because the following code is used to compare the version of target DKMS and existed module on the system. So, I'm processing to proposed

[Bug 1838245] Re: dkms script is missing function find_module

2019-07-29 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: dkms (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1838245 Title: dkms

[Bug 1838245] Re: dkms script is missing function find_module

2019-07-29 Thread Alex G
But there is another bug: The following line reads `[ -z $kernels_module ] || return 0` Previously the related section was: if [ -z $kernels_module ]; then # Magic split into array syntax saves trivial awk and cut calls. local -a obs=(${3//-/ }) local -a my=(${1//-/

[Bug 1838245] Re: dkms script is missing function find_module

2019-07-29 Thread Alex G
Bug was introduced in by 2.3-3ubuntu9.4 the following commit: https://git.launchpad.net/ubuntu/+source/dkms/commit/?id=4cfc905dc605628eb6d3ceddb21fb12cac9543d5: Relevant diff: -read -a kernels_module < <(find $lib_tree -name ${4}$module_suffix) +read -a kernels_module < <(find_module