[Bug 1848399] Re: update-grub fails if zpools with unsupported feature_flags exist
** Description changed: - install from Oct 14 live installer failed. + [Description] + If a pool to import update-grub will fail because the import error message is used as the name of the pool. The error is similar to: + + "cannot open 'This': no such pool" when no ZFS pools are available + + The error can be caused by anything such as an invalid feature or a + corrupted device. + + The fix catches the error, displays it, ignore the pool but import + others. + + [Test Case] + 1. Create a pool on a device and export it + 2. Corrupt the device for example by shuffling random blocks on the device but not the header so it is recognized as a ZFS device + 3. Run update-grub + + Expected result: + The pool is ignored and reported + + Actual result: + Generation of the grub menu fails + + + [Regression potential] + Low since currently the script aborts on error as soon as it fails to import. Worst case nothing imports and there is no zfs entries in the grub menu. + ProblemType: Bug DistroRelease: Ubuntu 19.10 Package: ubiquity 19.10.20 ProcVersionSignature: Ubuntu 5.3.0-18.19-generic 5.3.1 Uname: Linux 5.3.0-18-generic x86_64 NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair ApportVersion: 2.20.11-0ubuntu8 Architecture: amd64 CasperVersion: 1.425 Date: Wed Oct 16 20:03:30 2019 InstallCmdLine: BOOT_IMAGE=/casper/vmlinuz file=/cdrom/preseed/ubuntu.seed quiet splash --- LiveMediaBuild: Ubuntu 19.10 "Eoan Ermine" - Release amd64 (20191014) SourcePackage: ubiquity UpgradeStatus: No upgrade log present (probably fresh install) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848399 Title: update-grub fails if zpools with unsupported feature_flags exist To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848399/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848399] Re: update-grub fails if zpools with unsupported feature_flags exist
** Changed in: grub2 (Ubuntu Eoan) Status: New => In Progress ** Changed in: grubzfs-testsuite (Ubuntu Eoan) Status: New => In Progress ** Changed in: grubzfs-testsuite (Ubuntu Eoan) Status: In Progress => Triaged ** Changed in: grubzfs-testsuite (Ubuntu Focal) Status: New => Triaged ** Changed in: grub2 (Ubuntu Eoan) Importance: Undecided => Medium ** Changed in: grubzfs-testsuite (Ubuntu Eoan) Importance: Undecided => Medium ** Changed in: grubzfs-testsuite (Ubuntu Focal) Importance: Undecided => Medium ** Changed in: grub2 (Ubuntu Eoan) Assignee: (unassigned) => Jean-Baptiste Lallement (jibel) ** Changed in: grubzfs-testsuite (Ubuntu Eoan) Assignee: (unassigned) => Jean-Baptiste Lallement (jibel) ** Changed in: grubzfs-testsuite (Ubuntu Focal) Assignee: (unassigned) => Jean-Baptiste Lallement (jibel) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848399 Title: update-grub fails if zpools with unsupported feature_flags exist To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848399/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848399] Re: update-grub fails if zpools with unsupported feature_flags exist
** Also affects: grub2 (Ubuntu Eoan) Importance: Undecided Status: New ** Also affects: grubzfs-testsuite (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848399 Title: update-grub fails if zpools with unsupported feature_flags exist To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848399/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848399] Re: update-grub fails if zpools with unsupported feature_flags exist
Fix in progress. For the testsuite, we cannot reproduce the very same error, however by corrupting the disk we can reproduce a similar case (error message is caught and used as the name of the pool) ** Changed in: grub2 (Ubuntu Focal) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848399 Title: update-grub fails if zpools with unsupported feature_flags exist To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848399/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848399] Re: update-grub fails if zpools with unsupported feature_flags exist
** Changed in: grub2 (Ubuntu Focal) Importance: High => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848399 Title: update-grub fails if zpools with unsupported feature_flags exist To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848399/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848399] Re: update-grub fails if zpools with unsupported feature_flags exist
** No longer affects: ubiquity (Ubuntu) ** No longer affects: zsys (Ubuntu) ** Also affects: grub2 (Ubuntu Focal) Importance: High Assignee: Jean-Baptiste Lallement (jibel) Status: Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848399 Title: update-grub fails if zpools with unsupported feature_flags exist To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848399/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848399] Re: update-grub fails if zpools with unsupported feature_flags exist
** Changed in: grub2 (Ubuntu) Status: Incomplete => Triaged ** Changed in: grub2 (Ubuntu) Importance: Undecided => High ** Changed in: grub2 (Ubuntu) Assignee: (unassigned) => Jean-Baptiste Lallement (jibel) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848399 Title: update-grub fails if zpools with unsupported feature_flags exist To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848399/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848399] Re: update-grub fails if zpools with unsupported feature_flags exist
FYI:
One can replace the "zpool import -f -a -o cachefile=none -N" line with this:
local pipe="/tmp/zpool_pipe"
no_import_pools=$(mkfifo ${pipe}; zpool import -f -a -o cachefile=none -N
2> ${pipe} | cut -d \' -f 2 ${pipe}; rm ${pipe})
If one wants a list of the pools which can not be imported.
To just discard the error though and keep update-grub from failing this
works fine too:
local discard_pool_import_err=""
discard_pool_import_err=$(zpool import -f -a -o cachefile=none -N 2>/dev/null
|| true)
Maybe that workaround could be added so update-grub at least doesn't
fail if a zpool which can't be imported is seen?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848399
Title:
update-grub fails if zpools with unsupported feature_flags exist
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848399/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848399] Re: update-grub fails if zpools with unsupported feature_flags exist
I have log_spacemap enabled. zpool import -f -a -o cachefile=none -N "This pool uses the following feature(s) not supported by this system: com.delphix:log_spacemap (Log metaslab changes on a single spacemap and flush them periodically.) All unsupported features are only required for writing to the pool. The pool can be imported using '-o readonly=on'." Accepted for post 0.8.1: https://github.com/zfsonlinux/zfs/pull/8442#issuecomment-511918033 (But this could happen with the import of ANY zpool from another system. For instance from a non zfsonlinux system with different feature flags set.) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848399 Title: update-grub fails if zpools with unsupported feature_flags exist To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848399/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848399] Re: update-grub fails if zpools with unsupported feature_flags exist
** Package changed: grub (Ubuntu) => grub2 (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848399 Title: update-grub fails if zpools with unsupported feature_flags exist To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848399/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848399] Re: update-grub fails if zpools with unsupported feature_flags exist
waow, do you have features enabled on some pools not supported in our ZFS 0.8.1 version? Would be interesting to know. || true is a little bit too much without filtering what was imported. We can maybe force at least importing a bpool and rpool (whatever it is) to ensure that grub will install a grub.cfg with at least one bootable system, but what about system with ZFS installed with no pools at all? That sounds it needs deeper investigation and is (fortunately) only touching advanced users that can debug for now :) Let's add that to the list for 20.04 and figure out what's the right actions are. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848399 Title: update-grub fails if zpools with unsupported feature_flags exist To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848399/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
