[Bug 1860629] Re: Window decorations themes don't work

2020-01-23 Thread Launchpad Bug Tracker
This bug was fixed in the package kwin - 4:5.17.90-0ubuntu2

---
kwin (4:5.17.90-0ubuntu2) focal; urgency=medium

  * Add upstream patch to fix saving changes to window decoration
themes (LP: #1860629)
+ debian/patches: upstream_fix-saving-window-decoration.patch

 -- Rik Mills   Thu, 23 Jan 2020 10:20:24 +

** Changed in: kwin (Ubuntu)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1860629

Title:
  Window decorations themes don't work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kdebase-workspace/+bug/1860629/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1860629] Re: Window decorations themes don't work

2020-01-23 Thread Bug Watch Updater
Launchpad has imported 9 comments from the remote bug at
https://bugs.kde.org/show_bug.cgi?id=416525.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.


On 2020-01-21T10:55:29+00:00 Strangiato Xanadu wrote:

SUMMARY
Tested on both X11 and Wayland sessions.

STEPS TO REPRODUCE
1. open system settings > application style > window decorations
2. select any Aurorae window decoration (I tested Breezemite and Mcmojave light 
installed via "Get new window decorations" button)
3. click on "Apply" button

OBSERVED RESULT
Apparently the selected window decoration was applied, but kwin is still using 
Breeze even after relogin.


EXPECTED RESULT
kwin uses the applied window decoration

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.0

Reply at:
https://bugs.launchpad.net/ubuntu/+source/kwin/+bug/1860629/comments/0


On 2020-01-21T17:34:22+00:00 Nate-b wrote:

Confirmed.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/kwin/+bug/1860629/comments/1


On 2020-01-21T18:02:47+00:00 U26 wrote:

I can't reproduce.

Can you post ~/.config/kwinrc after modifying.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/kwin/+bug/1860629/comments/2


On 2020-01-21T18:09:22+00:00 Strangiato Xanadu wrote:

Created attachment 125287
kwinrc

Reply at:
https://bugs.launchpad.net/ubuntu/+source/kwin/+bug/1860629/comments/3


On 2020-01-21T18:10:22+00:00 U26 wrote:


[org.kde.kdecoration2]
BorderSize=Normal
BorderSizeAuto=true
ButtonsOnLeft=MFS
ButtonsOnRight=IAX
CloseOnDoubleClickOnMenu=true
ShowToolTips=true
theme=__aurorae__svg__Breezemite


This line is missing:
library=org.kde.kwin.aurorae


:/

Reply at:
https://bugs.launchpad.net/ubuntu/+source/kwin/+bug/1860629/comments/4


On 2020-01-21T18:15:27+00:00 Nate-b wrote:

It's missing from mine too. However I see that this line has been added:

theme=__aurorae__svg__McMojave

Reply at:
https://bugs.launchpad.net/ubuntu/+source/kwin/+bug/1860629/comments/5


On 2020-01-21T18:18:08+00:00 U26 wrote:

Found it.

  #if HAVE_BREEZE_DECO
  const QString s_defaultPlugin { 
QStringLiteral(BREEZE_KDECORATION_PLUGIN_ID) };
  #else
  const QString s_defaultPlugin { 
QStringLiteral("org.kde.kwin.aurorae") };
  #endif
  

HAVE_BREEZE_DECO is undefined for the KCM, so it doesn't save the entry

Reply at:
https://bugs.launchpad.net/ubuntu/+source/kwin/+bug/1860629/comments/6


On 2020-01-21T18:22:25+00:00 U26 wrote:

https://phabricator.kde.org/D26814

Reply at:
https://bugs.launchpad.net/ubuntu/+source/kwin/+bug/1860629/comments/7


On 2020-01-21T18:42:14+00:00 U26 wrote:

Git commit e0df390dbc241409532c26a632490d03e19fb3da by David Edmundson.
Committed on 21/01/2020 at 18:41.
Pushed by davidedmundson into branch 'Plasma/5.18'.

[kcms/kwindecoration] Fix saving of window decoration plugin

Summary:
In the KCFG autogenerated code we check for HAVE_BREEZE_DECO without
including the relevant file. This always fails, and so we save the
default plugin name/library as org.kde.kwin.aurorae

This doesn't match kwin's concept of the default and so we just fail to
load it.

Test Plan:
Reproduced
Saved a config

Reviewers: #kwin, ngraham

Reviewed By: ngraham

Subscribers: ngraham, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D26814

M  +1-0kcmkwin/kwindecoration/kwindecorationsettings.kcfg

https://commits.kde.org/kwin/e0df390dbc241409532c26a632490d03e19fb3da

Reply at:
https://bugs.launchpad.net/ubuntu/+source/kwin/+bug/1860629/comments/8


** Changed in: kdebase-workspace
   Status: Unknown => Fix Released

** Changed in: kdebase-workspace
   Importance: Unknown => High

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1860629

Title:
  Window decorations themes don't work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kdebase-workspace/+bug/1860629/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1860629] Re: Window decorations themes don't work

2020-01-23 Thread Rik Mills
** Bug watch added: KDE Bug Tracking System #416525
   https://bugs.kde.org/show_bug.cgi?id=416525

** Also affects: kdebase-workspace via
   https://bugs.kde.org/show_bug.cgi?id=416525
   Importance: Unknown
   Status: Unknown

** Changed in: kwin (Ubuntu)
   Importance: Undecided => High

** Changed in: kwin (Ubuntu)
 Assignee: (unassigned) => Rik Mills (rikmills)

** Changed in: kwin (Ubuntu)
   Status: Confirmed => In Progress

** Changed in: kwin (Ubuntu)
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to kwin in Ubuntu.
https://bugs.launchpad.net/bugs/1860629

Title:
  Window decorations themes don't work

To manage notifications about this bug go to:
https://bugs.launchpad.net/kdebase-workspace/+bug/1860629/+subscriptions

-- 
kubuntu-bugs mailing list
kubuntu-b...@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs


[Bug 1860629] Re: Window decorations themes don't work

2020-01-23 Thread Rik Mills
** Package changed: kde-cli-tools (Ubuntu) => kwin (Ubuntu)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1860629

Title:
  Window decorations themes don't work

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/kwin/+bug/1860629/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1860629] Re: Window decorations themes don't work

2020-01-23 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: kde-cli-tools (Ubuntu)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1860629

Title:
  Window decorations themes don't work

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/kde-cli-tools/+bug/1860629/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs