[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-07-15 Thread Olivier Tilloy
Note that as a mitigation to bug #1616650, the chromium profile directory, which was previously versioned in $SNAP_USER_DATA is now under $SNAP_USER_COMMON, so problems should be much less visible to end users. -- You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-06-15 Thread Adolfo Jayme
** Changed in: chromium-browser (Ubuntu) Status: Fix Released => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1864901 Title: [snap] suggestion: alert users when the snap has been

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-06-11 Thread Olivier Tilloy
Reverted in https://git.launchpad.net/~chromium-team/chromium- browser/+git/snap-from- source/commit/?id=d3a863f6e544867e6596601c4f5f5373539e56af. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1864901

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-06-11 Thread Olivier Tilloy
I can confirm both Roman's observation in comment #25, and Nick's in comment #27. Seeing that there are real problems with the implementation, I'm going to revert it for now, until I can work out a better solution (or, ideally, a better mechanism is implemented in snapd itself). -- You

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-05-20 Thread Nick Grimshaw
> The sleep process will outlive the launcher process at most 60 seconds, after which it will exit. A problem I'm seeing is that the sleep process is sometimes *blocking* progression of other scripts e.g. if you pipe the output of a chromium process to something else: ``` $ snap refresh All

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-05-08 Thread Olivier Tilloy
@Ebuzer: Downloads are already stored by default outside of the versioned directory, in the user's XDG downloads directory (typically $HOME/Downloads). The rationale for versioning the profile directory is that the storage format isn't backwards compatible, so downgrading a snap to a previous

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-05-08 Thread Roman Odaisky
This issue causes `ubuntu-bug chromium-browser` to hang. Additionally, isn’t this an issue that’s best solved within snapd itself? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1864901 Title:

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-05-05 Thread Ebuzer Taha Kanat
I tested and snap allows files in /home/user/snap/chromium/common to be accessed via chromium. What will be the down side of creating .config, Download, Documents, Videos etc. in that. From my previous experience i know that simply copying chromium directory in .config is okay to migrate profile

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-05-05 Thread Ebuzer Taha Kanat
Here is a solution suggestion why not storing version independent files such as Downloads, profile and other in common directory since it doesn't change between versions and keep version dependent files in version directories? Just like how virtual machines and containers work, storage is linked

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-05-05 Thread Olivier Tilloy
The sleep process will outlive the launcher process at most 60 seconds, after which it will exit. Note that this is only a temporary helper, until background refreshes of snaps are properly notified to running snaps by snapd through a well defined API. -- You received this bug notification

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-05-04 Thread berkes
The issues with dependant scripts like chromerunner are not solved either. Were external scripts considered when building this "solution" at all? External scripts, running chromium, obviously, want the process they spawn to exit -including any children that that process might spawn-. Breaking

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-05-02 Thread Alexey Bazhin
tarantula!root# ps axu | grep chr root 561745 0.0 0.0 6436 728 pts/2S+ 15:20 0:00 grep chr tarantula!root# snap refresh chromium error: cannot refresh "chromium": snap "chromium" has running apps (chromium) Had to restart snapd to update chromium snap. -- You received this

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-05-02 Thread Alexey Bazhin
tarantula!root# snap refresh core18 20200427 from Canonical✓ refreshed tarantula!root# snap refresh All snaps up to date. tarantula!root# snap list | grep chromium chromium 81.0.4044.1221119 latest/stable canonical*- tarantula!root# snap info --abs-time chromium name:

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-30 Thread Olivier Tilloy
That may sound like a dumb question, but are you connected to the network? What's the output of the following command? snap info --abs-time chromium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-30 Thread Alexey Bazhin
tarantula!root# snap refresh All snaps up to date. How do I get the "latest" ? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1864901 Title: [snap] suggestion: alert users when the snap has been

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-29 Thread Olivier Tilloy
revision 1119 is not up-to-date, the latest for amd64 is now 1135. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1864901 Title: [snap] suggestion: alert users when the snap has been refreshed while

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-29 Thread Alexey Bazhin
I'm still seeing the problem. tarantula!root# snap refresh All snaps up to date. tarantula!root# snap list | grep chromium chromium 81.0.4044.1221119 latest/stable canonical*- -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-27 Thread Olivier Tilloy
The problem with the numerous background sleep processes should be fixed in the stable channel now. Please shout here if you're still seeing it (note that existing background processes before refreshing to the latest version won't be cleaned up). ** Changed in: chromium-browser (Ubuntu)

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-25 Thread Lothar Braun
Olivier, I wasn't able to test your patch. But I like your approach better than mine. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1864901 Title: [snap] suggestion: alert users when the snap has

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-25 Thread Benjamin Schmid
This feature caused me leaking processes. See Bug: https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1874973 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1864901 Title: [snap]

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-24 Thread Adrien Jarthon
For the record I recently noticed the 30 leaked processes started taking all my CPU (all at the same time, maybe when an update was downloaded). They were all running in infinite loop and I couldn't see the "sleep 60" in their children any more in htop. I didn't investigate more as I had to

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-24 Thread Olivier Tilloy
Indeed it's only an informative notification, it won't take any action by itself. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1864901 Title: [snap] suggestion: alert users when the snap has been

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-24 Thread Mike Gresens
I get a notification if snap updates chromium in background. But clicking the notification does nothing - only the notifcation disappears. No restart of all chromium instances - so not really useful... -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-24 Thread Olivier Tilloy
Thanks for your patch Lothar. I think your solution would work, although I went for a slightly different approach: https://git.launchpad.net /~chromium-team/chromium-browser/+git/snap-from- source/commit/?id=eb7aefe53b2c4710c030e04947ae66ced8fe9d3b. (I am aware that pids can get recycled so it's

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-23 Thread Ubuntu Foundations Team Bug Bot
The attachment "1864901_termination_check_current_symlink.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-23 Thread Lothar Braun
While it's not a beautiful solution, the attached patch does terminate the lingering process for me. The sleep started by the symlink check is not killed, but will terminate after 60 seconds. ** Patch added: "1864901_termination_check_current_symlink.patch"

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-20 Thread berkes
It also occurs with a freshly installed chromium. It can be easily reproduced: ``` $ pgrep chromium | xargs kill # kill any running chromium (beware!) $ pgrep chromium | wc -l 0 # There are non running $ /snap/bin/chromium --product-version # command quits immediately. $ pgrep chromium | wc -l 1

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-20 Thread Olivier Tilloy
I can confirm this undesirable side effect. The background process that checks whether an update was installed should die when the corresponding chromium instance is terminated. ** Changed in: chromium-browser (Ubuntu) Status: Fix Committed => Triaged -- You received this bug

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-18 Thread Adrien Jarthon
I just noticed hundreds of chromium.launcher processes running on my machine with `sleep 60` and found that it's because of this fix. Looks like this background process is started but nerver stopped? nor does it checks if it's already running. This is especially visible in my case because I'm

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-14 Thread Olivier Tilloy
Implemented in a much more lightweight manner using notify-send: https://git.launchpad.net/~chromium-team/chromium-browser/+git/snap- from-source/commit/?id=82ee1ce51514ee197ee6fd908c9f0af881f1f2ac. ** Changed in: chromium-browser (Ubuntu) Status: In Progress => Fix Committed -- You

[Bug 1864901] Re: [snap] suggestion: alert users when the snap has been refreshed while running

2020-04-07 Thread Olivier Tilloy
This is an attempt at implementing this: https://git.launchpad.net /~chromium-team/chromium-browser/+git/snap-from- source/commit/?id=a7dc89ea1996665cb528701c2c23a5e17e5508c2 ** Changed in: chromium-browser (Ubuntu) Status: Triaged => In Progress -- You received this bug notification