[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
Ubuntu 21.04 (Hirsute Hippo) has reached end of life, so this bug will not be fixed for that specific release. ** Changed in: python-netaddr (Ubuntu Hirsute) Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
Awesome, thank you very much, @slashd! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
[VERIFICATION] The ansible (and the fixed packages listed in the bugs) installation has been tested by impacted users and the outcomes were as expected. - Eric ** Tags removed: verification-needed-bionic verification-needed-focal ** Tags added: verification-done-bionic verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
This bug was fixed in the package python-netaddr - 0.7.19-3ubuntu1 --- python-netaddr (0.7.19-3ubuntu1) focal; urgency=medium * d/p/fix-python-38-syntaxwarning.patch: (LP: #1877792) - Fix Python 3.8 SyntaxWarning on using `is not` with a string literal. -- Eric Desrochers Mon, 18 Oct 2021 11:25:44 -0400 ** Changed in: python-netaddr (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
This bug was fixed in the package python-jmespath - 0.9.3-1ubuntu1.1 --- python-jmespath (0.9.3-1ubuntu1.1) bionic; urgency=medium * d/p/0001-satisfy-python38-syntaxwarning.patch: - Python 3.8 raises a syntax warning when using is to compare integers or string literals. (LP: #1877792) -- Eric Desrochers Fri, 08 Oct 2021 08:50:18 -0400 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
This bug was fixed in the package python-jmespath - 0.9.4-2ubuntu1 --- python-jmespath (0.9.4-2ubuntu1) focal; urgency=medium * d/p/0001-satisfy-python38-syntaxwarning.patch: - Python 3.8 raises a syntax warning when using is to compare integers or string literals. (LP: #1877792) -- Eric Desrochers Fri, 08 Oct 2021 08:56:43 -0400 ** Changed in: python-jmespath (Ubuntu Focal) Status: Fix Committed => Fix Released ** Changed in: python-jmespath (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
The regressions observed in azure-cli for Focal/20.04LTS have nothing to do with this particular SRU change. I have reported a separate bug for this: https://bugs.launchpad.net/ubuntu/+source/azure-cli/+bug/1948595 One unit test is failing as it misses an argument (--subscription) in "az cloud list" cli. From my preliminary research, it seems like this argument isn't globally exposed. - Eric -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
** Changed in: python-netaddr (Ubuntu Bionic) Assignee: Eric Desrochers (slashd) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
Hello Edward, or anyone else affected, Accepted python-netaddr into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python- netaddr/0.7.19-3ubuntu1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: python-netaddr (Ubuntu Focal) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
Hello Edward, or anyone else affected, Accepted python-jmespath into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python- jmespath/0.9.4-2ubuntu1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: python-jmespath (Ubuntu Focal) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-focal ** Changed in: python-jmespath (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
Okay, thanks for the explanation! Normally these kind of cosmetic bugs are not really SRU material by themselves - the SRU policy is quite strict about what kind of fixes are to be backported to stable series. That being said, we can look into special circumstances like this one here. With both the packages being in main and never before getting any SRU updates, I think we can do a one-off SRU for such a low priority bug. I think it's important for users to have confidence in our packages, and if such warnings make them switch from our official repositories to pip, I think our LTSes would merit from such a fix. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
To answer #10 from Lukasz. python-netaddr so as python-jmespath (both ansible runtime dependencies) spew syntaxwarning at ansible installation time (or their respective package). It is purely cosmetic, but we hope fixing these bug will make user gain confidence in the Ansible package found in the Ubuntu archive, instead of users diverting by using upstream ansible packages from PyPi or other third-party repositories. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
To answer #10 from Lukasz. python-netaddr so as python-jmespath (both ansible runtime dependencies) spew syntaxwarning at ansible installation time (or their respective package). It is purely cosmetic, but we hope fixing these bug will make user gain confidence in the ansible package found in the archive (that it is sane and tested), instead of them seeking for other packages that won't have syntaxwarning. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
** Description changed: [IMPACT] * Allow broader Ops/Eng team to consume Ansible from our packages instead of the upstream PyPi repositories in order to fix this warning. * Sanitize package installation: Setting up python3-jmespath (0.9.4-2) ... /usr/lib/python3/dist-packages/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="? + + Setting up python3-netaddr (0.7.19-3) ... + /usr/lib/python3/dist-packages/netaddr/strategy/__init__.py:189: SyntaxWarning: "is not" with a literal. Did you mean "!="? + if word_sep is not '': + + jmespath and netaddr are 2 runtime dependencies of ansible. + + The syntaxwarning while purely cosmetic, may mislead user and their + trust in using a sane and tested package. [TEST CASE] ** Scenario #1 ** $ pull-lp-source python-jmespath $ cd python-jmespath* $ python3-coverage run jmespath/visitor.py jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="? if x is 0 or x is 1: jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="? if x is 0 or x is 1: jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="? elif y is 0 or y is 1: jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="? elif y is 0 or y is 1: jmespath/visitor.py:260: SyntaxWarning: "is" with a literal. Did you mean "=="? if original_result is 0: $ quilt push -a Applying patch 0001-satisfy-python38-syntaxwarning.patch patching file jmespath/visitor.py $ python3-coverage run jmespath/visitor.py ** Scenario #2 ** - $ pull-lp-source python-jmespath $ cd python-jmespath* $ nosetests3 /tmp/jmes/f/python-jmespath-0.9.4/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="? - if x is 0 or x is 1: + if x is 0 or x is 1: /tmp/jmes/f/python-jmespath-0.9.4/jmespath/visitor.py:32: SyntaxWarning: "is" with a literal. Did you mean "=="? - if x is 0 or x is 1: + if x is 0 or x is 1: /tmp/jmes/f/python-jmespath-0.9.4/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="? - elif y is 0 or y is 1: + elif y is 0 or y is 1: /tmp/jmes/f/python-jmespath-0.9.4/jmespath/visitor.py:34: SyntaxWarning: "is" with a literal. Did you mean "=="? - elif y is 0 or y is 1: + elif y is 0 or y is 1: /tmp/jmes/f/python-jmespath-0.9.4/jmespath/visitor.py:260: SyntaxWarning: "is" with a literal. Did you mean "=="? - if original_result is 0: + if original_result is 0: . -- Ran 41 tests in 0.039s OK $ quilt push -a Applying patch 0001-satisfy-python38-syntaxwarning.patch patching file jmespath/visitor.py Now at patch 0001-satisfy-python38-syntaxwarning.patch $ nosetests3 . -- Ran 41 tests in 0.021s OK $ nosetests . -- Ran 41 tests in 0.016s OK - ** Scenario #3 ** This could be reproduced outside python-jmespath as follows (a little script I have written to compare result between py2 and py3 : # reproducer_test.py def reproducer(x,y): if x is 0 or x is 1: return y is True or y is False elif y is 0 or y is 1: return x is True or x is False print(reproducer(1,0)) print(reproducer(0,1)) --- $ python2 reproducer_test.py False False $ python3 -W ignore reproducer_test.py False False $ python3 reproducer_test.py test.py:2: SyntaxWarning: "is" with a literal. Did you mean "=="? if x is 0 or x is 1: test.py:2: SyntaxWarning: "is" with a literal. Did you mean "=="? if x is 0 or x is 1: test.py:4: SyntaxWarning: "is" with a literal. Did you mean "=="? elif y is 0 or y is 1: test.py:4: SyntaxWarning: "is" with a literal. Did you mean "=="? elif y is 0 or y is 1: False False With the fix in a small scale (Again, using my reproducer_test.py): # reproducer_test.py def reproducer(x,y): #if x is 0 or x is 1: if type(x) is int and (x == 0 or x == 1): return y is True or y is False #elif y is 0 or y is 1: elif type(y) is int and (y == 0 or y == 1): return x is True or x is False print(reproducer(1,0)) print(reproducer(0,1)) --- # python2 reproducer_test.py False False $ python3 reproducer_test.py False False The above proves that it maintains compatibility in py2 while fixing the "SyntaxWarning "in py3. [WHERE PROBLEM COULD OCCURS] Risk: Low * The fix maintain backward compatibility tested with python3-coverage/python-coverage, and python3-nose/python-nose manually
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: python-netaddr (Ubuntu Impish) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: python-netaddr (Ubuntu Hirsute) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1877792] Re: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible.
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: python-netaddr (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1877792 Title: jmespath/netaddr SyntaxWarning: "is" with a literal when installing ansible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ansible/+bug/1877792/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
