[Bug 1880031] Re: Thumbnail is stretched if its aspect ratio is less than that of the container
** Changed in: gnome-shell-extension-desktop-icons Status: Unknown => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880031] Re: Thumbnail is stretched if its aspect ratio is less than that of the container
^^^ That is being tracked in bug 1892276 now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880031] Re: Thumbnail is stretched if its aspect ratio is less than that of the container
I still have the bug with the updated package... (see screenshot) [upgraded yesterday from 18.04 on Dell XPS 13 system] ** Attachment added: "screenshot" https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-icons/+bug/1880031/+attachment/5406857/+files/Capture%20d%E2%80%99%C3%A9cran%20de%202020-09-02%2009-32-57.png -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880031] Re: Thumbnail is stretched if its aspect ratio is less than that of the container
This bug was fixed in the package gnome-shell-extension-desktop-icons - 20.04.0-3~ubuntu20.04.1 --- gnome-shell-extension-desktop-icons (20.04.0-3~ubuntu20.04.1) focal; urgency=medium * No-change backport to focal gnome-shell-extension-desktop-icons (20.04.0-3) unstable; urgency=medium * d/p/Fix-incorrect-aspect-ratio.patch, d/p/desktopGrid.js-fix-errors-when-screen-size-changes.patch: - Fix incorrect icon aspect ratio (LP: #1880031) -- Marco Trevisan (Treviño) Tue, 21 Jul 2020 18:30:14 +0200 ** Changed in: gnome-shell-extension-desktop-icons (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880031] Re: Thumbnail is stretched if its aspect ratio is less than that of the container
** Tags removed: verification-needed verification-needed-focal ** Tags added: verification-done verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880031] Re: Thumbnail is stretched if its aspect ratio is less than that of the container
I have installed gnome-shell-extension-desktop-icons 20.04.0-3~ubuntu20.04.1 from focal-proposed. The issue is fixed now: aspect ratio of desktop thumbnails is correct. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880031] Re: Thumbnail is stretched if its aspect ratio is less than that of the container
Hello riu, or anyone else affected, Accepted gnome-shell-extension-desktop-icons into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-desktop- icons/20.04.0-3~ubuntu20.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Tags added: verification-needed verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880031] Re: Thumbnail is stretched if its aspect ratio is less than that of the container
** Also affects: gnome-shell-extension-desktop-icons (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: gnome-shell-extension-desktop-icons (Ubuntu Focal) Status: New => Fix Committed ** Description changed: + [ Impact ] + + Image thumbnails are stretched if the aspect ratio is less than the one + of the container + + [ Test case ] + + To reproduce, create an image that has aspect ratio, e.g., ~0.5 (e.g. + width = 250 and height = 500) + + Save it in the desktop and ensure that the image has proper proportions. + + + [ Regression potential ] + + Image thumbnails are distorted + + + This was discovered when investigating fix for bug #1868529. Aspect ratio is still not correct for images that are more narrow than the container. To reproduce, create an image that has aspect ratio, e.g., ~0.5 (e.g. width = 250 and height = 500). Line in fileItem.js where we calculate icon width does not count the margins (zero is used instead of actual margins): let containerWidth = Prefs.getDesiredWidth(scaleFactor, 0); Here is how the margins are being calculated in desktopGrid.js: - this._extra_width = themeNode.get_margin(St.Side.LEFT) + - themeNode.get_margin(St.Side.RIGHT) + - themeNode.get_border_width(St.Side.LEFT) + - themeNode.get_border_width(St.Side.RIGHT) + - themeNode.get_horizontal_padding(); - this._extra_height = themeNode.get_margin(St.Side.TOP) + - themeNode.get_margin(St.Side.BOTTOM) + - themeNode.get_border_width(St.Side.TOP) + - themeNode.get_border_width(St.Side.BOTTOM) + - themeNode.get_vertical_padding(); + this._extra_width = themeNode.get_margin(St.Side.LEFT) + + themeNode.get_margin(St.Side.RIGHT) + + themeNode.get_border_width(St.Side.LEFT) + + themeNode.get_border_width(St.Side.RIGHT) + + themeNode.get_horizontal_padding(); + this._extra_height = themeNode.get_margin(St.Side.TOP) + + themeNode.get_margin(St.Side.BOTTOM) + + themeNode.get_border_width(St.Side.TOP) + + themeNode.get_border_width(St.Side.BOTTOM) + + themeNode.get_vertical_padding(); -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880031] Re: Thumbnail is stretched if its aspect ratio is less than that of the container
This bug was fixed in the package gnome-shell-extension-desktop-icons - 20.04.0-3 --- gnome-shell-extension-desktop-icons (20.04.0-3) unstable; urgency=medium * d/p/Fix-incorrect-aspect-ratio.patch, d/p/desktopGrid.js-fix-errors-when-screen-size-changes.patch: - Fix incorrect icon aspect ratio (LP: #1880031) -- Marco Trevisan (Treviño) Tue, 21 Jul 2020 18:16:08 +0200 ** Changed in: gnome-shell-extension-desktop-icons (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880031] Re: Thumbnail is stretched if its aspect ratio is less than that of the container
** Changed in: gnome-shell-extension-desktop-icons (Ubuntu) Status: New => Fix Committed ** Tags added: fixed-upstream -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880031] Re: Thumbnail is stretched if its aspect ratio is less than that of the container
I have reported the bug to upstream: Narrow desktop thumbnails are stretched (#205) · Issues · World / Shell extensions / Desktop Icons · GitLab https://gitlab.gnome.org/World/ShellExtensions/desktop-icons/-/issues/205 ** Bug watch added: gitlab.gnome.org/World/ShellExtensions/desktop-icons/-/issues #205 https://gitlab.gnome.org/World/ShellExtensions/desktop-icons/-/issues/205 ** Also affects: gnome-shell-extension-desktop-icons via https://gitlab.gnome.org/World/ShellExtensions/desktop-icons/-/issues/205 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880031] Re: Thumbnail is stretched if its aspect ratio is less than that of the container
Please include a screenshot/photo of the problem and report it to the developers at: https://gitlab.gnome.org/World/ShellExtensions/desktop-icons/-/issues ** Tags added: focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880031] Re: Thumbnail is stretched if its aspect ratio is less than that of the container
** Description changed: This was discovered when investigating fix for bug #1868529. Aspect ratio is still not correct for images that are more narrow than the container. To reproduce, create an image that has aspect ratio, e.g., ~0.5 (e.g. width = 250 and height = 500). Line in fileItem.js where we calculate icon width does not count the margins (zero is used instead of actual margins): - let iconWidth = Prefs.getDesiredWidth(scaleFactor, 0); + let containerWidth = Prefs.getDesiredWidth(scaleFactor, 0); Here is how the margins are being calculated in desktopGrid.js: this._extra_width = themeNode.get_margin(St.Side.LEFT) + themeNode.get_margin(St.Side.RIGHT) + themeNode.get_border_width(St.Side.LEFT) + themeNode.get_border_width(St.Side.RIGHT) + themeNode.get_horizontal_padding(); this._extra_height = themeNode.get_margin(St.Side.TOP) + themeNode.get_margin(St.Side.BOTTOM) + themeNode.get_border_width(St.Side.TOP) + themeNode.get_border_width(St.Side.BOTTOM) + themeNode.get_vertical_padding(); -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
