[Bug 1896752] Re: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released
This bug was fixed in the package torbrowser-launcher - 0.2.9-2ubuntu1 --- torbrowser-launcher (0.2.9-2ubuntu1) bionic; urgency=medium * This is a stable release update to address issues with Tor Browser install verification. * Patches added to d/patches: - 0023-Update-Tor-Browser-Developers-public-key-481.patch: Fixes issue with signature verification of tor browser tarball, due to changed upstream develoeprs key. (LP: #1856895) - 0031-Use-better-version-string-comparison.patch: Properly handle the version string comparison between Tor Browser versions, so that the launcher supports version 10+ and can properly validate. (LP: #1896752) -- Thomas Ward Mon, 12 Oct 2020 09:45:44 -0400 ** Changed in: torbrowser-launcher (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896752 Title: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896752/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896752] Re: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released
Tested and confirmed working in Bionic with proposed packages. ** Tags removed: verification-needed verification-needed-bionic ** Tags added: verification-done verification-done-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896752 Title: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896752/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896752] Re: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released
Hello AsciiWolf, or anyone else affected, Accepted torbrowser-launcher into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source /torbrowser-launcher/0.2.9-2ubuntu1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: torbrowser-launcher (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896752 Title: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896752/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896752] Re: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released
Bionic test build for SRU located here: https://launchpad.net/~teward/+archive/ubuntu/torbrowser-launcher-sru -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896752 Title: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896752/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896752] Re: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released
This issue impacts older versions of the launcher in Bionic as well - discovered while working on Bionic SRU fixes for https://bugs.launchpad.net/ubuntu/+source/torbrowser- launcher/+bug/1856895 ** Also affects: torbrowser-launcher (Ubuntu Bionic) Importance: Undecided Status: New ** Changed in: torbrowser-launcher (Ubuntu Bionic) Assignee: (unassigned) => Thomas Ward (teward) ** Changed in: torbrowser-launcher (Ubuntu Bionic) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896752 Title: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896752/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896752] Re: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released
This bug was fixed in the package torbrowser-launcher - 0.3.2-9ubuntu1 --- torbrowser-launcher (0.3.2-9ubuntu1) focal; urgency=medium * This is a bug-fix only upload to address several significant bugs found in the Tor Browser launcher package. * Patches backported from Debian Unstable release and Debian Salsa git repository for the package into the Focal package to fix issues. The following patches were added in d/patches and added to the quilt series file in the stated order: - 0023-Update-Tor-Browser-Developers-public-key-481.patch: Fixes issue with signature verification of tor browser tarball, due to changed upstream developers key. (LP: #1856895) - 0030-Use-gpg-instead-of-gpg2.patch: Use /usr/bin/gpg instead of the /usr/bin/gpg2 symlink due to gnupg2 transitional package not being part of default installations. (LP: #1897306) - 0031-Use-better-version-string-comparison.patch: Properly handle the version string comparison between Tor Browser versions, so that the launcher supports version 10+ and can properly validate. (LP: #1896752) - 0032-apparmor-allow-Browser-to-memory-map-libstdc.patch: Allow apparmor profile to access and memory map libstdc, due to AppArmor default DENY on access causing issues. (LP: #1897302) -- Thomas Ward Sun, 27 Sep 2020 14:34:53 -0400 ** Changed in: torbrowser-launcher (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896752 Title: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896752/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896752] Re: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released
** Tags removed: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896752 Title: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896752/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896752] Re: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released
I have tested the provided torbrowser-launcher 0.3.2-9ubuntu1 build from focal-proposed on fully-updated Ubuntu 20.04 system. I am no longer able to reproduce the issue and torbrowser-launcher now works properly. ** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896752 Title: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896752/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896752] Re: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released
Hello AsciiWolf, or anyone else affected, Accepted torbrowser-launcher into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/torbrowser- launcher/0.3.2-9ubuntu1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: torbrowser-launcher (Ubuntu Focal) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896752 Title: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896752/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896752] Re: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released
** Description changed: [Impact] Because of poor version string checking, the torbrowser-launcher package fails to recognize Tor Browser 10 and later as a valid version that is 'newer' than the previous versions. As such, the torbrowser-launcher package fails to update Tor Browser. [Test Case] (1) Install torbrowser-launcher (2) Attempt to update (3) Tor Browser version check will fail, and the tor browser version won't update. [Regression Potential] Thomas Ward reviewed the python changes relevant to this and they are superior to the previous version checking system. To that end, the fix for this issue should be non-breaking with very little risk of a regression. + [racb] Version comparison code (of Tor upstream) is being changed, so we + might have missed some other area where a version comparison is + required. + [Original Bug Description] torbrowser-launcher does not work anymore since yesterday Tor Browser 10.0 release. There is already a simple fix available as a PR in the upstream GitHub repository: https://github.com/micahflee/torbrowser- launcher/pull/499 I will fix this in Focal as part of the #1896085 SRU, however it will also need to be fixed in Groovy. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896752 Title: [SRU] Version checking error in torbrowser-launcher since Tor Browser 10.0 was released To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/torbrowser-launcher/+bug/1896752/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
