[Bug 1899841] Re: Leaks memory on client disconnect while using TLS
** Changed in: icecast Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899841 Title: Leaks memory on client disconnect while using TLS To manage notifications about this bug go to: https://bugs.launchpad.net/icecast/+bug/1899841/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899841] Re: Leaks memory on client disconnect while using TLS
** Changed in: icecast2 (Debian) Status: Unknown => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899841 Title: Leaks memory on client disconnect while using TLS To manage notifications about this bug go to: https://bugs.launchpad.net/icecast/+bug/1899841/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899841] Re: Leaks memory on client disconnect while using TLS
This bug was fixed in the package icecast2 - 2.4.4-3ubuntu0.1 --- icecast2 (2.4.4-3ubuntu0.1) focal; urgency=medium * d/p/1001-ssl_error_handling.patch: - Grab a patch from upstream issue to catch all SSL errors and clear error queue on disconnect. Thanks, Jeff Elms! (LP: #1899841) -- Unit 193 Wed, 14 Oct 2020 20:16:10 -0400 ** Changed in: icecast2 (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899841 Title: Leaks memory on client disconnect while using TLS To manage notifications about this bug go to: https://bugs.launchpad.net/icecast/+bug/1899841/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899841] Re: Leaks memory on client disconnect while using TLS
Howdy, Sorry for the delay. I tried the package as it appeared in focal and reproduced the issue (no surprise, since I reported it) then tried the package from -proposed which fixed the leak. ~Unit 193 ** Tags removed: verification-needed verification-needed-focal ** Tags added: verification-done verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899841 Title: Leaks memory on client disconnect while using TLS To manage notifications about this bug go to: https://bugs.launchpad.net/icecast/+bug/1899841/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899841] Re: Leaks memory on client disconnect while using TLS
Hello Unit, or anyone else affected, Accepted icecast2 into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/icecast2/2.4.4-3ubuntu0.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: icecast2 (Ubuntu Focal) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899841 Title: Leaks memory on client disconnect while using TLS To manage notifications about this bug go to: https://bugs.launchpad.net/icecast/+bug/1899841/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899841] Re: Leaks memory on client disconnect while using TLS
Sponsored, with some tweaks as agreed with Unit 193 on IRC. Now awaiting for SRU review. Sorry I can't do this now, as I'm not supposed to SRU review what I sponsored myself, so it'll need to wait for another SRU team member. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899841 Title: Leaks memory on client disconnect while using TLS To manage notifications about this bug go to: https://bugs.launchpad.net/icecast/+bug/1899841/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899841] Re: Leaks memory on client disconnect while using TLS
** Description changed: Howdy, When one has TLS enabled, icecast2 leaks memory on client disconnect. Given the nature of a streaming server this happens all the time. There are two ways to solve this, one would be to switch to using OpenSSL rather than WolfSSL, while the other would be to apply a tiny patch that was written by one of the WolfSSL contributors and is attached. I tested both solutions and they most certainly do solve the problem. One can easily test by setting up icecast2, connecting a source client, then creating a loop with wget to generate a lot of connect/disconnect noise. [Impact] Anyone that uses TLS will be affected by a memory leak. [Test Case] Set up icecast2 with TLS and hook up a source client such as ices2, darkice, boodler, etc. Quickly connect and disconnect some clients: for i in `seq 1 300`;do timeout 3 wget -O /dev/null https://DOMAIN.TLD :TLS-PORT/STREAM-MOUNT;done And watch the memory increase. [Regression Potential] Well it's a minimal patch, so topping OOM'ing due to too many clients is going to be hard to beat. If switching to OpenSSL, this is perhaps a bigger change due to switching out TLS backends, but perhaps has been tested more. - Code that handles edge case SSL protocol handling is being adjusted. + Code that handles edge case SSL protocol handling is being adjusted. Any + regressions are likely to manifest in this area. ~Unit 193 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899841 Title: Leaks memory on client disconnect while using TLS To manage notifications about this bug go to: https://bugs.launchpad.net/icecast/+bug/1899841/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899841] Re: Leaks memory on client disconnect while using TLS
This is fixed in 2.4.4-4 in Groovy onwards by Debian switching the package to OpenSSL. ** Description changed: Howdy, When one has TLS enabled, icecast2 leaks memory on client disconnect. Given the nature of a streaming server this happens all the time. There are two ways to solve this, one would be to switch to using OpenSSL rather than WolfSSL, while the other would be to apply a tiny patch that was written by one of the WolfSSL contributors and is attached. I tested both solutions and they most certainly do solve the problem. One can easily test by setting up icecast2, connecting a source client, then creating a loop with wget to generate a lot of connect/disconnect noise. - [Impact] - Anyone that uses TLS will be affected. - + Anyone that uses TLS will be affected by a memory leak. [Test Case] Set up icecast2 with TLS and hook up a source client such as ices2, darkice, boodler, etc. Quickly connect and disconnect some clients: for i in `seq 1 300`;do timeout 3 wget -O /dev/null https://DOMAIN.TLD :TLS-PORT/STREAM-MOUNT;done And watch the memory increase. - [Regression Potential] Well it's a minimal patch, so topping OOM'ing due to too many clients is going to be hard to beat. If switching to OpenSSL, this is perhaps a bigger change due to switching out TLS backends, but perhaps has been tested more. + Code that handles edge case SSL protocol handling is being adjusted. ~Unit 193 ** Also affects: icecast2 (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: icecast2 (Ubuntu) Status: New => Fix Released ** Changed in: icecast2 (Ubuntu Focal) Status: New => In Progress ** Changed in: icecast2 (Ubuntu Focal) Assignee: (unassigned) => Unit 193 (unit193) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899841 Title: Leaks memory on client disconnect while using TLS To manage notifications about this bug go to: https://bugs.launchpad.net/icecast/+bug/1899841/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899841] Re: Leaks memory on client disconnect while using TLS
** Description changed: Howdy, When one has TLS enabled, icecast2 leaks memory on client disconnect. Given the nature of a streaming server this happens all the time. There are two ways to solve this, one would be to switch to using OpenSSL rather than WolfSSL, while the other would be to apply a tiny patch that was written by one of the WolfSSL contributors and is attached. I tested both solutions and they most certainly do solve the problem. One can easily test by setting up icecast2, connecting a source client, then creating a loop with wget to generate a lot of connect/disconnect noise. + [Impact] + + Anyone that uses TLS will be affected. + + + [Test Case] + + Set up icecast2 with TLS and hook up a source client such as ices2, + darkice, boodler, etc. + + Quickly connect and disconnect some clients: + + for i in `seq 1 300`;do timeout 3 wget -O /dev/null https://DOMAIN.TLD + :TLS-PORT/STREAM-MOUNT;done + + And watch the memory increase. + + + [Regression Potential] + + Well it's a minimal patch, so topping OOM'ing due to too many clients is + going to be hard to beat. + + If switching to OpenSSL, this is perhaps a bigger change due to + switching out TLS backends, but perhaps has been tested more. + + ~Unit 193 ** Patch added: "icecast2.debdiff" https://bugs.launchpad.net/debian/+source/icecast2/+bug/1899841/+attachment/5422340/+files/icecast2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899841 Title: Leaks memory on client disconnect while using TLS To manage notifications about this bug go to: https://bugs.launchpad.net/icecast/+bug/1899841/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs