This bug was fixed in the package librelp - 1.5.0-1ubuntu2.20.04.2
---
librelp (1.5.0-1ubuntu2.20.04.2) focal; urgency=medium
* Reduce message count in tests/(tls-)basic-realistic.sh so they reliably
succeed on slow platforms like riscv64. (LP: #1912969)
-
This bug was fixed in the package librelp - 1.5.0-1ubuntu2.20.10.1
---
librelp (1.5.0-1ubuntu2.20.10.1) groovy; urgency=medium
* Fix file descriptor leak as sockets are stuck in CLOSE_WAIT
due to not being closed properly due to memory leak. (LP: #1908473)
-
Performing verification for Focal.
I installed rsyslog-relp 8.2001.0-1ubuntu1.1 and librelp0 1.5.0-1ubuntu2
from -updates.
>From there I set up the configuration file, launched a new rsyslog
instance, and used netcat to set 100 packets to the relp port.
https://paste.ubuntu.com/p/HfSDvNJzpX/
Hello Matthew, or anyone else affected,
Accepted librelp into focal-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/librelp/1.5.0-1ubuntu2.20.04.2 in a
few hours, and then in the -proposed repository.
Please help us by testing this new package. See
Thanks again, Matthew.
I've reviewed and sponsored the new debdiff for Focal, with the existing
changes (so we have .20.04.1 and .2 in the same upload, going in focal-
proposed again.)
Further details added in bug 1912969.
--
You received this bug notification because you are a member of
Hi Mauricio,
I filed bug 1912969 to fix the FTBFS for librelp on focal. Adjusting the
packets down from 50,000 to 10,000 makes the build succeed on riscv64.
I attached two debdiffs, one an incremental patch from
1.5.0-1ubuntu2.20.04.1, and the other a full patch from 1.5.0-1ubuntu2.
Please
Hi Matthew,
Thanks for the analysis.
We'll need such changes on top of what's in -proposed (ie, in an
incremental version), re-uploaded.
Please see `dpkg-buildpackage -v` to generate a package build including
the version in -proposed plus the new version with the workaround for
the test-case.
Hi Mauricio,
It seems riscv64 passes on Groovy due to tests being skipped on the
riscv64 architecture.
>From Groovy's build log:
https://paste.ubuntu.com/p/NCJPDVSbSW/
If you look at the man page for dh_auto_test it mentions:
If the DEB_BUILD_OPTIONS environment variable contains nocheck, no
Hi Matthew,
I've kicked one or two rebuilds today, and still see the (same) one or
two tests failing.
I'm out this week so can't look much more into it (althogh I'm
admittedly curious about it :)
If you can take a look at these FTBFS test case failures, that would be
awesome; all archs must
Performing verification for Focal
I installed rsyslog-relp 8.2001.0-1ubuntu1.1 and librelp0 1.5.0-1ubuntu2
from -updates.
>From there I set up the configuration file, launched a new rsyslog instance,
>and
used netcat to set 100 packets to the relp port.
https://paste.ubuntu.com/p/jCs9Dy6FYF/
** Tags removed: verification-needed
** Tags added: verification-done
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908473
Title:
rsyslog-relp: imrelp module leaves sockets in CLOSE_WAIT state
Performing verification for librelp in Groovy.
I installed rsyslog-relp 8.2006.0-2ubuntu1 and librelp 1.5.0-1ubuntu2
from -updates to reproduce:
https://paste.ubuntu.com/p/gtn4rcXc72/
>From there I set up the configuration script, ran a new instance of
rsyslog, and used netcat to open 100
I tested this on Focal. I installed librelp0 and restart rsyslog. Prior
to the change, sockets were stacking up in CLOSE-WAIT (both from normal
use and from the netcat test). After the change, sockets are being
closed correctly.
** Tags removed: verification-needed-focal
** Tags added:
Same one failure on today's rebuild. Strange, since this is the exact
same code as Groovy.
** Attachment added:
"buildlog_ubuntu-focal-riscv64.librelp_1.5.0-1ubuntu2.20.04.1_BUILDING.txt.gz.5"
Now the two tests failed again.
I have to EOD, and this might benefit from some delay, in case the transient
condition just goes away.
Also, let's not overload the riscv64 builder with this so other builds can move
on.
We have 7 days in -proposed to look at this in more detail (or the bad
Same one failure, re-building again.
** Attachment added:
"buildlog_ubuntu-focal-riscv64.librelp_1.5.0-1ubuntu2.20.04.1_BUILDING.txt.gz.3"
and now it had only 1 failure in the test suite,
thus indeed a transient/arch-specific flakiness.
re-building once again.
$ zgrep '^FAIL: .*sh$'
buildlog_ubuntu-focal-riscv64.librelp_1.5.0-1ubuntu2.20.04.1_BUILDING.txt.gz.*
buildlog_ubuntu-focal-
focal/riscv64 had 2 failures in the test suite.
i've requested a re-build so it runs again, as
it seems more related to the arch or something
transient than the patchset, as only this arch
and release hit it.
(groovy: all archs ok, focal: other archs ok)
attaching build log for ref (it's lost on
Hello Matthew, or anyone else affected,
Accepted librelp into groovy-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/librelp/1.5.0-1ubuntu2.20.10.1 in a
few hours, and then in the -proposed repository.
Please help us by testing this new package. See
** Patch added: "lp1908473_librelp_groovy.debdiff"
https://bugs.launchpad.net/ubuntu/+source/rsyslog/+bug/1908473/+attachment/5453105/+files/lp1908473_librelp_groovy.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
** Patch added: "lp1908473_librelp_focal.debdiff"
https://bugs.launchpad.net/ubuntu/+source/rsyslog/+bug/1908473/+attachment/5453106/+files/lp1908473_librelp_focal.debdiff
** Description changed:
[Impact]
In recent versions of rsyslog and librelp, the imrelp module leaks file
Matthew, thanks for the great work in this bug and patches.
Uploaded to Groovy and Focal w/ trivial changes; attached.
cheers,
Mauricio
...
debdiffs:
I've modified the patch files slightly, as we discussed;
- keep the commit messages;
- use its/patch headers for DEP3, adding Origin: /
This bug was fixed in the package librelp - 1.9.0-1ubuntu1
---
librelp (1.9.0-1ubuntu1) hirsute; urgency=medium
* Merge from Debian unstable. (LP: #1910307)
Remaining changes:
[ William Grant ]
- d/p/shrink-receiver-abort-tests.sh: Reduce message count
so tests
** Tags added: sts-sponsor-mfo
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908473
Title:
rsyslog-relp: imrelp module leaves sockets in CLOSE_WAIT state which
leads to file descriptor leak
To
The attachment "Debdiff for librelp on Groovy" seems to be a debdiff.
The ubuntu-sponsors team has been subscribed to the bug report so that
they can review and hopefully sponsor the debdiff. If the attachment
isn't a patch, please remove the "patch" flag from the attachment,
remove the "patch"
The test package fixes the issue for me.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908473
Title:
rsyslog-relp: imrelp module leaves sockets in CLOSE_WAIT state which
leads to file descriptor
** Tags added: sts-sponsor
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1908473
Title:
rsyslog-relp: imrelp module leaves sockets in CLOSE_WAIT state which
leads to file descriptor leak
To
Attached is the debdiff for librelp for Focal
** Patch added: "Debdiff for librelp on Focal"
https://bugs.launchpad.net/ubuntu/+source/rsyslog/+bug/1908473/+attachment/5449602/+files/librelp_focal.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs, which
Attached is the debdiff for librelp for Groovy
** Patch added: "Debdiff for librelp on Groovy"
https://bugs.launchpad.net/ubuntu/+source/rsyslog/+bug/1908473/+attachment/5449601/+files/librelp_groovy.debdiff
--
You received this bug notification because you are a member of Ubuntu
Bugs,
** Description changed:
[Impact]
In recent versions of rsyslog and librelp, the imrelp module leaks file
descriptors due to a bug where it does not correctly close sockets, and
instead, leaves them in the CLOSE_WAIT state.
This causes rsyslogd on busy servers to eventually hit the
Since we only need to change librelp to fix the problem, we won't SRU
the testcase to Focal's rsyslog, since there is no need to risk a
regression for a testcase, which would effectively be a no-change
rebuild.
The testcase is already present in rsyslog on Groovy and Hirsute,
marking as released.
31 matches
Mail list logo
