[Bug 1914808] Re: [MIR] marisa

2021-05-05 Thread Didier Roche
Override component to main libmarisa0 0.2.6-3~exp2ubuntu2 in impish amd64: universe/libs/extra/100% -> main libmarisa0 0.2.6-3~exp2ubuntu2 in impish arm64: universe/libs/extra/100% -> main libmarisa0 0.2.6-3~exp2ubuntu2 in impish armhf: universe/libs/extra/100% -> main libmarisa0

[Bug 1914808] Re: [MIR] marisa

2021-04-11 Thread Gunnar Hjalmarsson
Thanks for your review, Seth! With that it will be possible to enable opencc support to ibus-libpinyin (bug #1923187). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1914808 Title: [MIR] marisa To

[Bug 1914808] Re: [MIR] marisa

2021-04-08 Thread Seth Arnold
I reviewed marisa 0.2.6-3~exp2ubuntu2 as checked into hirsute. This shouldn't be considered a full audit but rather a quick gauge of maintainability. marisa is a trie-based datastructure. There's both a library package and command line interfaces as well as bindings for ruby, python, and

[Bug 1914808] Re: [MIR] marisa

2021-04-06 Thread Seth Arnold
** Attachment added: "coverity.txt" https://bugs.launchpad.net/ubuntu/+source/marisa/+bug/1914808/+attachment/5484982/+files/coverity.txt -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1914808

[Bug 1914808] Re: [MIR] marisa

2021-02-08 Thread Christian Ehrhardt 
Indeed Gunnar (seb128 gave me the same hint). I was distracted by the full page of no-tests entries after dh_auto_test , but you are right it is there. One todo gone, yet we still wait for security. -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1914808] Re: [MIR] marisa

2021-02-08 Thread Gunnar Hjalmarsson
Thanks for the review, Christian! On 2021-02-08 13:42, Christian Ehrhardt  wrote: > Recommended TODOs: > - upstream provides tests in test/*, could those be enabled at build > time? As far as I can see they are already enabled via dh_auto_test. From the amd64 build log: PASS: io-test PASS:

[Bug 1914808] Re: [MIR] marisa

2021-02-08 Thread Christian Ehrhardt 
[Summary] MIR Team ack to this package. This does need a security review, so I'll assign ubuntu-security List of specific binary packages to be promoted to main: libmarisa0 Recommended TODOs: - upstream provides tests in test/*, could those be enabled at build time? [Duplication] There is no

[Bug 1914808] Re: [MIR] marisa

2021-02-08 Thread Sebastien Bacher
** Description changed: - Please include the marisa source package in Ubuntu's component main. + * Availability - This is actually a follow-up of bug #1909665: I overlooked that - libopencc1.1 depends on libmarisa0, which is the only binary that needs - to be promoted to main due to this MIR.