[Bug 1915693] Re: [MIR] libayatana-indicator
** Changed in: libayatana-indicator (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915693 Title: [MIR] libayatana-indicator To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libayatana-indicator/+bug/1915693/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915693] Re: [MIR] libayatana-indicator
Just as a follow up there is no warning on the current version now when building with GTK3 (GTK2 being legacy the deprecating warning aren't going to be solved until we are done porting the archive to a newer GTK and stop build that variant) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915693 Title: [MIR] libayatana-indicator To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libayatana-indicator/+bug/1915693/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915693] Re: [MIR] libayatana-indicator
Ack from MIR team side. ** Changed in: libayatana-indicator (Ubuntu) Status: New => Fix Committed ** Changed in: libayatana-indicator (Ubuntu) Assignee: Didier Roche (didrocks) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915693 Title: [MIR] libayatana-indicator To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libayatana-indicator/+bug/1915693/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915693] Re: [MIR] libayatana-indicator
I'm forwarded the deprecation upstream now and I explained in the previous comment (and in private message now) why I think we should move forward and accept it in the current state which is still an improvement over what we ship today. Reassigning for MIR approval, hopefully we agree ** Changed in: libayatana-indicator (Ubuntu) Status: Incomplete => New ** Changed in: libayatana-indicator (Ubuntu) Assignee: Sebastien Bacher (seb128) => Didier Roche (didrocks) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915693 Title: [MIR] libayatana-indicator To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libayatana-indicator/+bug/1915693/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915693] Re: [MIR] libayatana-indicator
The deprecation warnings issue is reported upstream now https://github.com/AyatanaIndicators/libayatana-indicator/issues/40 Unless I'm misreading the buildlog here is one warning about the use of GTypeDebugFlags and one about GTimeVal on test-loaders.c and similar on test-desktop-shortcuts.c, I would say it's a limited number compared to most desktop projects and it's also limited to tests. While I agree on fixing deprecations if possible I'm not convinced that Werror is the right solution, as we know from past experience it just leads to things randomly start to fail build on toolchain changes which create high priority items to resolve for things that often don't impact directly users. (warnings about real code problems are different since they point to real problems) ** Bug watch added: github.com/AyatanaIndicators/libayatana-indicator/issues #40 https://github.com/AyatanaIndicators/libayatana-indicator/issues/40 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915693 Title: [MIR] libayatana-indicator To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libayatana-indicator/+bug/1915693/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915693] Re: [MIR] libayatana-indicator
[Summary] Some recommendations to look at before final MIR ack. We can take the time to get them fixed as the request is not urgent. The code didn’t change that much compared to our original projects already in main. Think of demoting the ones we have when handling the transition (probably next cycle) Notes: We should only promote the libayatana-indicator3* flavors, not libayatana-indicator which are depending on gtk2. Recommended TODO: - Can we get the tests building with -Werror and fixing the warnings there? - There are quite some deprecation warnings, would be great to get those fixed upstream. [Duplication] There is one package that is providing the exact same functionality, but it will be replaced by that one. [Dependencies] OK: - no other Dependencies to MIR due to this no -dev/-debug/-doc packages that need exclusion [Embedded sources and static linking] OK: - no embedded source present - no static linking [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not parse data formats - does not open a port - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) [Common blockers] OK: - does not FTBFS currently (apart from tests failing, see below) - does have a test suite that runs at build time. Test suite is currently failing: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982845 - test suite fails will fail the build upon error. - does not have a test suite that runs as autopkgtest, but similar than current situation - The package will have a team bug subscriber - no translation present, but none needed for this case (user visible)? - not a python/go package, no extra constraints to consider in that regard Problems: - Ensure test suite is fixed in debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982845 [Packaging red flags] OK: - Ubuntu does not carry a delta - symbols tracking is in place - d/watch is present and looks ok - Upstream update history is good - Debian/Ubuntu update history is good - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far - no massive Lintian warnings - d/rules is rather clean even if support 2 builds (gtk2 and gtk3) - Does not have Built-Using [Upstream red flags] OK: - no Errors / some deprecation warnings during the build. Tests are built without -Werror (distro-patch) - no incautious use of malloc/sprintf (as far as I can check it) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH - no use of user nobody - no use of setuid - no important open bugs (crashers, etc) in Debian or Ubuntu - no dependency on webkit, qtwebkit, seed or libgoa-* - not part of the UI for extra checks Problems: - Can we get the tests building with -Werror and fixing the warnings there? - There are quite some deprecation warnings, would be great to get those fixed upstream. ** Bug watch added: Debian Bug tracker #982845 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982845 ** Changed in: libayatana-indicator (Ubuntu) Assignee: Didier Roche (didrocks) => Sebastien Bacher (seb128) ** Changed in: libayatana-indicator (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915693 Title: [MIR] libayatana-indicator To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libayatana-indicator/+bug/1915693/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915693] Re: [MIR] libayatana-indicator
** Changed in: libayatana-indicator (Ubuntu) Assignee: (unassigned) => Didier Roche (didrocks) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915693 Title: [MIR] libayatana-indicator To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libayatana-indicator/+bug/1915693/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
