[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
https://kernel.ubuntu.com/git/ubuntu/autotest-client- tests.git/commit/?id=a2bc8326c70f673744173df772c8026cbb4f10dd ** Changed in: ubuntu-kernel-tests Assignee: (unassigned) => Ian (ian-may) ** Changed in: ubuntu-kernel-tests Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
This bug was fixed in the package linux - 5.8.0-49.55 --- linux (5.8.0-49.55) groovy; urgency=medium * groovy/linux: 5.8.0-49.55 -proposed tracker (LP: #1921053) * selftests: bpf verifier fails after sanitize_ptr_alu fixes (LP: #1920995) - bpf: Simplify alu_limit masking for pointer arithmetic - bpf: Add sanity check for upper ptr_limit - bpf, selftests: Fix up some test_verifier cases for unprivileged * Packaging resync (LP: #1786013) - update dkms package versions * improper memcg accounting causes NULL pointer derefs (LP: #1918668) - SAUCE: Revert "mm: memcg/slab: optimize objcg stock draining" * kernel: Enable CONFIG_BPF_LSM on Ubuntu (LP: #1905975) - [Config] Enable CONFIG_BPF_LSM * Groovy update: upstream stable patchset 2021-03-10 (LP: #1918516) - gpio: mvebu: fix pwm .get_state period calculation - HID: wacom: Correct NULL dereference on AES pen proximity - media: v4l2-subdev.h: BIT() is not available in userspace - RDMA/vmw_pvrdma: Fix network_hdr_type reported in WC - kernel/io_uring: cancel io_uring before task works - io_uring: dont kill fasync under completion_lock - objtool: Don't fail on missing symbol table - mm/page_alloc: add a missing mm_page_alloc_zone_locked() tracepoint - mm: fix a race on nr_swap_pages - tools: Factor HOSTCC, HOSTLD, HOSTAR definitions - iwlwifi: provide gso_type to GSO packets - tty: avoid using vfs_iocb_iter_write() for redirected console writes - ACPI: sysfs: Prefer "compatible" modalias - kernel: kexec: remove the lock operation of system_transition_mutex - ALSA: hda/realtek: Enable headset of ASUS B1400CEPE with ALC256 - ALSA: hda/via: Apply the workaround generically for Clevo machines - parisc: Enable -mlong-calls gcc option by default when !CONFIG_MODULES - media: cec: add stm32 driver - media: hantro: Fix reset_raw_fmt initialization - media: rc: fix timeout handling after switch to microsecond durations - media: rc: ite-cir: fix min_timeout calculation - media: rc: ensure that uevent can be read directly after rc device register - ARM: dts: tbs2910: rename MMC node aliases - ARM: dts: ux500: Reserve memory carveouts - ARM: dts: imx6qdl-gw52xx: fix duplicate regulator naming - wext: fix NULL-ptr-dereference with cfg80211's lack of commit() - ASoC: AMD Renoir - refine DMI entries for some Lenovo products - drm/i915: Always flush the active worker before returning from the wait - drm/i915/gt: Always try to reserve GGTT address 0x0 - drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes - net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family - s390: uv: Fix sysfs max number of VCPUs reporting - s390/vfio-ap: No need to disable IRQ after queue reset - PM: hibernate: flush swap writer after marking - x86/entry: Emit a symbol for register restoring thunk - efi/apple-properties: Reinstate support for boolean properties - drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs - drivers: soc: atmel: add null entry at the end of at91_soc_allowed_list[] - btrfs: fix possible free space tree corruption with online conversion - KVM: x86/pmu: Fix HW_REF_CPU_CYCLES event pseudo-encoding in intel_arch_events[] - KVM: x86/pmu: Fix UBSAN shift-out-of-bounds warning in intel_pmu_refresh() - KVM: nVMX: Sync unsync'd vmcs02 state to vmcs12 on migration - KVM: x86: get smi pending status correctly - KVM: Forbid the use of tagged userspace addresses for memslots - xen: Fix XenStore initialisation for XS_LOCAL - leds: trigger: fix potential deadlock with libata - arm64: dts: broadcom: Fix USB DMA address translation for Stingray - mt7601u: fix kernel crash unplugging the device - mt7601u: fix rx buffer refcounting - iwlwifi: Fix IWL_SUBDEVICE_NO_160 macro to use the correct bit. - drm/i915/gt: Clear CACHE_MODE prior to clearing residuals - drm/i915/pmu: Don't grab wakeref when enabling events - net/mlx5e: Fix IPSEC stats - ARM: dts: imx6qdl-kontron-samx6i: fix pwms for lcd-backlight - drm/nouveau/svm: fail NOUVEAU_SVM_INIT ioctl on unsupported devices - drm/i915: Check for all subplatform bits - drm/i915/selftest: Fix potential memory leak - uapi: fix big endian definition of ipv6_rpl_sr_hdr - KVM: Documentation: Fix spec for KVM_CAP_ENABLE_CAP_VM - tee: optee: replace might_sleep with cond_resched - xen-blkfront: allow discard-* nodes to be optional - clk: mmp2: fix build without CONFIG_PM - clk: qcom: gcc-sm250: Use floor ops for sdcc clks - ARM: imx: build suspend-imx6.S with arm instruction set - ARM: zImage: atags_to_fdt: Fix node names on added root nodes - netfilter: nft_dynset: add timeout extension to template - Revert "RDMA/mlx5: Fix devlink deadlock on net namespace deletion" - xfrm: Fix oops in
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
Since it's just a tool issue for the moment, and I can run the bpf test manually with the corrected make command. I will flip the status to verified. Thanks ** Tags removed: verification-needed-groovy ** Tags added: verification-done-groovy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
Nice catch on that cause 670b0872ad88 ("UBUNTU: SAUCE: selftests:
Skip BPF seftests by default"), in which we make the bpf subset as
a default skip target by default. (This explained why this works in comment #13)
I prefer to keep TARGETS=bpf and add an empty SKIP_TARGETS= to the
make command to override the default value, so that we can still
align with how we start a kernel-selftests subset (like in the
ubuntu_kernel_selftests).
e.g.
utils.make('-C linux/tools/testing/selftests TARGETS=bpf SKIP_TARGETS= clean
all')
A SKIP_TARGETS= might be helpful for pepole to know this is for
overriding the default value as well.
Thanks
Sam
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1917609
Title:
[Regression] ubuntu_bpf failed to build on Groovy
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
** Changed in: ubuntu-kernel-tests Assignee: Po-Hsu Lin (cypressyew) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
** Changed in: ubuntu-kernel-tests Assignee: (unassigned) => Po-Hsu Lin (cypressyew) ** Changed in: ubuntu-kernel-tests Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
Looks like the following commit impacted bpf on groovy 670b0872ad88481a5c2bdaba7bd29defc755ce64 UBUNTU: SAUCE: selftests: Skip BPF seftests by default this patch causes the following to no longer work sudo make -C linux/tools/testing/selftests TARGETS=bpf clean all Confirmed the following does still work sudo make -C linux/tools/testing/selftests/bpf clean all preparing patch for autotest-client-tests/ubuntu_bpf -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
Still happening with linux-azure 5.8.0-1027.29. ** Tags added: azure sru-20210315 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
Oh! interestingly with SKIP_TARGETS= added to the make command it looks like this is working now, we might need to adjust our test case. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
Hello Kelsey, I tried to run the ubuntu_bpf test on a Groovy VM as well, but it's still not working with the following error message: HDRINST usr/include/asm/ioctls.h HDRINST usr/include/asm/sockios.h HDRINST usr/include/asm/termios.h HDRINST usr/include/asm/poll.h INSTALL ./usr/include make[1]: Leaving directory '/home/ubuntu/autotest/client/tmp/ubuntu_bpf/src/linux' make: *** [Makefile:159: all] Error 1 Please find attachment for the complete build log. I think it's worthy to discuss about this Klebers. ** Attachment added: "ubuntu-bpf-build.log" https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1917609/+attachment/5486055/+files/ubuntu-bpf-build.log -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
Verified the patch is in G/azure (5.8.0-1027.29-azure) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
Hello, I can still see this failure on Groovy Azure kernel (5.8.0-1027.29-azure), do we have this patch applied to groovy variants? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed- groovy' to 'verification-done-groovy'. If the problem still exists, change the tag 'verification-needed-groovy' to 'verification-failed- groovy'. If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you! ** Tags added: verification-needed-groovy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
** Tags removed: kqa-blocker -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
** Changed in: linux (Ubuntu Groovy) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
** Changed in: linux (Ubuntu Groovy) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
Patch sent to the ML: https://lists.ubuntu.com/archives/kernel-team/2021-March/117753.html ** Changed in: linux (Ubuntu Groovy) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
** Description changed: + [Impact] + Upstream commit d3bec0138bfbe58606fc1d6f57a4cdc1a20218db (bpf: Zero-fill re-used per-cpu map element) was applied to Groovy as part of an upstream stable update. This patch fixes a bpf issue and at the same time adds new selftests to verify these changes. However, the selftests can't be compiled on 5.8 due to missing helper functions that were added only later. The bpf selftest build fails with errors such as: + + /usr/bin/ld: /tmp/autopkgtest.IzBxE1/build.8NX/src/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/bpf/map_init.test.o: in function `prog_run_insert_elem': + /tmp/autopkgtest.IzBxE1/build.8NX/src/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/bpf/prog_tests/map_init.c:89: undefined reference to `ASSERT_OK' + + [Fix] + The proposed fix it to partially revert this commit by removing the selftests parts. + + [Testcase] + On a groovy/linux repo: + + $ make -C tools/testing/selftests TARGETS=bpf SKIP_TARGETS= + + [Where problems could occur] + By removing the selftests we could be introducing a regression with the bpf code change which would be likely unoticed during the tests. + + + Original Description + Issue found on 5.8.0-1024.26-azure / 5.8.0-1022.23-oracle Test failed to build, I didn't see any meaningful error message, this might need to be double checked. HDRINST usr/include/asm/fcntl.h HDRINST usr/include/asm/termbits.h HDRINST usr/include/asm/errno.h INSTALL ./usr/include make[1]: Leaving directory '/home/ubuntu/autotest/client/tmp/ubuntu_bpf/src/linux' make: Leaving directory '/home/ubuntu/autotest/client/tmp/ubuntu_bpf/src/linux/tools/testing/selftests' stderr: make: *** [Makefile:159: all] Error 1 Please find attachment for the complete test log. == Process to reproduce this == 1. git clone git://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/groovy 2. cd groovy/tools/testing/selftests 3. make TARGETS=bpf You will see the build failed if it's affected by this. I think this is affecting the ubuntu_kernel_selftests as well, as the net test would require the bpf test to be built first. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
** Changed in: linux (Ubuntu) Status: Incomplete => Confirmed ** Changed in: linux (Ubuntu) Status: Confirmed => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1917609] Re: [Regression] ubuntu_bpf failed to build on Groovy
** Also affects: linux (Ubuntu) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Groovy) Importance: Undecided Status: New ** Changed in: linux (Ubuntu Groovy) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1917609 Title: [Regression] ubuntu_bpf failed to build on Groovy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
