[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
@ddstreet yep I've checked that ( [:1] or something else ) This issue is only happening when back storage is LVM. If it is not lvm, it is ok, only with lvm, pexepct returns weird string 2021-03-17 20:43:34 stderr: [error] Arguments: ([' ', '<3ef-46ca-87c8-19171950592f --pool maas_guest_lvm_vg', "error: command 'attach-disk' doesn't support option --pool"],) I've checked MAAS code first at the time, but pexpect related code showed me the same result everywhere. So I suspected that it is underlying issue. and compared libraries in maas snap, then I found out libreadline patch attached in this LP. ( as libradline is related to running command ) But I still can't find original libreadline reproducer or link between maas and libreadline yet. I've asked this to libreadline's maintainer ( this patch's auther) but he also doesn't know, and the mentioned that this could be a side effect of patch. Thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
> I've changed it for testing and MAAS didn't work properly. did you investigate why? did you also adjust the code as i mentioned in comment 22? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
@ddstreet sorry I thought I replied for it. I've changed it for testing and MAAS didn't work properly. Normal functionality didn't work. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
@seyeongkim did you have a chance to look at using echo=False in the VirshSSH() class? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
@ddstreet Thanks for your advice, FYI, This symptom is only happening when backend storage is LVM, it is ok when we just use local storage And I've checked decoded string before but it was the same (error). LVM has error, local is ok But I'm trying to test you mentioned Thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
> Can you try changing the VirshSSH() class constructor so that it passes echo=False to its superclass constructor, and see if that helps? also - it seems like the class is trying to work around the fact it's not disabling echo, by eliding the first line of the reply, in the run() method - that will most likely need to be changed to simply use the entire 'result' instead of just 'result[1:]'. In fact the splitlines() followed by '\n'.join() probably should be removed and just return the entire decoded string. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
@seyeongkim, after reviewing this bug and looking at some of the data as well as maas and pexpect code, it seems to me like this isn't related to readline, I think the problem is maas is using pexpect without disabling echo. Can you try changing the VirshSSH() class constructor so that it passes echo=False to its superclass constructor, and see if that helps? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
** Tags removed: sts-sponsor-ddstreet ** Tags added: sts-sponsor-dgadomski -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
@ddstreet Thanks for your remind. I also researching how to find proper reproducer for this issue I only checked that this patch fixed the symptom while I'm using MAAS as I described here. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
** Tags added: sts-sponsor-ddstreet -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
sorry, @dgadomski has been out on vacation, i'll pick up the sponsoring work for this while he's out. @seyeongkim, can you please clean up the sru template information? @racb is correct that the current info in the sru template doesn't explain anything about what the actual readline bug is or how it fixes anything. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
SRU review I don't see any explanation anywhere of what exactly is wrong in readline in Bionic or how it is being fixed. Normally I would expect to see such an explanation in both the SRU template and in the upstream patch description that is being cherry-picked. But in this case neither are present. I don't think it's appropriate to SRU this without a full understanding of what is going on - especially when it's such a common library being patched. In particular, I don't think it's possible to assess regression risk with any confidence without a full understanding of what is being changed and why. Please could you expand on this? ** Changed in: readline (Ubuntu Bionic) Status: In Progress => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
@seyeongkim hi, I'm working on sponsoring your patch right now. I had to do some minor fixes in it: 1. Since we're adding delta in relation to Debian we should change version number to reflect that (e.g. 7.0-4ubuntu1). 2. The launchpad bug number has to follow the convention for the automation to correctly pick it up and close the bug automatically afterwards (i.e. LP: #1921658 and not "Closes: #1921658). 3. The patch header did not need the "+" signs in the beginning of the line. 4. There was a descriptive commit for one of the lines you backported (static int *local_prompt_newlines;) which you skipped. I think it should also be part of the backport as it explains why the variable is there in the first place. I'll update this bug if needed. Thanks for the patch Seyeong! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
@ddstreet
sorry for late response, I updated description.
Thanks.
** Description changed:
+ [Impact]
+
I can't compose kvm host on maas 2.8.4 ( bionic)
I upgraded twisted and related component with pip but the symptom is the
same.
MaaS 2.9.x in Focal works fine.
in 2.8.x, pexpect virsh vol-path should return [2] but returns [3]
[2]
/dev/maas_data_vg/8d4e8b04-4031-4a1b-b5f2-a8306192db11
[3]
2021-03-17 20:43:34 stderr: [error] Message: 'this is the result...\n'
2021-03-17 20:43:34 stderr: [error] Arguments: ([' ',
'<3ef-46ca-87c8-19171950592f --pool maas_guest_lvm_vg', "error: command
'attach-disk' doesn't support option --pool"],)
sometimes it fails in
- def get_volume_path(self, pool, volume):
- """Return the path to the file from `pool` and `volume`."""
- output = self.run(["vol-path", volume, "--pool", pool])
- return output.strip()
+ def get_volume_path(self, pool, volume):
+ """Return the path to the file from `pool` and `volume`."""
+ output = self.run(["vol-path", volume, "--pool", pool])
+ return output.strip()
sometimes failes in
- def get_machine_xml(self, machine):
- # Check if we have a cached version of the XML.
- # This is a short-lived object, so we don't need to worry about
- # expiring objects in the cache.
- if machine in self.xml:
- return self.xml[machine]
+ def get_machine_xml(self, machine):
+ # Check if we have a cached version of the XML.
+ # This is a short-lived object, so we don't need to worry about
+ # expiring objects in the cache.
+ if machine in self.xml:
+ return self.xml[machine]
- # Grab the XML from virsh if we don't have it already.
- output = self.run(["dumpxml", machine]).strip()
- if output.startswith("error:"):
- maaslog.error("%s: Failed to get XML for machine", machine)
- return None
+ # Grab the XML from virsh if we don't have it already.
+ output = self.run(["dumpxml", machine]).strip()
+ if output.startswith("error:"):
+ maaslog.error("%s: Failed to get XML for machine", machine)
+ return None
- # Cache the XML, since we'll need it later to reconfigure the VM.
- self.xml[machine] = output
- return output
+ # Cache the XML, since we'll need it later to reconfigure the VM.
+ self.xml[machine] = output
+ return output
I assume that run function has issue.
Command line virsh vol-path and simple pepect python code works fine.
-
Any advice for this issue?
Thanks.
- Reproducer is below.[1]
+ [Test Plan]
- [1]
+ 0) deploy Bionic and MAAS 2.8
1) Create file to be used as loopback device
sudo dd if=/dev/zero of=lvm bs=16000 count=1M
2) sudo losetup /dev/loop39 lvm
3) sudo pvcreate /dev/loop39
4) sudo vgcreate maas_data_vg /dev/loop39
5) Save below xml:
maas_guest_lvm_vg
maas_data_vg
/dev/maas_data_vg
6) virsh pool-create maas_guest_lvm_vg.xml
7) Add KVM host in MaaS
8) Attempt to compose a POD using storage pool maas_guest_lvm_vg
9) GUI will fail with:
Pod unable to compose machine: Unable to compose machine because: Failed
talking to pod: Start tag expected, '<' not found, line 1, column 1
(, line 1)
+
+ [Where problems could occer]
+
+ This patch is small peice of huge commit.
+ I tested by compiling test pkg with this patch. but actually it is kind of
underlying library ( libreadline ), so It could affect to any application using
libreadline.
+ e.g running command inside application by code can be affected.
+
+
+ [Other Info]
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1921658
Title:
Can't compose kvm host with lvm storage on maas 2.8.4
To manage notifications about this bug go to:
https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
@seyeongkim could you add the SRU template to the bug description? https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
** Changed in: readline (Ubuntu) Importance: Undecided => Medium ** Changed in: readline (Ubuntu Bionic) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1921658] Re: Can't compose kvm host with lvm storage on maas 2.8.4
** Also affects: readline (Ubuntu) Importance: Undecided Status: New ** Also affects: readline (Ubuntu Bionic) Importance: Undecided Status: New ** Changed in: readline (Ubuntu) Status: New => Fix Released ** Changed in: readline (Ubuntu Bionic) Status: New => In Progress ** Changed in: readline (Ubuntu Bionic) Assignee: (unassigned) => Seyeong Kim (seyeongkim) ** Patch added: "lp1921658_bionic.debdiff" https://bugs.launchpad.net/ubuntu/+source/readline/+bug/1921658/+attachment/5517702/+files/lp1921658_bionic.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1921658 Title: Can't compose kvm host with lvm storage on maas 2.8.4 To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1921658/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
