[Bug 1929894] Re: [TGL][EHL][ADL] Enable MEI (Intel Management Engine Interface)
@Sachin, Both the CONFIG_INTEL_MEI_DAL and CONFIG_INTEL_MEI_VIRTIO code paths have build breakages currently. I have not looked in to these failures too much yet, but the virtio one looks like missing function prototypes, or actually missing functions. This may be a patch is that is missing, or something has moved/renamed. The MEI_DAL one looks like the function pointer return type changed from "int" to "void". Looking at dal_remove(), I suspect changing the return type from int to void would be safe, but there I haven't found an upstream version of this code to compare with. With: CONFIG_INTEL_MEI_VIRTIO=m /build/focal/drivers/misc/mei/hw-virtio.c: In function 'mei_virtio_intr_enable': /build/focal/drivers/misc/mei/hw-virtio.c:178:2: error: implicit declaration of function 'virtio_config_enable'; did you mean 'virtio_config_changed'? [-Werror=implicit-function-declaration] 178 | virtio_config_enable(vdev); | ^~~~ /build/focal/drivers/misc/mei/hw-virtio.c: In function 'mei_virtio_intr_disable': /build/focal/drivers/misc/mei/hw-virtio.c:194:2: error: implicit declaration of function 'virtio_config_disable'; did you mean 'virtio_config_changed'? [-Werror=implicit-function-declaration] 194 | virtio_config_disable(vdev); | ^ | virtio_config_changed With CONFIG_INTEL_MEI_DAL=m /build/focal/drivers/misc/mei/dal/dal_class.c:800:12: error: initialization of 'void (*)(struct mei_cl_device *)' from incompatible pointer type 'int (*)(struct mei_cl_device *)' [-Werror=incompatible-pointer-types] 800 | .remove = dal_remove, |^~ /build/focal/drivers/misc/mei/dal/dal_class.c:800:12: note: (near initialization for 'dal_driver.remove') -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1929894 Title: [TGL][EHL][ADL] Enable MEI (Intel Management Engine Interface) To manage notifications about this bug go to: https://bugs.launchpad.net/intel/+bug/1929894/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1929894] Re: [TGL][EHL][ADL] Enable MEI (Intel Management Engine Interface)
@Sachin, I've looked into those two, and they seem to have been disabled because they were not building. I am looking at them again, and will see about re-enabling them. ** Changed in: intel/lookout-canyon Status: Fix Released => Triaged ** Changed in: intel/lookout-canyon Assignee: (unassigned) => Philip Cox (philcox) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1929894 Title: [TGL][EHL][ADL] Enable MEI (Intel Management Engine Interface) To manage notifications about this bug go to: https://bugs.launchpad.net/intel/+bug/1929894/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1929894] Re: [TGL][EHL][ADL] Enable MEI (Intel Management Engine Interface)
@Phil, We need the CONFIG_INTEL_MEI_DAL=m to be enabled as requested in #11, But both CONFIG_INTEL_MEI_DAL=m and CONFIG_INTEL_MEI_VIRTIO=m are seen to be disabled. Can you please check -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1929894 Title: [TGL][EHL][ADL] Enable MEI (Intel Management Engine Interface) To manage notifications about this bug go to: https://bugs.launchpad.net/intel/+bug/1929894/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1929894] Re: [TGL][EHL][ADL] Enable MEI (Intel Management Engine Interface)
@chaoqin @sachin In the linux-intel-iotg-5.15 kernel, we have the MEI support. Also, the commit d162219c655c8cf8003128a13840d6c1e183fb80 is in the linux-intel-iotg-5.15 kernel. Is there anything remaining to be done on this ticket? If not, I'd like to close it off. ubuntu@adl-s:~$ grep CONFIG_INTEL_MEI /boot/config-5.15.0-1003-intel-iotg CONFIG_INTEL_MEI=m CONFIG_INTEL_MEI_ME=m CONFIG_INTEL_MEI_TXE=m # CONFIG_INTEL_MEI_VIRTIO is not set CONFIG_INTEL_MEI_HDCP=m # CONFIG_INTEL_MEI_DAL is not set CONFIG_INTEL_MEI_WDT=m ubuntu@adl-s:~$ lsmod|grep -i mei mei_hdcp 24576 0 iwlmei 45056 2 iwlmvm,iwlwifi cfg80211 958464 4 iwlmvm,iwlmei,iwlwifi,mac80211 mei_me 40960 2 mei 135168 5 mei_hdcp,iwlmei,mei_me ubuntu@adl-s:~$ dmesg|grep -i mei [ 10.968639] mei_me :00:16.0: enabling device ( -> 0002) [ 11.143843] mei_hdcp :00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound :00:02.0 (ops i915_hdcp_component_ops [i915]) ubuntu@adl-s:~$ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1929894 Title: [TGL][EHL][ADL] Enable MEI (Intel Management Engine Interface) To manage notifications about this bug go to: https://bugs.launchpad.net/intel/+bug/1929894/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1929894] Re: [TGL][EHL][ADL] Enable MEI (Intel Management Engine Interface)
** Information type changed from Private to Public -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1929894 Title: [TGL][EHL][ADL] Enable MEI (Intel Management Engine Interface) To manage notifications about this bug go to: https://bugs.launchpad.net/intel/+bug/1929894/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
