[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-10-11 Thread Nicholas Guriev
** Description changed:

  [Impact]
  
- The newer version of Telegram Desktop, 2.9.2, has support new features
- that are worth to bring in Ubuntu (video calls, voice chats, several
- pinned messages, multiple accounts, comments in channels, auto-deleting
- messages, simple image editor).
+ The newer version of Telegram Desktop, 3.1.1, which is currently in
+ Ubuntu 21.10 (Impish Indri), provides an important support for 64-bit
+ user identifiers. In the next few weeks will register users with UID
+ more than 2 ³¹ - 1 (maximal 32-bit signed number). These users will be
+ unseen in ancient versions.
+ 
+ This version also brings many new features including video calls, voice
+ chats, streaming platform, several pinned messages, multiple accounts,
+ comments in channels, auto-deleting messages, simple image editor.
+ Unfortunately, it is huge task to extract an isolated patch which is
+ responsible for 32-bit to 64-bit migration. I suggest, on an upstream
+ author's advice, to do full update of the package.
  
  Given the nature of the project, it make sense to do regular updates in
  order to adjust changes of Telegram service and its server protocol.
  
  [Test Plan]
  
- Most testing burden rests with the upstream team. I can do smoke tests
- of the new features.
+ 1. Login as a new user with ID over the bound on a test server.
+* Provided that you are not logged in, start the app, go to Settings,
+  type blindly `testmode`.
+* Use any number matching the next format: +999661, where X means
+  any digit.
+* Provide auth code 1.
+* Choose random account name if needed, then click the "Sign Up"
+  button.
+ 2. Make sure you have gotten a long UID.
+* Look into an mtp_*.txt debug log.
+ 3. Login as an old user in another application instance.
+* Use phone +999661 and the same auth code.
+ 4. The new user writes messages to the old user. The second one receives
+them regardless of ancient version.
+ 5. The old user writes messages to the new user. The second one receives
+none of them until the old user updates their application.
  
  [Regression Potential]
  
  Leaf package. Most potential issues are occasional crashes of the
  application. The new version also offers OpenGL acceleration, but I am
  going to disable it by default to reduce hardware related problems.
  
  [Other Info]
  
  The libtgowt source package need to be backported before. It caries a
  static library for support Telegram calls. Changes in the library do not
  apply immediately and require recompiling of the telegram-desktop
  package to be in effect.

** Summary changed:

- SRU: Update Telegram Desktop to 2.9.2
+ SRU: Update Telegram Desktop to 3.1.1

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 3.1.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-10-10 Thread Nicholas Guriev
Alexey Klimenko and I checked it out on a test server and found that:

 * A new 64-bit user is unable to login with Telegram Desktop before
   v3.0.2 (beta version, was not packaged).
 * A 32-bit user with the old app do not see a new user, instead the one
   of them sees @UnsupportedUser64Bot, not real account.
 * An old user is unable to write to a new user, but a new one can. This
   is like simplex communication.
 * An old user can't distinguish different new users. They all write in
   the same dialog.
 * New users do not appear on contact list in the old app.

There may be other issues. But as for "stop working", I overestimated.
Existing installations will continue to work but with degraded
operability. There are two rather big commits which introduce 133 scheme
layer with a fix for 64-bit UIDs.

https://github.com/telegramdesktop/tdesktop/commit/a6c98f4bb44c8a5f55f86ea80f932a5d0a8be1e3
https://github.com/telegramdesktop/tdesktop/commit/e4e5c4a1d23a271dd2b38d6925917b50932191ad

Unfortunately, they do not apply cleanly against versions currently in
Ubuntu, 2.1.7 or 2.6.1. Adapting the patches will be a pretty difficult
task with unreliable result. John Preston, an upstream author, suggested
to do a full update of the package.

I know Ubuntu has backports pocket for so huge updates. But it seems the
backporting process is not started yet.

On Вс, 2021-10-10 at 16:46 +, Robie Basak wrote:
> Users who prefer the other side of the trade-off already
> have that choice via the telegram-desktop snap.

Sorry, I do not use snapd.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-10-10 Thread Robie Basak
Thank you for looking after this package in Ubuntu!

On Sun, Oct 10, 2021 at 01:57:45PM -, Nicholas Guriev wrote:
> In the next few weeks, Telegram will migrate from 32-bit user
> identifiers to 64-bit ones. Version 3.1 is the minimal that supports
> UIDs over 2 ³¹ - 1. Older version may stop working for new registered
> users. I think it is worth to have this version in Ubuntu. At least, SRU
> policy admits such updates.

"May" stop working? Will it, or won't it? I don't think it's appropriate
to speculatively update the package in a stable release unless you're
actually sure. If you do the necessary analysis and confirm that it will
actually break users in practice, that such breakage is to an
unacceptable level (eg. the package won't work at all for newly
registered users) _and_ that it's impractical to backport a fix, then I
think an SRU to a new version with the fix would be acceptable.

However, I don't think vague speculation about what _might_ break is
enough. Please figure out the detail and post a comment explaining the
detail. *If* my conditions above are clearly met from such an analysis,
then +1 for a major version update. However if a backport or patch is
practical, then that is preferable and I expect that instead. I don't
think it's acceptable to ignore that preference and jump straight to a
major version update without even looking. For example, why would a
trivial patch switching the type to a 64-bit one not be practical? I
will expect that to be explained first.

I'd also like to pre-empt the usual argument I see in this kind of
situation, which is "I prefer to maintain it this way because that's
easier/more tested upstream/whatever". While that may be true, the cost
is that users get disrupted as we break their expectations of a stable
release. We have made a choice as a project to ship and then patch
stable releases, and with that choice comes the acceptance of that
patching risk. Users who prefer the other side of the trade-off already
have that choice via the telegram-desktop snap.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-10-10 Thread Mattia Rizzolo
(moving back to "triaged" while we wait on the SRU team's answer on this
new point)

** Changed in: telegram-desktop (Ubuntu Focal)
   Status: Won't Fix => Triaged

** Changed in: libtgowt (Ubuntu Focal)
   Status: Won't Fix => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-10-10 Thread Nicholas Guriev
Hello!

In the next few weeks, Telegram will migrate from 32-bit user
identifiers to 64-bit ones. Version 3.1 is the minimal that supports
UIDs over 2 ³¹ - 1. Older version may stop working for new registered
users. I think it is worth to have this version in Ubuntu. At least, SRU
policy admits such updates.

But for now, we should sync version 3.1.1-ds-1 from Debian sid. And then
we get a chance to update the LTS release.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-09-23 Thread Robie Basak
The SRU team discussed this between themselves on 9 September. We don't
think that "new features" are appropriate in telegram-desktop in stable
Ubuntu releases, and so this is not sufficient justification for an SRU
in itself. Users generally don't expect new features to appear in stable
Ubuntu releases, and we don't think an exception is appropriate here.

If you want to continuously ship the latest telegram-desktop features to
Ubuntu users, we think that snaps would be a more appropriate solution.
If you don't want to use snaps, then you might consider the backports
pocket - subject to requirements from the backporters team as they get
their process refined and restarted.

If, however, there are specific bugs that need fixing in telegram-
desktop in a stable release, or a specific change in the Telegram
protocol that results in regressed functionality for users, then we can
consider an SRU to fix that. If this is the case then such an SRU needs
to be justified on those merits.

I'm therefore going to set the stable tasks to Won't Fix and reject the
uploads. Feel free however to repurpose this bug to fix some specific
issue that is SRU-able - in which case please provide that justification
and then reopen the bug.

** Changed in: libtgowt (Ubuntu Focal)
   Status: In Progress => Won't Fix

** Changed in: libtgowt (Ubuntu Hirsute)
   Status: In Progress => Won't Fix

** Changed in: telegram-desktop (Ubuntu Focal)
   Status: In Progress => Won't Fix

** Changed in: telegram-desktop (Ubuntu Hirsute)
   Status: In Progress => Won't Fix

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-09-20 Thread Mattia Rizzolo
reuploaded, sorry for the delay.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-09-09 Thread Brian Murray
** Tags removed: verification-needed verification-needed-hirsute

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-09-07 Thread Brian Murray
I mistakenly accepted libtgowt and asked to have it removed from the
archive. I'm sorry for the inconvenience, but could you please reupload
the package for review? Thanks.

** Changed in: libtgowt (Ubuntu Hirsute)
   Status: Fix Committed => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-09-07 Thread Brian Murray
Hello Nicholas, or anyone else affected,

Accepted libtgowt into hirsute-proposed. The package will build now and
be available at
https://launchpad.net/ubuntu/+source/libtgowt/0~git20210627.91d836d+dfsg-3ubuntu1~21.04
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, what testing has been
performed on the package and change the tag from verification-needed-
hirsute to verification-done-hirsute. If it does not fix the bug for
you, please add a comment stating that, and change the tag to
verification-failed-hirsute. In either case, without details of your
testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: libtgowt (Ubuntu Hirsute)
   Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-hirsute

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-09-05 Thread Mattia Rizzolo
** Also affects: telegram-desktop (Ubuntu Hirsute)
   Importance: Undecided
   Status: New

** Also affects: libtgowt (Ubuntu Hirsute)
   Importance: Undecided
   Status: New

** Also affects: telegram-desktop (Ubuntu Impish)
   Importance: Undecided
 Assignee: Nicholas Guriev (mymedia)
   Status: New

** Also affects: libtgowt (Ubuntu Impish)
   Importance: Undecided
 Assignee: Nicholas Guriev (mymedia)
   Status: New

** Also affects: telegram-desktop (Ubuntu Focal)
   Importance: Undecided
   Status: New

** Also affects: libtgowt (Ubuntu Focal)
   Importance: Undecided
   Status: New

** Changed in: telegram-desktop (Ubuntu Impish)
   Status: New => Fix Released

** Changed in: libtgowt (Ubuntu Impish)
   Status: New => Fix Released

** Changed in: telegram-desktop (Ubuntu Hirsute)
 Assignee: (unassigned) => Nicholas Guriev (mymedia)

** Changed in: telegram-desktop (Ubuntu Focal)
 Assignee: (unassigned) => Nicholas Guriev (mymedia)

** Changed in: libtgowt (Ubuntu Hirsute)
 Assignee: (unassigned) => Nicholas Guriev (mymedia)

** Changed in: libtgowt (Ubuntu Focal)
 Assignee: (unassigned) => Nicholas Guriev (mymedia)

** Changed in: telegram-desktop (Ubuntu Hirsute)
   Status: New => In Progress

** Changed in: telegram-desktop (Ubuntu Focal)
   Status: New => In Progress

** Changed in: libtgowt (Ubuntu Hirsute)
   Status: New => In Progress

** Changed in: libtgowt (Ubuntu Focal)
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-09-05 Thread Nicholas Guriev
** Patch added: "telegram-desktop_2.9.2+ds-1ubuntu3~21.04.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/telegram-desktop/+bug/1942699/+attachment/5523027/+files/telegram-desktop_2.9.2+ds-1ubuntu3~21.04.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-09-05 Thread Nicholas Guriev
** Patch added: "libtgowt_0~git20210627.91d836d+dfsg-3ubuntu1~21.04.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/telegram-desktop/+bug/1942699/+attachment/5523026/+files/libtgowt_0~git20210627.91d836d+dfsg-3ubuntu1~21.04.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-09-05 Thread Nicholas Guriev
** Patch added: "libtgowt_0~git20210627.91d836d+dfsg-3ubuntu1~20.04.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/telegram-desktop/+bug/1942699/+attachment/5523021/+files/libtgowt_0~git20210627.91d836d+dfsg-3ubuntu1~20.04.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-09-05 Thread Nicholas Guriev
** Patch added: "telegram-desktop_2.9.2+ds-1ubuntu3~20.04.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/telegram-desktop/+bug/1942699/+attachment/5523022/+files/telegram-desktop_2.9.2+ds-1ubuntu3~20.04.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1942699] Re: SRU: Update Telegram Desktop to 2.9.2

2021-09-05 Thread Nicholas Guriev
** Also affects: libtgowt (Ubuntu)
   Importance: Undecided
   Status: New

** Changed in: libtgowt (Ubuntu)
 Assignee: (unassigned) => Nicholas Guriev (mymedia)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1942699

Title:
  SRU: Update Telegram Desktop to 2.9.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtgowt/+bug/1942699/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs