[Bug 1945555] Re: [SRU] accept undecodable multi-block bluefs transactions on log
** Description changed:
[Impact]
Multi-block transaction could fail during unexpected power down
in this case, it should be stop replaying this log instead of throwing
unrecoverable error
[Test Case]
It's too difficult to simulate power outage during multi-block transaction on
disk, so the way I test this patch is to simulate a multi-block transaction and
trigger a decode error in
try {
- auto p = bl.cbegin();
- decode(t, p);
- seen_recs = true;
- }
+ auto p = bl.cbegin();
+ decode(t, p);
+ seen_recs = true;
+ }
Add the following line right after decode(t, p) to throw an error
throw buffer::malformed_input("error test");
According to the patch description https://github.com/ceph/ceph/pull/42830
this error will be considered as a normal bluefs log reply stop condition and
will *not* prevent OSD from starting
After the error test is triggered, OSD can still be started normally
[Where problems could occur]
- This upstream PR was created 2 months ago and Luminous was EOL upstream for a
while
- so Luminous Bluefs code is outdated, in order to backport this commit
- it might also need to backport some dependencies
+ This upstream PR was created 2 months ago and Luminous was EOL upstream for a
while, so no backport and test by upstream
+ In order to backport this commit, it also needs to backport some dependencies
[Other Info]
upstream tracker: https://tracker.ceph.com/issues/52079
PR: https://github.com/ceph/ceph/pull/42830
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/194
Title:
[SRU] accept undecodable multi-block bluefs transactions on log
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/194/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1945555] Re: [SRU] accept undecodable multi-block bluefs transactions on log
Update test case
It's too difficult to simulate power outage during multi-block transaction on
disk, so the way I test this patch is to simulate a multi-block transaction and
trigger a decode error in
try {
auto p = bl.cbegin();
decode(t, p);
seen_recs = true;
}
Add the following line right after decode(t, p) to throw an error
throw buffer::malformed_input("error test");
According to the patch description https://github.com/ceph/ceph/pull/42830
this error will be considered as a normal bluefs log reply stop condition and
will *not* prevent OSD from starting
After the error test is triggered, OSD can still be started normally
** Description changed:
[Impact]
Multi-block transaction could fail during unexpected power down
in this case, it should be stop replaying this log instead of throwing
unrecoverable error
[Test Case]
- need to simulate power outage to reproduce this issue
+ It's too difficult to simulate power outage during multi-block transaction on
disk, so the way I test this patch is to simulate a multi-block transaction and
trigger a decode error in
+ try {
+ auto p = bl.cbegin();
+ decode(t, p);
+ seen_recs = true;
+ }
+
+ Add the following line right after decode(t, p) to throw an error
+ throw buffer::malformed_input("error test");
+
+ According to the patch description https://github.com/ceph/ceph/pull/42830
+ this error will be considered as a normal bluefs log reply stop condition and
will *not* prevent OSD from starting
+ After the error test is triggered, OSD can still be started normally
[Where problems could occur]
This upstream PR was created 2 months ago and Luminous was EOL upstream for a
while
so Luminous Bluefs code is outdated, in order to backport this commit
it might also need to backport some dependencies
[Other Info]
upstream tracker: https://tracker.ceph.com/issues/52079
PR: https://github.com/ceph/ceph/pull/42830
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/194
Title:
[SRU] accept undecodable multi-block bluefs transactions on log
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/194/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1945555] Re: [SRU] accept undecodable multi-block bluefs transactions on log
The attachment "bionic1.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/194 Title: [SRU] accept undecodable multi-block bluefs transactions on log To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1945555] Re: [SRU] accept undecodable multi-block bluefs transactions on log
second patch ** Patch added: "bionic2.patch" https://bugs.launchpad.net/ubuntu/bionic/+source/ceph/+bug/194/+attachment/5533790/+files/bionic2.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/194 Title: [SRU] accept undecodable multi-block bluefs transactions on log To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1945555] Re: [SRU] accept undecodable multi-block bluefs transactions on log
This PR https://github.com/ceph/ceph/pull/42830 need an additional dependency (bionic1.patch) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/194 Title: [SRU] accept undecodable multi-block bluefs transactions on log To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1945555] Re: [SRU] accept undecodable multi-block bluefs transactions on log
first patch ** Tags added: sts sts-sru-needed verification-needed-bionic ** Patch added: "bionic1.patch" https://bugs.launchpad.net/ubuntu/bionic/+source/ceph/+bug/194/+attachment/5533789/+files/bionic1.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/194 Title: [SRU] accept undecodable multi-block bluefs transactions on log To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1945555] Re: [SRU] accept undecodable multi-block bluefs transactions on log
** Changed in: ceph (Ubuntu Bionic) Assignee: (unassigned) => gerald.yang (gerald-yang-tw) ** Changed in: ceph (Ubuntu) Assignee: (unassigned) => gerald.yang (gerald-yang-tw) ** Changed in: ceph (Ubuntu Bionic) Status: New => In Progress ** Changed in: ceph (Ubuntu) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/194 Title: [SRU] accept undecodable multi-block bluefs transactions on log To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
