[Bug 1946550] Re: tftpd-hpa sends a confusing error message if the filename is zero-length.
Hi Chris,
I agree that the current code falls through to "Missing mode" due to `while (cp
< end && *cp) {` directly skipping the loop on the *cp.
Your check makes this particular case more readable.
But carrying that only as Ubuntu Delta will potentially drive automation
mad that would not expect that answer. I'd like to encourage you to
submit the very same upstream to be proper part of the next official
version.
Upstreams readme [1] asks to discuss things on the syslinux [2] ML.
I found no other contributor hints, so I assume that would be the best place to
submit it.
If you happen to do so it would be great if you could add a link to the
ML-Archive entry here. That way one can better track what happened in
that discussion.
Ubuntu Impish is in final freeze right now anyway and we can't do much.
But I'd hope that your change is upstream accepted and then naturally gets into
Ubuntu when we pick up the new version in the next Ubuntu release.
TBH it doesn't seem severe enough to me to SRU [3] the change
afterwards.
[1]: https://salsa.debian.org/ron/tftp-hpa/-/blob/debian/README
[2]: https://lists.zytor.com/syslinux
[3]: https://wiki.ubuntu.com/StableReleaseUpdates
** Changed in: tftp-hpa (Ubuntu)
Status: New => Confirmed
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1946550
Title:
tftpd-hpa sends a confusing error message if the filename is zero-
length.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/tftp-hpa/+bug/1946550/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946550] Re: tftpd-hpa sends a confusing error message if the filename is zero-length.
The attachment "Patch adding a check for a zero-length filename and returning a better error message." seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946550 Title: tftpd-hpa sends a confusing error message if the filename is zero- length. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tftp-hpa/+bug/1946550/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946550] Re: tftpd-hpa sends a confusing error message if the filename is zero-length.
Attaching the patch I came up with. ** Patch added: "Patch adding a check for a zero-length filename and returning a better error message." https://bugs.launchpad.net/ubuntu/+source/tftp-hpa/+bug/1946550/+attachment/5531736/+files/tftpd.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946550 Title: tftpd-hpa sends a confusing error message if the filename is zero- length. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tftp-hpa/+bug/1946550/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
