[Bug 1950317] Re: [MIR] Wireguard

2022-02-28 Thread Steve Langasek
Override component to main wireguard 1.0.20210914-1ubuntu2 in jammy: universe/misc -> main wireguard 1.0.20210914-1ubuntu2 in jammy amd64: universe/net/optional/100% -> main wireguard 1.0.20210914-1ubuntu2 in jammy arm64: universe/net/optional/100% -> main wireguard 1.0.20210914-1ubuntu2 in

[Bug 1950317] Re: [MIR] Wireguard

2022-02-23 Thread Jason A. Donenfeld
apw's reasoning is correct. I do wonder, though, if at some point we can start looking into sunsetting the dkms package entirely and the wireguard-linux-compat backport with it. It's been mainlined for a good deal of time now. We'd have to do some analysis of which kernels people run Ubuntu

[Bug 1950317] Re: [MIR] Wireguard

2022-02-23 Thread Andreas Hasenack
I had a chat with apw in #ubuntu-devel[1], and it looks like keeping the current order of dkms first, then modules, is correct. This is the reason, in summary: "so that if you install this with a personal kernel, or a kernel without support you get the dkms not another kernel." The scenario

[Bug 1950317] Re: [MIR] Wireguard

2022-02-22 Thread Steve Beattie
Andreas wrote: > If you happen to have a kernel installed that has the virtual provides > for wireguard-modules, then dkms won't be pulled in. Oh nice, I missed that, thanks for pointing it out. That definitely covers my complaint there. -- You received this bug notification because you are a

[Bug 1950317] Re: [MIR] Wireguard

2022-02-22 Thread Andreas Hasenack
ubuntu-server will be subscribed to this package -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1950317 Title: [MIR] Wireguard To manage notifications about this bug go to:

[Bug 1950317] Re: [MIR] Wireguard

2022-02-22 Thread Andreas Hasenack
Seed was changed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1950317 Title: [MIR] Wireguard To manage notifications about this bug go to:

[Bug 1950317] Re: [MIR] Wireguard

2022-02-22 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~ahasenack/ubuntu-seeds/+git/platform/+merge/415920 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1950317 Title: [MIR] Wireguard To manage

[Bug 1950317] Re: [MIR] Wireguard

2022-02-22 Thread Seth Arnold
** Changed in: wireguard (Ubuntu) Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1950317 Title: [MIR] Wireguard To manage notifications about this bug go

[Bug 1950317] Re: [MIR] Wireguard

2022-02-18 Thread Andreas Hasenack
If you happen to have a kernel installed that has the virtual provides for wireguard-modules, then dkms won't be pulled in. $ dpkg -s linux-image-generic|grep wireguard-modules Provides: virtualbox-guest-modules (= 5.13.0-28), wireguard-modules (= 1.0.0), zfs-modules (= 2.0.6-1ubuntu2) -- You

[Bug 1950317] Re: [MIR] Wireguard

2022-02-18 Thread Andreas Hasenack
> One other non-security opinionated comment: having the wireguard meta package > pull in the dkms > package will likely cause people to install them unnecessarily. I asked about this in the bug[1], and on irc[2], but got no response. 1.

[Bug 1950317] Re: [MIR] Wireguard

2022-02-18 Thread Steve Beattie
One other non-security opinionated comment: having the wireguard meta package pull in the dkms package will likely cause people to install them unnecessarily. While many people will read the documentation first and realize they only need to install wireguard-tools, it's likely others will hear

[Bug 1950317] Re: [MIR] Wireguard

2022-02-18 Thread Steve Beattie
I reviewed wireguard 1.0.20210914-1ubuntu2 as checked into jammy. This shouldn't be considered a full audit but rather a quick gauge of maintainability. wireguard is the user space component of the WireGuard VPN, an in-kernel vpn. The tools provided are for querying and configuring the state of

[Bug 1950317] Re: [MIR] Wireguard

2022-01-10 Thread Christian Ehrhardt 
** Changed in: wireguard (Ubuntu) Milestone: ubuntu-22.02 => ubuntu-22.04-feature-freeze -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1950317 Title: [MIR] Wireguard To manage notifications

[Bug 1950317] Re: [MIR] Wireguard

2022-01-10 Thread Christian Ehrhardt 
Required for 22.04, setting Critical + Milestone 22.02 (FeatureFreeze) ** Changed in: wireguard (Ubuntu) Importance: Undecided => Critical ** Changed in: wireguard (Ubuntu) Milestone: None => ubuntu-22.02 -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1950317] Re: [MIR] Wireguard

2021-11-30 Thread Andreas Hasenack
Taking care of these: - build time test: https://bugs.launchpad.net/ubuntu/+source/wireguard/+bug/1952767 - dep8 test: https://bugs.launchpad.net/bugs/1952102 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1950317] Re: [MIR] Wireguard

2021-11-30 Thread Andreas Hasenack
> One thing you could do is do all the keygen inline with the script. For > example: > key1="$(pp wg genkey)" > ... Looks good, I don't need the keys in a file, and I can then use the var names in the config file I generate for wg-quick. -- You received this bug notification because you are a

Re: [Bug 1950317] Re: [MIR] Wireguard

2021-11-29 Thread Seth Arnold
On Fri, Nov 26, 2021 at 02:09:26PM -, Jason A. Donenfeld wrote: > Unit193 is really top-notch and knows the project well, is an active > participant with upstream, and generally is pretty on top of things. I > don't know whether MIRing this means some sort of hand off involved, but > I'd say

[Bug 1950317] Re: [MIR] Wireguard

2021-11-26 Thread Jason A. Donenfeld
> I was pointed at the existing debian bug requesting to drop the wireguard-dkms package The place where we still want wireguard-dkms, though, is for when people are running Ubuntu on strange kernels that might not have it out of the box. These are, of course, becoming increasingly rare. Probably

[Bug 1950317] Re: [MIR] Wireguard

2021-11-26 Thread Andreas Hasenack
There are different source packages involved: - src:wireguard produces bin:wireguard-tools and is the subject of this MIR - src:wireguard-linux-compat produces bin:wireguard-dkms. It may be the same upstream source, but it's NOT the same source package as src:wireguard I wondered if we should

[Bug 1950317] Re: [MIR] Wireguard

2021-11-26 Thread Jason A. Donenfeld
Glad to hear the result. Thanks for working through this and hearing me out on IRC as well. With regards to the TODO: > I suggest the server team to reach out to @unit193 as the MOTU who maintained Unit193 is really top-notch and knows the project well, is an active participant with upstream,

[Bug 1950317] Re: [MIR] Wireguard

2021-11-26 Thread Lukas Märdian
Review for Package: src:wireguard [Summary] Thank you for all the comments and input on this MIR! I've revisited my initial opinion after consulting with the rest of the MIR team and came to the conclusion that we should accept a certain degree of duplicated maintenance here in order to be able

[Bug 1950317] Re: [MIR] Wireguard

2021-11-25 Thread Didier Roche
With the additional DEP-8 tests and as xnox says, better integration with our default units, I do not think the duplication is harmful (apart from the extra maintainance on us) compared to what most users will do: google/look on stackoverflow and use a semi-official (due to wg being in the kernel)

[Bug 1950317] Re: [MIR] Wireguard

2021-11-24 Thread Andreas Hasenack
I just realized that we have a better DEP8 test already running, but in another source package: src:wireguard-linux-compat, which produces bin:wireguard-dkms. With wireguard now being in the kernel, I wonder if we still need the dkms one. Maybe for cases where someone wants to try a newer version

Re: [Bug 1950317] Re: [MIR] Wireguard

2021-11-24 Thread Christian Ehrhardt 
> It's suitable to run in a single VM. I'll create a PR soon. Nice, that will help to catch changes in other packages impacting wireguard to be spotted early on. BTW - the MIR team discussion has come to the conclusion that we can and want to have it along with the functionality that exists in

[Bug 1950317] Re: [MIR] Wireguard

2021-11-24 Thread Andreas Hasenack
I wrote this test that I intend to propose as a DEP8 test. Here is the output: $ sudo ./vpn Setting things up Generating keys Generating wireguard config Cleaning up old namespaces Creating new namespaces left_ns and right_ns and adding loopback interface to them Creating veth interface

[Bug 1950317] Re: [MIR] Wireguard

2021-11-23 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: wireguard (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1950317 Title:

[Bug 1950317] Re: [MIR] Wireguard

2021-11-23 Thread Lukas Märdian
Indeed our current default networking setup is lacking some functionality from "wg", that is the key generation and display of dynamic information (like "lastest-handshake" and "transfer-rx/tx" from "wg show"), while most of the other static information of a current WireGuard setup is also

[Bug 1950317] Re: [MIR] Wireguard

2021-11-23 Thread Dimitri John Ledkov
My personal opinion is that we do need tools to setup and configure wireguard from start to finish in Main. That does include tooling to generate the keys. It would be nice to further develop wireguard package such that by default it integrates with the default Ubuntu networking stack

[Bug 1950317] Re: [MIR] Wireguard

2021-11-23 Thread Jason A. Donenfeld
I agree that's pretty weird. And especially for wg(8), that's not just a configuration tool; that's the low level inspection tool. Netplan can configure IP addresses; are you going to move ip(8) out of main too? If ip(8) is in main, then wg(8) should be in main. Netplan doesn't replace the low

[Bug 1950317] Re: [MIR] Wireguard

2021-11-23 Thread Andreas Hasenack
It feels awkward to have half the wireguard code in main (kernel), and leave the configuration bits out in favor of our own tools, which probably didn't exist when the wireguard userspace tooling was created. If you go to the wireguard site, it won't teach you how to use systemd- networkd or

[Bug 1950317] Re: [MIR] Wireguard

2021-11-23 Thread Lukas Märdian
Hi Andreas, thank you for this high quality MIR! Unfortunately this is a tentative MIR team NACK, as it duplicates functionality that we already have in Ubuntu main. I understand you point of openvpn != wireguard and therefore we need wireguard VPN support in main, too. But netplan.io has been

[Bug 1950317] Re: [MIR] Wireguard

2021-11-16 Thread Christian Ehrhardt 
** Changed in: wireguard (Ubuntu) Assignee: (unassigned) => Lukas Märdian (slyon) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1950317 Title: [MIR] Wireguard To manage notifications about

[Bug 1950317] Re: [MIR] Wireguard

2021-11-16 Thread Andreas Hasenack
Update: I believe I'm able to create a better DEP8 test using a VM and network namespaces, establishing a wireguard vpn between them. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1950317 Title:

[Bug 1950317] Re: [MIR] Wireguard

2021-11-16 Thread Andreas Hasenack
** Description changed: - Placeholder bug for the upcoming wireguard MIR. + [Availability] + The package wireguard is already in Ubuntu universe, since xenial. + The package wireguard build for the architectures it is designed to work on + It currently builds and works for architetcures: amd64,