[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
bug #1964880 seems a regression due to the update -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
This bug was fixed in the package ubuntu-drivers-common - 1:0.9.6 --- ubuntu-drivers-common (1:0.9.6) jammy; urgency=medium * Drop apt in favour of the apt_pkg bindings (LP: #1963712). -- Alberto Milone Mon, 14 Mar 2022 12:15:38 +0100 ** Changed in: ubuntu-drivers-common (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
Ok, I have just uploaded the new u-d-c. Thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
Ok, I think this convinced me enough for a +1. Please proceed! Let's make sure this gets released before Beta. ** Changed in: ubuntu-drivers-common (Ubuntu) Status: Confirmed => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
Here is the output of ubuntu-drivers install, however I was not able measure the time here. The packages were installed correctly. ** Attachment added: "install" https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+attachment/5567936/+files/install -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
Output of ubuntu-drivers debug ** Attachment added: "debug" https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+attachment/5567935/+files/debug -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
Here is the output and the time it takes to run ubuntu-drivers list and ubuntu-drivers list --gpgpu ** Attachment added: "ubuntu-drivers-list.log" https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+attachment/5567928/+files/ubuntu-drivers-list.log -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
I have addressed all the concerns in the PR, and I have uploaded the changes to the PPA. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
I have also added a PPA in the description. ** Description changed: Switch from the apt bindings to the apt_pkg bindings for the ubuntu- drivers tool. This significantly improves performance (2,673s vs 13,751s , on my dated Intel Ivy Bridge i7-3770K CPU). [Attach sbuild log] [Performance data] system_driver_packages() performance for a lot of modaliases ... [0.94 s] ok system_driver_packages() performance for a lot of modaliases ... [0.96 s] ok Old detection code: :~$ time ubuntu-drivers list nvidia-driver-510, (kernel modules provided by linux-modules-nvidia-510-generic-hwe-20.04) nvidia-driver-470, (kernel modules provided by linux-modules-nvidia-470-generic-hwe-20.04) nvidia-driver-470-server, (kernel modules provided by linux-modules-nvidia-470-server-generic-hwe-20.04) real 0m13,751s user 0m13,480s sys 0m0,258s :~$ time ubuntu-drivers list nvidia-driver-510, (kernel modules provided by linux-modules-nvidia-510-generic-hwe-20.04) nvidia-driver-470-server, (kernel modules provided by linux-modules-nvidia-470-server-generic-hwe-20.04) nvidia-driver-470, (kernel modules provided by linux-modules-nvidia-470-generic-hwe-20.04) real 0m13,785s user 0m13,578s sys 0m0,196s New detection code: :~$ time ubuntu-drivers list nvidia-driver-470, (kernel modules provided by linux-modules-nvidia-470-generic-hwe-20.04) nvidia-driver-470-server, (kernel modules provided by linux-modules-nvidia-470-server-generic-hwe-20.04) nvidia-driver-510, (kernel modules provided by linux-modules-nvidia-510-generic-hwe-20.04) real 0m2,673s user 0m1,749s sys 0m0,914s :~$ time ubuntu-drivers list nvidia-driver-470-server, (kernel modules provided by linux-modules-nvidia-470-server-generic-hwe-20.04) nvidia-driver-510, (kernel modules provided by linux-modules-nvidia-510-generic-hwe-20.04) nvidia-driver-470, (kernel modules provided by linux-modules-nvidia-470-generic-hwe-20.04) real 0m2,645s user 0m1,702s sys 0m0,935s [PR] https://github.com/tseliot/ubuntu-drivers-common/pull/68 + + [PPA] + https://launchpad.net/~albertomilone/+archive/ubuntu/u-d-c-lp1963712 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
** Attachment added: "Sbuild log" https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+attachment/5566587/+files/ubuntu-drivers-common_0.9.6_amd64-2022-03-07T16%3A44%3A03Z.build ** Changed in: ubuntu-drivers-common (Ubuntu) Status: Incomplete => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
Hi Łukasz, I have just attached the sbuild log. I can certainly upload to a PPA, so that, perhaps, testing the changes will be easier. As I wrote in the description, I saw the time for a simple "ubuntu- drivers list" go down from 13,751s to 2,673s, which is quite impressive. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
** Description changed: Switch from the apt bindings to the apt_pkg bindings for the ubuntu- drivers tool. - This significantly improves performance. + This significantly improves performance (2,673s vs 13,751s , on my dated + Intel Ivy Bridge i7-3770K CPU). [Attach sbuild log] [Performance data] system_driver_packages() performance for a lot of modaliases ... [0.94 s] ok system_driver_packages() performance for a lot of modaliases ... [0.96 s] ok Old detection code: :~$ time ubuntu-drivers list nvidia-driver-510, (kernel modules provided by linux-modules-nvidia-510-generic-hwe-20.04) nvidia-driver-470, (kernel modules provided by linux-modules-nvidia-470-generic-hwe-20.04) nvidia-driver-470-server, (kernel modules provided by linux-modules-nvidia-470-server-generic-hwe-20.04) real 0m13,751s user 0m13,480s sys 0m0,258s - :~$ time ubuntu-drivers list nvidia-driver-510, (kernel modules provided by linux-modules-nvidia-510-generic-hwe-20.04) nvidia-driver-470-server, (kernel modules provided by linux-modules-nvidia-470-server-generic-hwe-20.04) nvidia-driver-470, (kernel modules provided by linux-modules-nvidia-470-generic-hwe-20.04) real 0m13,785s user 0m13,578s sys 0m0,196s - New detection code: :~$ time ubuntu-drivers list nvidia-driver-470, (kernel modules provided by linux-modules-nvidia-470-generic-hwe-20.04) nvidia-driver-470-server, (kernel modules provided by linux-modules-nvidia-470-server-generic-hwe-20.04) nvidia-driver-510, (kernel modules provided by linux-modules-nvidia-510-generic-hwe-20.04) real 0m2,673s user 0m1,749s sys 0m0,914s - :~$ time ubuntu-drivers list nvidia-driver-470-server, (kernel modules provided by linux-modules-nvidia-470-server-generic-hwe-20.04) nvidia-driver-510, (kernel modules provided by linux-modules-nvidia-510-generic-hwe-20.04) nvidia-driver-470, (kernel modules provided by linux-modules-nvidia-470-generic-hwe-20.04) real 0m2,645s user 0m1,702s sys 0m0,935s - [PR] https://github.com/tseliot/ubuntu-drivers-common/pull/68 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
** Description changed: Switch from the apt bindings to the apt_pkg bindings for the ubuntu- drivers tool. This significantly improves performance. [Attach sbuild log] [Performance data] system_driver_packages() performance for a lot of modaliases ... [0.94 s] ok system_driver_packages() performance for a lot of modaliases ... [0.96 s] ok + Old detection code: + + :~$ time ubuntu-drivers list + nvidia-driver-510, (kernel modules provided by linux-modules-nvidia-510-generic-hwe-20.04) + nvidia-driver-470, (kernel modules provided by linux-modules-nvidia-470-generic-hwe-20.04) + nvidia-driver-470-server, (kernel modules provided by linux-modules-nvidia-470-server-generic-hwe-20.04) + + real 0m13,751s + user 0m13,480s + sys 0m0,258s + + + :~$ time ubuntu-drivers list + nvidia-driver-510, (kernel modules provided by linux-modules-nvidia-510-generic-hwe-20.04) + nvidia-driver-470-server, (kernel modules provided by linux-modules-nvidia-470-server-generic-hwe-20.04) + nvidia-driver-470, (kernel modules provided by linux-modules-nvidia-470-generic-hwe-20.04) + + real 0m13,785s + user 0m13,578s + sys 0m0,196s + + + New detection code: + + :~$ time ubuntu-drivers list + nvidia-driver-470, (kernel modules provided by linux-modules-nvidia-470-generic-hwe-20.04) + nvidia-driver-470-server, (kernel modules provided by linux-modules-nvidia-470-server-generic-hwe-20.04) + nvidia-driver-510, (kernel modules provided by linux-modules-nvidia-510-generic-hwe-20.04) + + real 0m2,673s + user 0m1,749s + sys 0m0,914s + + + :~$ time ubuntu-drivers list + nvidia-driver-470-server, (kernel modules provided by linux-modules-nvidia-470-server-generic-hwe-20.04) + nvidia-driver-510, (kernel modules provided by linux-modules-nvidia-510-generic-hwe-20.04) + nvidia-driver-470, (kernel modules provided by linux-modules-nvidia-470-generic-hwe-20.04) + + real 0m2,645s + user 0m1,702s + sys 0m0,935s + + [PR] https://github.com/tseliot/ubuntu-drivers-common/pull/68 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
Hello Alberto! Thank you for filling in the FFe! Did you do a test-build of the change on some PPA that we could take a look at? And did you do a test install of the test packages so that you could provide some logs? The changes seem on one side simple, but touch a lot of the code, so I'm obviously a bit worried about any bumps. How noticeable is the performance improvement? Has this been measured? Just trying to assess the risk-to-merit ratio here ;) ** Changed in: ubuntu-drivers-common (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963712] Re: FFE: Switch from apt to apt_pkg bindings
** Description changed: Switch from the apt bindings to the apt_pkg bindings for the ubuntu- drivers tool. This significantly improves performance. [Attach sbuild log] [Performance data] + system_driver_packages() performance for a lot of modaliases ... [0.94 s] ok + system_driver_packages() performance for a lot of modaliases ... [0.96 s] ok + + [PR] + https://github.com/tseliot/ubuntu-drivers-common/pull/68 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963712 Title: FFE: Switch from apt to apt_pkg bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1963712/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
