[Bug 1974265]
Maybe a dup of PR 104435 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1974265 Title: `demangle_const` causes infinite recursion and stack overflow To manage notifications about this bug go to: https://bugs.launchpad.net/binutils/+bug/1974265/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974265] Re: `demangle_const` causes infinite recursion and stack overflow
** Changed in: binutils (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1974265 Title: `demangle_const` causes infinite recursion and stack overflow To manage notifications about this bug go to: https://bugs.launchpad.net/binutils/+bug/1974265/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974265] Re: `demangle_const` causes infinite recursion and stack overflow
** Changed in: binutils (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1974265 Title: `demangle_const` causes infinite recursion and stack overflow To manage notifications about this bug go to: https://bugs.launchpad.net/binutils/+bug/1974265/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974265] Re: `demangle_const` causes infinite recursion and stack overflow
Launchpad has imported 3 comments from the remote bug at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105115. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2022-03-31T00:32:23+00:00 2019 wrote: Created attachment 52721 output.txt is output of ASAN, and inf-recursion is the poc At commit `b8e92c571baed4e794bd62b7bf417fa8bbaf5c95` of `binutils-gdb`, the given poc can produces crash on `cxxfilt`: build2/binutils/cxxfilt < inf-recursion Reply at: https://bugs.launchpad.net/ubuntu/+source/binutils/+bug/1974265/comments/0 On 2022-05-17T18:22:53+00:00 2019 wrote: Hello, It's already more than one month since my post, and the bug still exists at latest commit (e.i. e84412c6a3c3eed1a4eca5fe18f329bfa7efea40), so I would like to know why it is still `UNCONFIRMED`. Thanks. Reply at: https://bugs.launchpad.net/ubuntu/+source/binutils/+bug/1974265/comments/1 On 2022-05-17T20:44:54+00:00 2019 wrote: The simplified PoC: $ echo _RYAbB2_ | ./binutils/cxxfilt Segmentation fault Root Cause Analysis: 1. In `rust_demangle_callback`, "_R" at beginning causes `rdm.version == 0`[1][2], so `demangle_path` in the else-branch is called[3] with `rdm.sym == "YAbB2_"`, with `rdm.next` field initialized to 0. 2. Next char 'Y' causes `demangle_type` to be called[4] in a switch-case branch, with `rdm.next == 1`. 3. Next char 'A' causes `demangle_type` to be called first[5] to consume char 'b', then `demangle_const` is called[6] with `rdm.next == 3`. 4. Next char 'B' is consumed[7], and "2_" is parsed as `integer_62`[8] to be value 3, and this vlaue is assigned to `rdm.next`, then `demangle_const` is called recursively[9]. However, currently the situation is `rdm.next == 3` again, which is exactly same as last call to `demangle_const`, and this causes infinite recursion. [1] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L1356 [2] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L1362 [3] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L1453 [4] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L759 [5] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L934 [6] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L938 [7] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L1151 [8] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L1153 [9] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L1158 Possible Fix: The infinite recursion check added in this [commit](https://github.com/bminor/binutils- gdb/commit/f10f8617a302f45dae721eae0cd659911f03d864) should also be applied to `demangle_const` Reply at: https://bugs.launchpad.net/ubuntu/+source/binutils/+bug/1974265/comments/2 ** Changed in: binutils Status: Unknown => New ** Changed in: binutils Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1974265 Title: `demangle_const` causes infinite recursion and stack overflow To manage notifications about this bug go to: https://bugs.launchpad.net/binutils/+bug/1974265/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974265] [NEW] `demangle_const` causes infinite recursion and stack overflow
*** This bug is a security vulnerability *** You have been subscribed to a public security bug by Marc Deslauriers (mdeslaur): Original Post: `https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105115` The bug is similar to CVE-2021-3530, which was reported here: `https://bugs.launchpad.net/ubuntu/+source/binutils/+bug/1925348`. Commit: `e84412c6a3c3eed1a4eca5fe18f329bfa7efea40` at `https://github.com/bminor/binutils-gdb`. The simplified PoC: $ echo _RYAbB2_ | ./binutils/cxxfilt Segmentation fault Root Cause Analysis: 1. In `rust_demangle_callback`, "_R" at beginning causes `rdm.version == 0`[1][2], so `demangle_path` in the else-branch is called[3] with `rdm.sym == "YAbB2_"`, with `rdm.next` field initialized to 0. 2. Next char 'Y' causes `demangle_type` to be called[4] in a switch-case branch, with `rdm.next == 1`. 3. Next char 'A' causes `demangle_type` to be called first[5] to consume char 'b', then `demangle_const` is called[6] with `rdm.next == 3`. 4. Next char 'B' is consumed[7], and "2_" is parsed as `integer_62`[8] to be value 3, and this vlaue is assigned to `rdm.next`, then `demangle_const` is called recursively[9]. However, currently the situation is `rdm.next == 3` again, which is exactly same as last call to `demangle_const`, and this causes infinite recursion. [1] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L1356 [2] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L1362 [3] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L1453 [4] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L759 [5] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L934 [6] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L938 [7] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L1151 [8] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L1153 [9] https://github.com/bminor/binutils-gdb/blob/626d0e40e55c35a4f143b70def498734e8ed3c2a/libiberty/rust-demangle.c#L1158 Possible Fix: The infinite recursion check added in this [commit](https://github.com/bminor/binutils- gdb/commit/f10f8617a302f45dae721eae0cd659911f03d864) should also be applied to `demangle_const` ** Affects: binutils Importance: Unknown Status: Unknown ** Affects: binutils (Ubuntu) Importance: Undecided Status: New -- `demangle_const` causes infinite recursion and stack overflow https://bugs.launchpad.net/bugs/1974265 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to the bug report. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
