[Bug 2054480] Re: [MIR] nbd-client

2024-04-30 Thread Christian Ehrhardt 
Thank you all, with that I sum up the details here. - MIR ack with a few requirements - Security Ack - From here 1. add the tests you mentioned to the package 2. continue to !try! isolation (2058040) 3. ready for promotion in 24.10 4. SRU the tests to 24.04 5. we consider this even ok

[Bug 2054480] Re: [MIR] nbd-client

2024-04-24 Thread Seth Arnold
I gave the nbd-client.c file a very quick read and it looked moderately well-written to me. It feels like it's got nearly three decades of history to it -- solid, been around a while, and maybe you'd do things different if you were doing it again, but it exists today and solves problems, today.

[Bug 2054480] Re: [MIR] nbd-client

2024-04-09 Thread Lukas Märdian
cpaelzer> how about this - sarnold spends 20 minutes, and gives a shallow security review based on this being in main in the past kind of already cpaelzer> if that outcome is good, get it into 24.04 mclemenceau_> thanks cpaelzer sarnold, I'm ok with the plan w.r.t netboot with a preference for

[Bug 2054480] Re: [MIR] nbd-client

2024-04-02 Thread Didier Roche-Tolomelli
With this in light (but we have the wider "everything that is in main for a very long time in ubuntu, even being security reviewed and got multiple uploads), I would agree that -server could have another security/fresh look. Do you think it’s something the security team has the capacity to look?

[Bug 2054480] Re: [MIR] nbd-client

2024-03-25 Thread Mark Esler
Thanks Wouter It appears nbd-client existed in main at some point http://old- releases.ubuntu.com/ubuntu/pool/main/n/nbd/ (thanks Seth). Between this MIR and tree's LP#2056099 I am concerned that Security is being bypassed as NN approaches. That's not to say anything is wrong with how nbd-client

[Bug 2054480] Re: [MIR] nbd-client

2024-03-22 Thread Wouter Verhelst
Not to the best of my knowledge, no. It was moved to main very early on; I think it might've been 15 years ago. Perhaps the MIR prices didn't exist yet back then? I wouldn't know, not having heard of the whole thing until I saw this one pass by  The client's job is to configure an NBD device in

[Bug 2054480] Re: [MIR] nbd-client

2024-03-22 Thread Mark Esler
Was -server code ever reviewed by a MIR? The client contains many ioctl calls. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2054480 Title: [MIR] nbd-client To manage notifications about this bug

[Bug 2054480] Re: [MIR] nbd-client

2024-03-19 Thread Dave Jones
> I really appreciated the detailed bug description. However, some > elements were missing on the MIR template rules and checks, like the > output of lintian pedantic running as per > https://github.com/canonical/ubuntu-mir. Also, some information are > not exact, you state: "* The package

[Bug 2054480] Re: [MIR] nbd-client

2024-03-12 Thread Didier Roche-Tolomelli
It's really nice to have upstream and the debian maintainer looking at this issue too, thanks for joining the conversation and your recent release! :) Review for Source Package: nbd (already in main) with focused on promoting nbd-client [Summary] MIR team ACK under the constraint to resolve the

[Bug 2054480] Re: [MIR] nbd-client

2024-02-27 Thread Lukas Märdian
** Changed in: nbd (Ubuntu) Assignee: (unassigned) => Didier Roche-Tolomelli (didrocks) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2054480 Title: [MIR] nbd-client To manage notifications