[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
I'm not sure by what mechanism this has been fixed, but testing with nss_wins + libsmbclient in precise, I can no longer reproduce a crash due to -Wl,-Bsymbolic-functions. According to the build log at https://launchpad.net/ubuntu/+source/samba/2:3.6.3-1ubuntu1/+build/3228461/+files /buildlog_ubuntu-precise-amd64.samba_2%3A3.6.3-1ubuntu1_BUILDING.txt.gz, the latest samba is built with these options: LDFLAGS= -pie -Wl,-z,relro -L/usr/lib/x86_64-linux-gnu -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -L./bin LDSHFLAGS = -fPIC -shared -Wl,-Bsymbolic -Wl,-z,relro -L/usr/lib/x86_64-linux-gnu -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -L./bin -lc -Wl,-z,defs Perhaps the presence of -Bsymbolic here resolves this. ** Changed in: samba (Ubuntu) Status: Confirmed = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to samba in Ubuntu. https://bugs.launchpad.net/bugs/234901 Title: Please apply upstream patch for dpkg-buildsource To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dpkg/+bug/234901/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
I'm not sure by what mechanism this has been fixed, but testing with nss_wins + libsmbclient in precise, I can no longer reproduce a crash due to -Wl,-Bsymbolic-functions. According to the build log at https://launchpad.net/ubuntu/+source/samba/2:3.6.3-1ubuntu1/+build/3228461/+files /buildlog_ubuntu-precise-amd64.samba_2%3A3.6.3-1ubuntu1_BUILDING.txt.gz, the latest samba is built with these options: LDFLAGS= -pie -Wl,-z,relro -L/usr/lib/x86_64-linux-gnu -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -L./bin LDSHFLAGS = -fPIC -shared -Wl,-Bsymbolic -Wl,-z,relro -L/usr/lib/x86_64-linux-gnu -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -L./bin -lc -Wl,-z,defs Perhaps the presence of -Bsymbolic here resolves this. ** Changed in: samba (Ubuntu) Status: Confirmed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/234901 Title: Please apply upstream patch for dpkg-buildsource To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dpkg/+bug/234901/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
Upstream doesn't impose anything. ubuntu has made the choice to keep that setting via the Dpkg::Vendor infrastructure. Thus marking it as wontfix for dpkg. ** Changed in: dpkg (Ubuntu) Status: New = Won't Fix -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to samba in Ubuntu. https://bugs.launchpad.net/bugs/234901 Title: Please apply upstream patch for dpkg-buildsource -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
Upstream doesn't impose anything. ubuntu has made the choice to keep that setting via the Dpkg::Vendor infrastructure. Thus marking it as wontfix for dpkg. ** Changed in: dpkg (Ubuntu) Status: New = Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/234901 Title: Please apply upstream patch for dpkg-buildsource -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
Thank you for the patch, however,based on cjwatson's comments above, I'm rejecting this patch. Please feel free to remove the patch-rejected tag if you have a new patch that needs to be reviewed. ** Tags added: patch-rejected -- Please apply upstream patch for dpkg-buildsource https://bugs.launchpad.net/bugs/234901 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to samba in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
Thank you for the patch, however,based on cjwatson's comments above, I'm rejecting this patch. Please feel free to remove the patch-rejected tag if you have a new patch that needs to be reviewed. ** Tags added: patch-rejected -- Please apply upstream patch for dpkg-buildsource https://bugs.launchpad.net/bugs/234901 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
** Changed in: samba (Ubuntu) Importance: Undecided = Medium Status: New = Confirmed -- Please apply upstream patch for dpkg-buildsource https://bugs.launchpad.net/bugs/234901 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to samba in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
** Changed in: samba (Ubuntu) Importance: Undecided = Medium Status: New = Confirmed -- Please apply upstream patch for dpkg-buildsource https://bugs.launchpad.net/bugs/234901 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
Given the last comment, shouldn't this be marked as a duplicate of #225741, with that bug having tasks added for krb5, cupsys, and net- snmp-config? (This also brings up the point that those libraries should use pkg-config instead of their own -config application.) -- Please apply upstream patch for dpkg-buildsource https://bugs.launchpad.net/bugs/234901 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to samba in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
Given the last comment, shouldn't this be marked as a duplicate of #225741, with that bug having tasks added for krb5, cupsys, and net- snmp-config? (This also brings up the point that those libraries should use pkg-config instead of their own -config application.) -- Please apply upstream patch for dpkg-buildsource https://bugs.launchpad.net/bugs/234901 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
** Changed in: samba (Ubuntu) Assignee: (unassigned) = Steve Langasek (vorlon) -- Please apply upstream patch for dpkg-buildsource https://bugs.launchpad.net/bugs/234901 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
Thanks for your comment. I got two points from your message. 1. Using linker flag -Bsymbolic-functions for building library is your policy. Certainly it's not bad idea. It makes shared libraries more robust, so it seems to be good manner indeed. (But ... I wonder why not -Bsymbolic instead of -Bsymbolic-functions. Could you tell me the reason?) 2. In some conditions, Samba might not work well if it is built with -Bsymbolic-functions. In further update, the flag -Bsymbolic-functions would be removed from Samba package. Still now I have to say my opinion: - The linker flag -Bsymbolic(-functions) is for build-time usage principally. - Do not force developers to use the flag who link their program against those libraries. As you have already written, dpkg itself doesn't need to be modified. On the other hand, some of *-config scripts apply build-time LDFLAGS for --libs configuration. That make unfortunate consequences. Upon my little investigation, following programs incorrectly state -Bsymbolic-functions when they are called with --libs or --ldflags argument. - krb5-config in krb5 - cups-config in cupsys - net-snmp-config in net-snmp - mysql_config in mysql-dfsg (see https://bugs.launchpad.net/ubuntu/+source/mysql-dfsg-5.0/+bug/225741) More affected packages may exist. There are many many packages in Ubuntu, so I could not cover them all. I think these packages would be modified. Not all of packages (having *-config script) are affected. Some programs (ex. pth-config in pth) don't have -Bsymbolic-functions (but was built with -Bsymbolic-functions). And some packages which support pkg-config (ex. libssl) have -Bsymbolic-functions in Libs.private, not in Libs. Good. -- Please apply upstream patch for dpkg-buildsource https://bugs.launchpad.net/bugs/234901 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to samba in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
Thanks for your comment. I got two points from your message. 1. Using linker flag -Bsymbolic-functions for building library is your policy. Certainly it's not bad idea. It makes shared libraries more robust, so it seems to be good manner indeed. (But ... I wonder why not -Bsymbolic instead of -Bsymbolic-functions. Could you tell me the reason?) 2. In some conditions, Samba might not work well if it is built with -Bsymbolic-functions. In further update, the flag -Bsymbolic-functions would be removed from Samba package. Still now I have to say my opinion: - The linker flag -Bsymbolic(-functions) is for build-time usage principally. - Do not force developers to use the flag who link their program against those libraries. As you have already written, dpkg itself doesn't need to be modified. On the other hand, some of *-config scripts apply build-time LDFLAGS for --libs configuration. That make unfortunate consequences. Upon my little investigation, following programs incorrectly state -Bsymbolic-functions when they are called with --libs or --ldflags argument. - krb5-config in krb5 - cups-config in cupsys - net-snmp-config in net-snmp - mysql_config in mysql-dfsg (see https://bugs.launchpad.net/ubuntu/+source/mysql-dfsg-5.0/+bug/225741) More affected packages may exist. There are many many packages in Ubuntu, so I could not cover them all. I think these packages would be modified. Not all of packages (having *-config script) are affected. Some programs (ex. pth-config in pth) don't have -Bsymbolic-functions (but was built with -Bsymbolic-functions). And some packages which support pkg-config (ex. libssl) have -Bsymbolic-functions in Libs.private, not in Libs. Good. -- Please apply upstream patch for dpkg-buildsource https://bugs.launchpad.net/bugs/234901 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 234901] Re: Please apply upstream patch for dpkg-buildsource
** Attachment added: dpkg.patch http://launchpadlibrarian.net/14708110/dpkg.patch -- Please apply upstream patch for dpkg-buildsource https://bugs.launchpad.net/bugs/234901 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
