[Bug 310088] Re: restore-trash crashes if the original path does not exist (even if it's in the same trash can)
** Changed in: trash-cli (Ubuntu) Status: New = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/310088 Title: restore-trash crashes if the original path does not exist (even if it's in the same trash can) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/trash-cli/+bug/310088/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 310088] Re: restore-trash crashes if the original path does not exist (even if it's in the same trash can)
One more suggestion: Don't name the trash command trash-file unless there are absolutely compulsory reasons for it. My arguments against trash-file: * It is not intuitive and therefore unnecessarily difficult to memorise. * It is unnecessarily long. * Every change in the name of programs causes confusion, so the new solution should be a clear improvement (which it isn't). * It is even wrong: Directories can be trashed, too. Just trash was much better. However, I welcome the renaming of restore-trash to trash-restore, list-trash to trash-list etc. This is intuitive and allows the user to look for the appropriate command with the tab key. -- restore-trash crashes if the original path does not exist (even if it's in the same trash can) https://bugs.launchpad.net/bugs/310088 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 310088] Re: restore-trash crashes if the original path does not exist (even if it's in the same trash can)
Christoph Bloch wrote: One more suggestion: Don't name the trash command trash-file unless there are absolutely compulsory reasons for it. My arguments against trash-file: * It is not intuitive and therefore unnecessarily difficult to memorise. * It is unnecessarily long. * Every change in the name of programs causes confusion, so the new solution should be a clear improvement (which it isn't). * It is even wrong: Directories can be trashed, too. Just trash was much better. I had a long discussion about that with the fedora people. The discussion started on: https://bugzilla.redhat.com/show_bug.cgi?id=448122 And it followed in https://www.redhat.com/archives/fedora-devel- list/2008-October/msg00216.html I would prefer trash as name but they don't allow me to name it trash because the name is too generic. -- restore-trash crashes if the original path does not exist (even if it's in the same trash can) https://bugs.launchpad.net/bugs/310088 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 310088] Re: restore-trash crashes if the original path does not exist (even if it's in the same trash can)
Andrea Francia wrote: And it followed in https://www.redhat.com/archives/fedora-devel-list/2008-October/msg00216.html You can read a summary of the discussion on http://fedoraproject.org/wiki/FWN/Issue147 or if it is down at http://www.google.it/search?q=Fedora+Weekly+News+147 I really don't like the trash-file command name if someone is able to find a better name or know or to make the fedora peoples change its idea please inform me. -- restore-trash crashes if the original path does not exist (even if it's in the same trash can) https://bugs.launchpad.net/bugs/310088 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 310088] Re: restore-trash crashes if the original path does not exist (even if it's in the same trash can)
I did what you suggested:
sudo apt-get remove trash-cli
sudo apt-get install python-setuptools
sudo easy_install trash-cli
Then I did the same procedure as before (trash-file everything from a
directory, trash-file the directory itself, try to restore-trash
(trash-restore?) one of the files.
A. If I try /restore-trash/:
(... List of files ...)
What file to restore [0..53]: 8
Traceback (most recent call last):
File /usr/bin/restore-trash, line 5, in module
pkg_resources.run_script('trash-cli==0.2.1', 'restore-trash')
File /usr/lib/python2.5/site-packages/pkg_resources.py, line 448,
in run_script
self.require(requires)[0].run_script(script_name, ns)
File /usr/lib/python2.5/site-packages/pkg_resources.py, line 1173,
in run_script
exec script_code in namespace, namespace
File /usr/bin/restore-trash, line 39, in module
File build/bdist.linux-i686/egg/trashcli/trash.py, line 322, in
restore
File build/bdist.linux-i686/egg/trashcli/filesystem.py, line 30,
in move
File /usr/lib/python2.5/shutil.py, line 205, in move
copy2(src,dst)
File /usr/lib/python2.5/shutil.py, line 96, in copy2
copyfile(src, dst)
File /usr/lib/python2.5/shutil.py, line 52, in copyfile
fdst = open(dst, 'wb')
IOError: [Errno 2] No such file or directory:
'/home/christoph/test/pons-ds.mobi'
B. If I try /trash-restore/:
$ trash-restore
Traceback (most recent call last):
File /usr/bin/trash-restore, line 5, in module
pkg_resources.run_script('trash-cli==0.2.1', 'trash-restore')
File /usr/lib/python2.5/site-packages/pkg_resources.py, line 448,
in run_script
self.require(requires)[0].run_script(script_name, ns)
File /usr/lib/python2.5/site-packages/pkg_resources.py, line 1172,
in run_script
script_code = compile(script_text,script_filename,'exec')
File
/usr/lib/python2.5/site-packages/trash_cli-0.2.1-py2.5.egg/EGG-INFO/scripts/trash-restore,
line 30
class NoWrapFormatter(optparse.IndentedHelpFormatter) :
^
IndentationError: expected an indented block
Up to you to draw conclusions... I'll be happy to help with further
testing.
By the way, Nautilus cannot really handle the problem either, he just
returns an error message (instead of proposing to create the original
directory).
Good luck fixing this!
--
restore-trash crashes if the original path does not exist (even if it's in the
same trash can)
https://bugs.launchpad.net/bugs/310088
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 310088] Re: restore-trash crashes if the original path does not exist (even if it's in the same trash can)
Hi, I'm the writer of trash-cli. Would you test if the reported behaviour will occour with the latest development version of trash-cli? To install the last version: sudo apt-get remove trash-cli sudo easy_install trash-cli If you don't have easy_install you could install it with apt-get install python-setuptools. Please note that the new version of trash-cli uses a different command nams (trash-file instead of trash, trash-list instead of list-trash, trash-empty instead of empty-trash). -- restore-trash crashes if the original path does not exist (even if it's in the same trash can) https://bugs.launchpad.net/bugs/310088 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
